)]}'
{"nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"dce24ea8f04a938c9f01fd1cb7f767b37c3eeb52","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            rp_obj.Trait.get_by_name(self.ctx, \u0027CUSTOM_GOLD\u0027)"},{"line_number":604,"context_line":"        except exception.TraitNotFound:"},{"line_number":605,"context_line":"            pass"},{"line_number":606,"context_line":"        # TODO(efried): Raises TraitNotFound until bug #1760322 is fixed."},{"line_number":607,"context_line":"        # rp_obj.Trait.get_by_name(self.ctx, os_traits.HW_CPU_X86_AVX2)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_local_with_shared_disk(self):"},{"line_number":610,"context_line":"        \"\"\"Create some resource providers that can satisfy the request for"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_8ab25748","line":607,"range":{"start_line":606,"start_character":0,"end_line":607,"end_character":71},"updated":"2018-04-02 10:09:55.000000000","message":"IIUC, this is not TODO, but the current behavior,.\n... and why not use \"assertRaises\" to validate that behavior?","commit_id":"cc87b4bb55363520f882560678bcd0d8d5a85ef1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d63426bb9999a2dfd3ddff63492ee5d676cb7ed9","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            rp_obj.Trait.get_by_name(self.ctx, \u0027CUSTOM_GOLD\u0027)"},{"line_number":604,"context_line":"        except exception.TraitNotFound:"},{"line_number":605,"context_line":"            pass"},{"line_number":606,"context_line":"        # TODO(efried): Raises TraitNotFound until bug #1760322 is fixed."},{"line_number":607,"context_line":"        # rp_obj.Trait.get_by_name(self.ctx, os_traits.HW_CPU_X86_AVX2)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_local_with_shared_disk(self):"},{"line_number":610,"context_line":"        \"\"\"Create some resource providers that can satisfy the request for"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_17e98bb5","line":607,"range":{"start_line":606,"start_character":0,"end_line":607,"end_character":71},"in_reply_to":"bf659307_8ab25748","updated":"2018-04-02 15:40:04.000000000","message":"Changed to FIXME and added assertRaises as you suggest.","commit_id":"cc87b4bb55363520f882560678bcd0d8d5a85ef1"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"dce24ea8f04a938c9f01fd1cb7f767b37c3eeb52","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            pass"},{"line_number":606,"context_line":"        # TODO(efried): Raises TraitNotFound until bug #1760322 is fixed."},{"line_number":607,"context_line":"        # rp_obj.Trait.get_by_name(self.ctx, os_traits.HW_CPU_X86_AVX2)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_local_with_shared_disk(self):"},{"line_number":610,"context_line":"        \"\"\"Create some resource providers that can satisfy the request for"},{"line_number":611,"context_line":"        resources with local VCPU and MEMORY_MB but rely on a shared storage"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_4aa19ff7","line":608,"updated":"2018-04-02 10:09:55.000000000","message":"IMO, this test should be moved to test_resource_provider.py from test_allocation_candidates.py.\n\nHow about merge this test to existing test_trait_get_non_existed_trait() since both tests are simple enough?\n\nhttps://github.com/openstack/nova/blob/eb637b9de718a5b4c2e29fe4467e374878ce9c7c/nova/tests/functional/db/test_resource_provider.py#L2256-L2258","commit_id":"cc87b4bb55363520f882560678bcd0d8d5a85ef1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d63426bb9999a2dfd3ddff63492ee5d676cb7ed9","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            pass"},{"line_number":606,"context_line":"        # TODO(efried): Raises TraitNotFound until bug #1760322 is fixed."},{"line_number":607,"context_line":"        # rp_obj.Trait.get_by_name(self.ctx, os_traits.HW_CPU_X86_AVX2)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def test_local_with_shared_disk(self):"},{"line_number":610,"context_line":"        \"\"\"Create some resource providers that can satisfy the request for"},{"line_number":611,"context_line":"        resources with local VCPU and MEMORY_MB but rely on a shared storage"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_570ce3a3","line":608,"in_reply_to":"bf659307_4aa19ff7","updated":"2018-04-02 15:40:04.000000000","message":"Yup, excellent point; I just happened to be working in test_allocation_candidates when I found this bug.  Done.","commit_id":"cc87b4bb55363520f882560678bcd0d8d5a85ef1"}]}