)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1a53276af5502a227ba63e7ee245b705501d9706","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(ServiceFixture, self).setUp()"},{"line_number":81,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":82,"context_line":"        self.start_service()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027nova.context.get_admin_context\u0027)"},{"line_number":85,"context_line":"    def start_service(self, mock_get_admin_context):"},{"line_number":86,"context_line":"        if self.cell:"},{"line_number":87,"context_line":"            context.set_target_cell(self.ctxt, self.cell)"},{"line_number":88,"context_line":"        mock_get_admin_context.return_value \u003d self.ctxt"},{"line_number":89,"context_line":"        self.service \u003d service.Service.create(**self.kwargs)"},{"line_number":90,"context_line":"        self.service.start()"},{"line_number":91,"context_line":"        self.addCleanup(self.service.kill)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_4d69b6f6","line":88,"range":{"start_line":81,"start_character":0,"end_line":88,"end_character":55},"updated":"2018-04-02 16:17:08.000000000","message":"Is there any reason you split this into a separate method?  If it was just to make use of the @mock.patch decorator, you can simplify as:\n\n with mock.patch(\u0027nova.context.get_admin_context\u0027, return_value\u003dself.ctxt):\n     self.service \u003d service.Service.create(**self.kwargs)\n     self.service.start()\n self.addCleanup(self.service.kill)","commit_id":"32d4ec44aeca315f1800dff3aaefe9b8b08f2983"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"227bbc128a71341235545482abc1d357319a12b4","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(ServiceFixture, self).setUp()"},{"line_number":81,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":82,"context_line":"        self.start_service()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027nova.context.get_admin_context\u0027)"},{"line_number":85,"context_line":"    def start_service(self, mock_get_admin_context):"},{"line_number":86,"context_line":"        if self.cell:"},{"line_number":87,"context_line":"            context.set_target_cell(self.ctxt, self.cell)"},{"line_number":88,"context_line":"        mock_get_admin_context.return_value \u003d self.ctxt"},{"line_number":89,"context_line":"        self.service \u003d service.Service.create(**self.kwargs)"},{"line_number":90,"context_line":"        self.service.start()"},{"line_number":91,"context_line":"        self.addCleanup(self.service.kill)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_4b8bd766","line":88,"range":{"start_line":81,"start_character":0,"end_line":88,"end_character":55},"in_reply_to":"bf659307_4d69b6f6","updated":"2018-04-03 02:21:35.000000000","message":"Thank you for your advice.\nDone.","commit_id":"32d4ec44aeca315f1800dff3aaefe9b8b08f2983"}]}
