)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"57a04a6cca17f9e13b01007114363dfaf76d9188","unresolved":false,"context_lines":[{"line_number":5510,"context_line":"            # the BDM in swap_volume for future use outside of this flow."},{"line_number":5511,"context_line":"            msg \u003d (\"swap_volume: Calling driver volume swap with \""},{"line_number":5512,"context_line":"                   \"connection infos: new: %(new_cinfo)s; \""},{"line_number":5513,"context_line":"                   \"old: %(old_cinfo)s\","},{"line_number":5514,"context_line":"                   {\u0027new_cinfo\u0027: new_cinfo, \u0027old_cinfo\u0027: old_cinfo})"},{"line_number":5515,"context_line":"            # Both new and old info might contain password"},{"line_number":5516,"context_line":"            LOG.debug(strutils.mask_password(msg), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_38a33302","line":5513,"range":{"start_line":5513,"start_character":39,"end_line":5513,"end_character":40},"updated":"2018-04-04 07:35:29.000000000","message":"String interpolation is not done. It should be \u0027%\u0027.","commit_id":"9d743f5f00624338d92e516185ff45530f4fca3a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c632daf0bea5d928de3fc68b1d7c52686272d713","unresolved":false,"context_lines":[{"line_number":5510,"context_line":"            # the BDM in swap_volume for future use outside of this flow."},{"line_number":5511,"context_line":"            msg \u003d (\"swap_volume: Calling driver volume swap with \""},{"line_number":5512,"context_line":"                   \"connection infos: new: %(new_cinfo)s; \""},{"line_number":5513,"context_line":"                   \"old: %(old_cinfo)s\","},{"line_number":5514,"context_line":"                   {\u0027new_cinfo\u0027: new_cinfo, \u0027old_cinfo\u0027: old_cinfo})"},{"line_number":5515,"context_line":"            # Both new and old info might contain password"},{"line_number":5516,"context_line":"            LOG.debug(strutils.mask_password(msg), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_9836ff02","line":5513,"range":{"start_line":5513,"start_character":39,"end_line":5513,"end_character":40},"in_reply_to":"bf659307_38a33302","updated":"2018-04-04 07:58:41.000000000","message":"Done","commit_id":"9d743f5f00624338d92e516185ff45530f4fca3a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"57a04a6cca17f9e13b01007114363dfaf76d9188","unresolved":false,"context_lines":[{"line_number":5520,"context_line":"            if new_attachment_id:"},{"line_number":5521,"context_line":"                self.volume_api.attachment_complete(context, new_attachment_id)"},{"line_number":5522,"context_line":"            msg \u003d (\"swap_volume: Driver volume swap returned, new \""},{"line_number":5523,"context_line":"                   \"connection_info is now : %(new_cinfo)s\","},{"line_number":5524,"context_line":"                   {\u0027new_cinfo\u0027: new_cinfo})"},{"line_number":5525,"context_line":"            LOG.debug(strutils.mask_password(msg))"},{"line_number":5526,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_385813f8","line":5523,"range":{"start_line":5523,"start_character":59,"end_line":5523,"end_character":60},"updated":"2018-04-04 07:35:29.000000000","message":"ditto","commit_id":"9d743f5f00624338d92e516185ff45530f4fca3a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c632daf0bea5d928de3fc68b1d7c52686272d713","unresolved":false,"context_lines":[{"line_number":5520,"context_line":"            if new_attachment_id:"},{"line_number":5521,"context_line":"                self.volume_api.attachment_complete(context, new_attachment_id)"},{"line_number":5522,"context_line":"            msg \u003d (\"swap_volume: Driver volume swap returned, new \""},{"line_number":5523,"context_line":"                   \"connection_info is now : %(new_cinfo)s\","},{"line_number":5524,"context_line":"                   {\u0027new_cinfo\u0027: new_cinfo})"},{"line_number":5525,"context_line":"            LOG.debug(strutils.mask_password(msg))"},{"line_number":5526,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3839f3f0","line":5523,"range":{"start_line":5523,"start_character":59,"end_line":5523,"end_character":60},"in_reply_to":"bf659307_385813f8","updated":"2018-04-04 07:58:41.000000000","message":"Done","commit_id":"9d743f5f00624338d92e516185ff45530f4fca3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a93f328e162cc01fbdb1881d1b280c6733800030","unresolved":false,"context_lines":[{"line_number":5513,"context_line":"                   \"old: %(old_cinfo)s\" %"},{"line_number":5514,"context_line":"                   {\u0027new_cinfo\u0027: new_cinfo, \u0027old_cinfo\u0027: old_cinfo})"},{"line_number":5515,"context_line":"            # Both new and old info might contain password"},{"line_number":5516,"context_line":"            LOG.debug(strutils.mask_password(msg), instance\u003dinstance)"},{"line_number":5517,"context_line":""},{"line_number":5518,"context_line":"            self.driver.swap_volume(context, old_cinfo, new_cinfo, instance,"},{"line_number":5519,"context_line":"                                    mountpoint, resize_to)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_73d409be","line":5516,"updated":"2018-04-18 20:01:27.000000000","message":"I had a patch up for this for a long time but was dragging my feet on getting the test working:\n\nhttps://review.openstack.org/#/c/466533/5/nova/compute/manager.py\n\nAlso note in that change that rather than mask the password first and pass it to LOG.debug, I was checking to see if debug was even enabled to save time on the mask_password call.","commit_id":"1b61d6c08c7c86834acab45320230824b88d529c"}]}