)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6771,"name":"tiago-martins","email":"tiago.ferraz@gmail.com","username":"tiago-martins"},"change_message_id":"1ddcbcfa34b064d825ad8a83ec4910d3d43113d7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the variables domain_id, project_domain_id and user_domain_id to"},{"line_number":10,"context_line":"the RequestContext. If the information is not in the header (for example,"},{"line_number":11,"context_line":"if you\u0027re using Keystone V2.0 API) the variables are setted tow \u0027default\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ice7805041d2df72d603e9d56a5df4cf7f5489992"},{"line_number":14,"context_line":"Closes-bug: #1248936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FG0A%3D","line":11,"updated":"2013-11-14 11:07:01.000000000","message":"typo: \u0027tow\u0027","commit_id":"4c28f00f3583e516163350d841995927f03e265f"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"1e8ae8d682021f08e687bbbe32d09bdb57f7b734","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the variables domain_id, project_domain_id and user_domain_id to"},{"line_number":10,"context_line":"the RequestContext. If the information is not in the header (for example,"},{"line_number":11,"context_line":"if you\u0027re using Keystone V2.0 API) the variables are setted to \u0027default\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ice7805041d2df72d603e9d56a5df4cf7f5489992"},{"line_number":14,"context_line":"Closes-bug: #1248936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F93Xc%3D","line":11,"updated":"2013-12-05 04:13:15.000000000","message":"I was wondering if you could explain the reasoning behind setting the values of these to \u0027default\u0027 rather than None if they are not set?","commit_id":"d0104c860ef1e9445da8dffed99c5087c7cbe8d1"},{"author":{"_account_id":8810,"name":"Francisco Demontiê dos Santos Junior","email":"demontie@lsd.ufcg.edu.br","username":"demontiejr"},"change_message_id":"bcd7c7d26d84249c6a0cc083b6d7b179bac7bfa9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the variables domain_id, project_domain_id and user_domain_id to"},{"line_number":10,"context_line":"the RequestContext. If the information is not in the header (for example,"},{"line_number":11,"context_line":"if you\u0027re using Keystone V2.0 API) the variables are setted to \u0027default\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ice7805041d2df72d603e9d56a5df4cf7f5489992"},{"line_number":14,"context_line":"Closes-bug: #1248936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9zjU%3D","line":11,"in_reply_to":"AAAATn%2F93Xc%3D","updated":"2013-12-05 18:00:44.000000000","message":"Actually I think the right behavior should be: if there\u0027s no domain information, set all of them to \u0027default\u0027 (the default domain for Keystone V2.0), else set the values in the header or None for the ones which are not in the header. What do you think?","commit_id":"d0104c860ef1e9445da8dffed99c5087c7cbe8d1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e6d30b9622313a84fcf5e8949bef93c66082197","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the variables domain_id, project_domain_id and user_domain_id to"},{"line_number":10,"context_line":"the RequestContext. If no domain information is in the header the variables"},{"line_number":11,"context_line":"are setted to \u0027default\u0027, since it\u0027s the default value for domain in"},{"line_number":12,"context_line":"Keystone V2.0 API."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Refs: blueprint add-domain-info-to-context"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATn%2F9ltE%3D","line":11,"updated":"2013-12-09 22:09:09.000000000","message":"s/setted/set/","commit_id":"54d439ffd8edcc962bc431faeff714cf08e82639"}],"nova/api/auth.py":[{"author":{"_account_id":6771,"name":"tiago-martins","email":"tiago.ferraz@gmail.com","username":"tiago-martins"},"change_message_id":"1ddcbcfa34b064d825ad8a83ec4910d3d43113d7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        user_name \u003d req.headers.get(\u0027X_USER_NAME\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        def from_request_or_default(header):"},{"line_number":102,"context_line":"            return req.headers[header] if header in req.headers else \"default\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        domain_id \u003d from_request_or_default(\u0027X_DOMAIN_ID\u0027)"},{"line_number":105,"context_line":"        project_domain_id \u003d from_request_or_default(\u0027X_PROJECT_DOMAIN_ID\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FGzw%3D","line":102,"updated":"2013-11-14 11:07:01.000000000","message":"change \" to \u0027 for consistency","commit_id":"4c28f00f3583e516163350d841995927f03e265f"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"4aac8543ac0885c305da7b12ba8ceee3a0772c73","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            domain_id \u003d \u0027default\u0027"},{"line_number":112,"context_line":"            project_domain_id \u003d \u0027default\u0027"},{"line_number":113,"context_line":"            user_domain_id \u003d \u0027default\u0027        "},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        # Get the auth token"},{"line_number":116,"context_line":"        auth_token \u003d req.headers.get(\u0027X_AUTH_TOKEN\u0027,"},{"line_number":117,"context_line":"                                     req.headers.get(\u0027X_STORAGE_TOKEN\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9zbU%3D","line":114,"updated":"2013-12-05 18:21:42.000000000","message":"Fix the space","commit_id":"0f0541c3609b5d6f7ec2a9d25676288a4066acba"}]}