)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"6de39767d7d8d531b49712c4712183a169f009d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove mute_weight_value option on mute child weigher"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With weight normalization it is not needed anymore to inflate the"},{"line_number":10,"context_line":"weights so that one weiger can win, since this can be made just by"},{"line_number":11,"context_line":"adjusting the multiplier. This change does not break backwards"},{"line_number":12,"context_line":"compatibility, since the multiplier has been also increased so that it"},{"line_number":13,"context_line":"actually mutes the other weighers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2BreU%3D","line":10,"updated":"2013-11-21 16:42:20.000000000","message":"(nit) weiger -\u003e weigher","commit_id":"31fa1363f2a114e131d9dc3d3fbab5967ce338ae"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"1ebb6a4a456ca95d3db501ca532fb9cdf650aaaa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove mute_weight_value option on mute child weigher"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With weight normalization it is not needed anymore to inflate the"},{"line_number":10,"context_line":"weights so that one weiger can win, since this can be made just by"},{"line_number":11,"context_line":"adjusting the multiplier. This change does not break backwards"},{"line_number":12,"context_line":"compatibility, since the multiplier has been also increased so that it"},{"line_number":13,"context_line":"actually mutes the other weighers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2BoYc%3D","line":10,"in_reply_to":"AAAATn%2F%2BreU%3D","updated":"2013-11-22 08:28:15.000000000","message":"Thanks!","commit_id":"31fa1363f2a114e131d9dc3d3fbab5967ce338ae"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fcbcf86fbbf2a7098d6a905ec501a5bc2b35e628","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mute_weight_value flag to inflate the weigher\u0027s value. This was needed"},{"line_number":11,"context_line":"before weight normalization was in place, so that the weigher could win"},{"line_number":12,"context_line":"against other weighers. Now, with weight normalization in place this is"},{"line_number":13,"context_line":"not neededanymore, since the maximum value that a weigher would take will"},{"line_number":14,"context_line":"be 1.0 (weights are normalized between 0.0 and 1.0). We should use the"},{"line_number":15,"context_line":"multiplier to get the same behavior (i.e. make the weigher prevail"},{"line_number":16,"context_line":"against other weighers), the multiplier has been also increased so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"da9df570_8c6a44b1","line":13,"updated":"2014-09-26 02:08:08.000000000","message":"s/neededanymore/needed any more/ :)","commit_id":"8ede301a88b97bf6aa3fd82a6efe879221006080"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"bae069ed821fe4b404744c855cf010f5200799f8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mute_weight_value flag to inflate the weigher\u0027s value. This was needed"},{"line_number":11,"context_line":"before weight normalization was in place, so that the weigher could win"},{"line_number":12,"context_line":"against other weighers. Now, with weight normalization in place this is"},{"line_number":13,"context_line":"not neededanymore, since the maximum value that a weigher would take will"},{"line_number":14,"context_line":"be 1.0 (weights are normalized between 0.0 and 1.0). We should use the"},{"line_number":15,"context_line":"multiplier to get the same behavior (i.e. make the weigher prevail"},{"line_number":16,"context_line":"against other weighers), the multiplier has been also increased so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"da9df570_3267eab8","line":13,"in_reply_to":"da9df570_8c6a44b1","updated":"2014-09-26 12:19:33.000000000","message":"Nice catch.","commit_id":"8ede301a88b97bf6aa3fd82a6efe879221006080"}],"nova/cells/weights/mute_child.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ceed0cd6618279c84fb21b90a6e27db58cfa341d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"          cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                  default\u003d1000.0,"},{"line_number":37,"context_line":"                  help\u003d\u0027DEPRECATED.\u0027"},{"line_number":38,"context_line":"                       \u0027Weight value assigned to mute children.  (The value \u0027"},{"line_number":39,"context_line":"                       \u0027should be positive.)\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2FwyA%3D","line":37,"updated":"2014-02-10 23:25:34.000000000","message":"can you add a comment in the code saying this was deprecated in icehouse and should be removed in Juno.","commit_id":"841ce9af2670c3cfb2d7f41e6ec53b1e8f9de3df"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"bd73bfd503f1549f802b7a96565f4c341d461f77","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"          cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                  default\u003d1000.0,"},{"line_number":37,"context_line":"                  help\u003d\u0027DEPRECATED.\u0027"},{"line_number":38,"context_line":"                       \u0027Weight value assigned to mute children.  (The value \u0027"},{"line_number":39,"context_line":"                       \u0027should be positive.)\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2FtE4%3D","line":37,"in_reply_to":"AAAAUX%2F%2FwyA%3D","updated":"2014-02-11 12:12:19.000000000","message":"Sure.","commit_id":"841ce9af2670c3cfb2d7f41e6ec53b1e8f9de3df"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"966cb9cafd6622b140b0c65f65834239ceb519a0","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"mute_weigher_opts \u003d ["},{"line_number":31,"context_line":"        cfg.FloatOpt(\u0027mute_weight_multiplier\u0027,"},{"line_number":32,"context_line":"                default\u003d-10000.0,"},{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"1abeadc6_898a44bd","line":32,"updated":"2014-08-21 12:35:57.000000000","message":"Why have you changed this default?\n\nIt doesn\u0027t seem clear why from the commit message.","commit_id":"dc877f1955a8e2b633d1fcd595b9039c0224ea7d"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"48d4ec656db4da75d224d52415527a336952a702","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"mute_weigher_opts \u003d ["},{"line_number":31,"context_line":"        cfg.FloatOpt(\u0027mute_weight_multiplier\u0027,"},{"line_number":32,"context_line":"                default\u003d-10000.0,"},{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"1abeadc6_3a06cc1d","line":32,"in_reply_to":"1abeadc6_898a44bd","updated":"2014-08-21 13:38:27.000000000","message":"Before you had to use a huge negative weight to mute a child. Now, the maximum weight will be 1.0 (after normalization), so we need to use a multiplier big enough to have the same behaviour.","commit_id":"dc877f1955a8e2b633d1fcd595b9039c0224ea7d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fcbcf86fbbf2a7098d6a905ec501a5bc2b35e628","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                default\u003d-10.0,"},{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"        cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                default\u003d1000.0,"},{"line_number":37,"context_line":"                help\u003d\u0027Weight value assigned to mute children. (The value \u0027"},{"line_number":38,"context_line":"                     \u0027should be positive.)\u0027),"}],"source_content_type":"text/x-python","patch_set":19,"id":"da9df570_ac6708e8","side":"PARENT","line":35,"updated":"2014-09-26 02:08:08.000000000","message":"I believe in a previous comment you said you were going to mark this option as deprecated instead of removing it? In the help text, you can just note that the mute_weight_multiplier is the only option that has any effect any more. This way, if mute_weight_value option is in nova.conf, then at least we will emit a warning instead of dying on server startup.","commit_id":"9bc59c02d5d4fdf2237760ba4a80bc64e68fb179"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"bae069ed821fe4b404744c855cf010f5200799f8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                default\u003d-10.0,"},{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"        cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                default\u003d1000.0,"},{"line_number":37,"context_line":"                help\u003d\u0027Weight value assigned to mute children. (The value \u0027"},{"line_number":38,"context_line":"                     \u0027should be positive.)\u0027),"}],"source_content_type":"text/x-python","patch_set":19,"id":"da9df570_d2cf7e7d","side":"PARENT","line":35,"in_reply_to":"da9df570_ac6708e8","updated":"2014-09-26 12:19:33.000000000","message":"I agree, I will mark it as deprecated.","commit_id":"9bc59c02d5d4fdf2237760ba4a80bc64e68fb179"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"1fbb396f7cd9de4470f3507bd389aa2eac8ddc5f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        super(MuteChildWeigher, self).__init__()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if CONF.cells.mute_weight_value is not None:"},{"line_number":59,"context_line":"            msg \u003d _LW(\u0027\"mute_weight_value\" has been DEPRECATED as of the Juno \u0027"},{"line_number":60,"context_line":"                      \u0027release, and Nova is still configured to use it. \u0027"},{"line_number":61,"context_line":"                      \u0027Take into account that this option will have no effect \u0027"},{"line_number":62,"context_line":"                      \u0027at all, so please, use \"mute_weight_multiplier\" \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"baa201ad_7a41e60a","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":15},"updated":"2014-09-29 11:35:44.000000000","message":"I think this variable is redundant, write a message in `LOG`.","commit_id":"c15baa2517b8cf80bf53e55c7a659e6ff57822d7"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"1fbb396f7cd9de4470f3507bd389aa2eac8ddc5f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                      \u0027Take into account that this option will have no effect \u0027"},{"line_number":62,"context_line":"                      \u0027at all, so please, use \"mute_weight_multiplier\" \u0027"},{"line_number":63,"context_line":"                      \u0027instead.\u0027)"},{"line_number":64,"context_line":"            LOG.warn(msg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def weight_multiplier(self):"},{"line_number":67,"context_line":"        # negative multiplier \u003d\u003e lower weight"}],"source_content_type":"text/x-python","patch_set":21,"id":"baa201ad_5aeee223","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":20},"updated":"2014-09-29 11:35:44.000000000","message":"Please use `LOG.warning` instead `LOG.warn` due to compatibility with py3.","commit_id":"c15baa2517b8cf80bf53e55c7a659e6ff57822d7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6d264f31fe394d334b0ce425be4a8f42f5638a0c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":35,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":36,"context_line":"        cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":37,"context_line":"                     default\u003dNone,"},{"line_number":38,"context_line":"                     help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":39,"context_line":"                          \u0027Please use \"mute_weight_multiplier\" instead. \u0027"},{"line_number":40,"context_line":"                          \u0027This option will be removed in L.\"\u0027),"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a8c0949_7a87dbd7","line":37,"updated":"2014-11-05 07:34:30.000000000","message":"the default value for configuration vars is None. So you do not specifically need to set this as None.","commit_id":"7c630954dfcd53382f0f4778a271a3de8fa20f16"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ecd285d4fde7855ceceeabe5441cb3391ae57e31","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"        cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                     help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":37,"context_line":"                          \u0027Please use \"mute_weight_multiplier\" instead. \u0027"},{"line_number":38,"context_line":"                          \u0027This option will be removed in L.\"\u0027),"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_902ddf97","line":36,"updated":"2015-01-26 18:53:38.000000000","message":"Please use the correct DeprecatedOpt object for describing a deprecated option. See http://docs.openstack.org/developer/oslo.config/opts.html for further details","commit_id":"ac99bb0903bf721a4b54d9470939c544b46bee15"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c935a824564c809977db9aec012f1ef5dfae5fe8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"        cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                     help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":37,"context_line":"                          \u0027Please use \"mute_weight_multiplier\" instead. \u0027"},{"line_number":38,"context_line":"                          \u0027This option will be removed in L.\"\u0027),"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":31,"id":"da9b358b_9fd161d0","line":36,"in_reply_to":"1a930d6b_902ddf97","updated":"2015-03-30 18:18:09.000000000","message":"DeprecatedOpt is for moving it to another section or renaming it.  If it\u0027s going away, you want to use the deprecated_for_removal\u003dTrue kwarg.","commit_id":"ac99bb0903bf721a4b54d9470939c544b46bee15"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"d967082f75b63c75248935d50d6db2350ec808f0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                help\u003d\u0027Multiplier used to weigh mute children. (The value \u0027"},{"line_number":34,"context_line":"                     \u0027should be negative.)\u0027),"},{"line_number":35,"context_line":"        cfg.FloatOpt(\u0027mute_weight_value\u0027,"},{"line_number":36,"context_line":"                     help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":37,"context_line":"                          \u0027Please use \"mute_weight_multiplier\" instead. \u0027"},{"line_number":38,"context_line":"                          \u0027This option will be removed in L.\"\u0027),"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":31,"id":"da9b358b_2acfac57","line":36,"in_reply_to":"da9b358b_9fd161d0","updated":"2015-03-30 20:40:56.000000000","message":"Thanks, Matt.","commit_id":"ac99bb0903bf721a4b54d9470939c544b46bee15"}],"nova/cells/weights/weight_offset.py":[{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"ef4813a4aa074f56fd6002bc4522984cab769662","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova.cells import weights"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"weigher_opts \u003d ["},{"line_number":26,"context_line":"        cfg.FloatOpt(\u0027offset_weight_multiplier\u0027,"},{"line_number":27,"context_line":"                default\u003d1.0,"},{"line_number":28,"context_line":"                help\u003d\u0027Multiplier used to weigh offset weigher.\u0027),"},{"line_number":29,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B%2FH4%3D","line":26,"updated":"2013-11-16 11:42:51.000000000","message":"Arg, I messed with whitespace here.","commit_id":"412c9d0e68e288b36137978079acf61273554c5c"}]}