)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"d2f9e71b30db70737c124ea4b8a32fca3af5a74c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     DuYaHong \u003cyahongdu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-12 14:51:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Preserve config drive image after the instance is resized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we configure config_drive_cdrom\u003dTrue in nova.conf,"},{"line_number":10,"context_line":"the config drive image will be lost after the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2B6GI%3D","line":7,"updated":"2013-11-18 17:52:46.000000000","message":"Could you please add Hyper-v: in beginning of the title?","commit_id":"0644bde471497e50ff5226fb8ddb85c9293fa5e1"},{"author":{"_account_id":8107,"name":"Ya Hong Du","email":"du_yahong@126.com","username":"yahongdu"},"change_message_id":"69a34634dc9a93f44f13969df7509745b38108cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     DuYaHong \u003cyahongdu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-12 14:51:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Preserve config drive image after the instance is resized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we configure config_drive_cdrom\u003dTrue in nova.conf,"},{"line_number":10,"context_line":"the config drive image will be lost after the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2Bypk%3D","line":7,"in_reply_to":"AAAATn%2F%2B6GI%3D","updated":"2013-11-20 05:50:42.000000000","message":"Done","commit_id":"0644bde471497e50ff5226fb8ddb85c9293fa5e1"}],"nova/tests/virt/hyperv/test_vmutils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f9f0ea3daa87be43cd63affd0ce8f5946c7cfa5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            wmi_result_class\u003d\u0027Msvm_VirtualSystemSettingData\u0027)"},{"line_number":107,"context_line":"        mock_vmsettings[0].associators.assert_called_with("},{"line_number":108,"context_line":"            wmi_result_class\u003d\u0027Msvm_ResourceAllocationSettingData\u0027)"},{"line_number":109,"context_line":"        self.assertIn(self._FAKE_VHD_PATH, disk_files)"},{"line_number":110,"context_line":"        self.assertIn(self._FAKE_DVD_PATH, disk_files)"},{"line_number":111,"context_line":"        self.assertIn(self._FAKE_VOLUME_DRIVE_PATH, volume_drives)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2Fvcw%3D","line":109,"updated":"2014-01-02 15:57:06.000000000","message":"Is disk_files sorted?  If so, you could do assertEqual with a list rather than assertIn.","commit_id":"58ba9fffd73a1640f3cfaf2e11699f488da39ad1"},{"author":{"_account_id":8107,"name":"Ya Hong Du","email":"du_yahong@126.com","username":"yahongdu"},"change_message_id":"7017093e60752046b0b25cf0c67457b10c94dd31","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            wmi_result_class\u003d\u0027Msvm_VirtualSystemSettingData\u0027)"},{"line_number":107,"context_line":"        mock_vmsettings[0].associators.assert_called_with("},{"line_number":108,"context_line":"            wmi_result_class\u003d\u0027Msvm_ResourceAllocationSettingData\u0027)"},{"line_number":109,"context_line":"        self.assertIn(self._FAKE_VHD_PATH, disk_files)"},{"line_number":110,"context_line":"        self.assertIn(self._FAKE_DVD_PATH, disk_files)"},{"line_number":111,"context_line":"        self.assertIn(self._FAKE_VOLUME_DRIVE_PATH, volume_drives)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2Ftd0%3D","line":109,"in_reply_to":"AAAAT3%2F%2Fvcw%3D","updated":"2014-01-03 03:11:28.000000000","message":"Done","commit_id":"58ba9fffd73a1640f3cfaf2e11699f488da39ad1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f9f0ea3daa87be43cd63affd0ce8f5946c7cfa5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            wmi_result_class\u003d\u0027Msvm_ResourceAllocationSettingData\u0027)"},{"line_number":109,"context_line":"        self.assertIn(self._FAKE_VHD_PATH, disk_files)"},{"line_number":110,"context_line":"        self.assertIn(self._FAKE_DVD_PATH, disk_files)"},{"line_number":111,"context_line":"        self.assertIn(self._FAKE_VOLUME_DRIVE_PATH, volume_drives)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2Fvc4%3D","line":111,"updated":"2014-01-02 15:57:06.000000000","message":"This didn\u0027t need to change to assertIn from assertEqual.","commit_id":"58ba9fffd73a1640f3cfaf2e11699f488da39ad1"},{"author":{"_account_id":8107,"name":"Ya Hong Du","email":"du_yahong@126.com","username":"yahongdu"},"change_message_id":"7017093e60752046b0b25cf0c67457b10c94dd31","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            wmi_result_class\u003d\u0027Msvm_ResourceAllocationSettingData\u0027)"},{"line_number":109,"context_line":"        self.assertIn(self._FAKE_VHD_PATH, disk_files)"},{"line_number":110,"context_line":"        self.assertIn(self._FAKE_DVD_PATH, disk_files)"},{"line_number":111,"context_line":"        self.assertIn(self._FAKE_VOLUME_DRIVE_PATH, volume_drives)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2Ftds%3D","line":111,"in_reply_to":"AAAAT3%2F%2Fvc4%3D","updated":"2014-01-03 03:11:28.000000000","message":"Done","commit_id":"58ba9fffd73a1640f3cfaf2e11699f488da39ad1"}],"nova/virt/hyperv/vmutils.py":[{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"c78d0fc636d88ae42b49af97223cfd0afeadbea5","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        rasds \u003d vmsettings[0].associators("},{"line_number":383,"context_line":"            wmi_result_class\u003d\u0027Msvm_ResourceAllocationSettingData\u0027)"},{"line_number":384,"context_line":"        disk_resources \u003d []"},{"line_number":385,"context_line":"        if CONF.hyperv.config_drive_cdrom:"},{"line_number":386,"context_line":"            disk_resources \u003d [r for r in rasds"},{"line_number":387,"context_line":"                              if r.ResourceSubType \u003d\u003d"},{"line_number":388,"context_line":"                              self._IDE_DISK_RES_SUB_TYPE"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B6C0%3D","line":385,"updated":"2013-11-18 18:03:39.000000000","message":"The conditional logic is not necessary. Beside config drives there\u0027s no other way to have DVD resources. \n\nYou can also make it a bit leaner with:\n\nr.ResourceSubType in [                           self._IDE_DISK_RES_SUB_TYPE,\nself._IDE_DVD_RES_SUB_TYPE]","commit_id":"0644bde471497e50ff5226fb8ddb85c9293fa5e1"},{"author":{"_account_id":8107,"name":"Ya Hong Du","email":"du_yahong@126.com","username":"yahongdu"},"change_message_id":"69a34634dc9a93f44f13969df7509745b38108cc","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        rasds \u003d vmsettings[0].associators("},{"line_number":383,"context_line":"            wmi_result_class\u003d\u0027Msvm_ResourceAllocationSettingData\u0027)"},{"line_number":384,"context_line":"        disk_resources \u003d []"},{"line_number":385,"context_line":"        if CONF.hyperv.config_drive_cdrom:"},{"line_number":386,"context_line":"            disk_resources \u003d [r for r in rasds"},{"line_number":387,"context_line":"                              if r.ResourceSubType \u003d\u003d"},{"line_number":388,"context_line":"                              self._IDE_DISK_RES_SUB_TYPE"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bypg%3D","line":385,"in_reply_to":"AAAATn%2F%2B6C0%3D","updated":"2013-11-20 05:50:42.000000000","message":"Done","commit_id":"0644bde471497e50ff5226fb8ddb85c9293fa5e1"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"176b8917217e2848079b56ac4f475b78f9bedb2c","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        disk_resources \u003d [r for r in rasds"},{"line_number":386,"context_line":"                            if r.ResourceSubType in"},{"line_number":387,"context_line":"                            [self._IDE_DISK_RES_SUB_TYPE,"},{"line_number":388,"context_line":"                            self._IDE_DVD_RES_SUB_TYPE]]"},{"line_number":389,"context_line":"        volume_resources \u003d [r for r in rasds"},{"line_number":390,"context_line":"                            if r.ResourceSubType \u003d\u003d"},{"line_number":391,"context_line":"                            self._PHYS_DISK_RES_SUB_TYPE]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bydg%3D","line":388,"updated":"2013-11-23 13:37:05.000000000","message":"nit: alignment one space left","commit_id":"3db764330a9a267fb8aea8eefc22ffc5a06739a2"},{"author":{"_account_id":8107,"name":"Ya Hong Du","email":"du_yahong@126.com","username":"yahongdu"},"change_message_id":"66d8227c48bd29d73439312a06cab2f9705bcf87","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        disk_resources \u003d [r for r in rasds"},{"line_number":386,"context_line":"                            if r.ResourceSubType in"},{"line_number":387,"context_line":"                            [self._IDE_DISK_RES_SUB_TYPE,"},{"line_number":388,"context_line":"                            self._IDE_DVD_RES_SUB_TYPE]]"},{"line_number":389,"context_line":"        volume_resources \u003d [r for r in rasds"},{"line_number":390,"context_line":"                            if r.ResourceSubType \u003d\u003d"},{"line_number":391,"context_line":"                            self._PHYS_DISK_RES_SUB_TYPE]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BbL0%3D","line":388,"in_reply_to":"AAAATn%2F%2Bydg%3D","updated":"2013-11-26 08:52:21.000000000","message":"Done","commit_id":"3db764330a9a267fb8aea8eefc22ffc5a06739a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d45cf5c8c86d507b858ae3607cb976c9713843e","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        disk_resources \u003d [r for r in rasds"},{"line_number":385,"context_line":"                          if r.ResourceSubType in"},{"line_number":386,"context_line":"                          [self._IDE_DISK_RES_SUB_TYPE,"},{"line_number":387,"context_line":"                          self._IDE_DVD_RES_SUB_TYPE]]"},{"line_number":388,"context_line":"        volume_resources \u003d [r for r in rasds"},{"line_number":389,"context_line":"                            if r.ResourceSubType \u003d\u003d"},{"line_number":390,"context_line":"                            self._PHYS_DISK_RES_SUB_TYPE]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8qUA%3D","line":387,"updated":"2013-12-23 15:26:42.000000000","message":"get_vm_storage_paths isn\u0027t overridden in vmutilsv2 but I do see these constants in the v2 utils:\n\n    _IDE_DISK_RES_SUB_TYPE \u003d \u0027Microsoft:Hyper-V:Virtual Hard Disk\u0027\n\n    _IDE_DVD_RES_SUB_TYPE \u003d \u0027Microsoft:Hyper-V:Virtual CD/DVD Disk\u0027\n\nSo does this bug also fix the problem for the hyper-v v2 API or only v1?","commit_id":"feeb0393bb38629c0bbec405ebf7c3f034659d8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1180f764589b3fcf972fbfc82033048a3cc61a1d","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        disk_resources \u003d [r for r in rasds"},{"line_number":385,"context_line":"                          if r.ResourceSubType in"},{"line_number":386,"context_line":"                          [self._IDE_DISK_RES_SUB_TYPE,"},{"line_number":387,"context_line":"                          self._IDE_DVD_RES_SUB_TYPE]]"},{"line_number":388,"context_line":"        volume_resources \u003d [r for r in rasds"},{"line_number":389,"context_line":"                            if r.ResourceSubType \u003d\u003d"},{"line_number":390,"context_line":"                            self._PHYS_DISK_RES_SUB_TYPE]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8qQg%3D","line":387,"in_reply_to":"AAAATn%2F8qUA%3D","updated":"2013-12-23 15:32:52.000000000","message":"Ha, nevermind, I shouldn\u0027t be doing code reviews when my kid is under foot.  The vmutilsv2 module overrides those constants so this works for v2 also.","commit_id":"feeb0393bb38629c0bbec405ebf7c3f034659d8b"}]}