)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"28954f9e4034fc49c3119519db623df829f40915","unresolved":false,"context_lines":[{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"            nets_in_requested_order.append(network)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"            zone \u003d \u0027compute:%s\u0027 % instance.availability_zone"},{"line_number":1036,"context_line":"            port_req_body \u003d {\u0027port\u0027: {\u0027device_id\u0027: instance.uuid,"},{"line_number":1037,"context_line":"                                      \u0027device_owner\u0027: zone}}"},{"line_number":1038,"context_line":"            if (requested_ports_dict and"},{"line_number":1039,"context_line":"                request.port_id in requested_ports_dict and"},{"line_number":1040,"context_line":"                requested_ports_dict[request.port_id].get(BINDING_PROFILE)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9775c201","line":1037,"range":{"start_line":1035,"start_character":12,"end_line":1037,"end_character":60},"updated":"2018-12-19 20:25:52.000000000","message":"Note to self: here\u0027s the format for the device_owner.","commit_id":"93802619adde69bf84d26d7231480abb4da07c91"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"28954f9e4034fc49c3119519db623df829f40915","unresolved":false,"context_lines":[{"line_number":2526,"context_line":"        # be unbound, albeit still logically attached to the instance (for the"},{"line_number":2527,"context_line":"        # shelve scenario). If _unbind_ports was going to be leveraged here, it"},{"line_number":2528,"context_line":"        # would have to be adjusted a bit since it currently clears the"},{"line_number":2529,"context_line":"        # device_id field on the port which is not what we\u0027d want for shelve."},{"line_number":2530,"context_line":"        pass"},{"line_number":2531,"context_line":""},{"line_number":2532,"context_line":"    def _get_pci_devices_from_migration_context(self, migration_context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f7c7563d","line":2529,"updated":"2018-12-19 20:25:52.000000000","message":"++","commit_id":"93802619adde69bf84d26d7231480abb4da07c91"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"83471d7a33ccb1b61b0c3a21fff7ae925f7eba19","unresolved":false,"context_lines":[{"line_number":2584,"context_line":""},{"line_number":2585,"context_line":"            # If the host hasn\u0027t changed, like in the case of resizing to the"},{"line_number":2586,"context_line":"            # same host, there is nothing to do."},{"line_number":2587,"context_line":"            if p.get(BINDING_HOST_ID) !\u003d host:"},{"line_number":2588,"context_line":"                updates[BINDING_HOST_ID] \u003d host"},{"line_number":2589,"context_line":"                # If the host changed, the AZ could have also changed so we"},{"line_number":2590,"context_line":"                # need to update the device_owner."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3e82d4c9","line":2587,"range":{"start_line":2587,"start_character":12,"end_line":2587,"end_character":46},"updated":"2018-04-09 20:31:45.000000000","message":"Note to self, in the single node devstack case, this will be False because of the TODO in cleanup_instance_network_on_host, i.e. since we don\u0027t clear the port binding:host value on shelve offload, when we unshelve on the same host (single node devstack), this is False so we don\u0027t update the device_owner. Not really something that would be an issue in a production environment with real computes (where there is more than one), but just something I noticed while verify the fix in my recreate environment.","commit_id":"93802619adde69bf84d26d7231480abb4da07c91"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"28954f9e4034fc49c3119519db623df829f40915","unresolved":false,"context_lines":[{"line_number":2584,"context_line":""},{"line_number":2585,"context_line":"            # If the host hasn\u0027t changed, like in the case of resizing to the"},{"line_number":2586,"context_line":"            # same host, there is nothing to do."},{"line_number":2587,"context_line":"            if p.get(BINDING_HOST_ID) !\u003d host:"},{"line_number":2588,"context_line":"                updates[BINDING_HOST_ID] \u003d host"},{"line_number":2589,"context_line":"                # If the host changed, the AZ could have also changed so we"},{"line_number":2590,"context_line":"                # need to update the device_owner."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_572deaf8","line":2587,"range":{"start_line":2587,"start_character":12,"end_line":2587,"end_character":46},"in_reply_to":"bf659307_3e82d4c9","updated":"2018-12-19 20:25:52.000000000","message":"Good to note.","commit_id":"93802619adde69bf84d26d7231480abb4da07c91"}]}
