)]}'
{"nova/tests/unit/virt/test_virt_drivers.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5af7de48bd316cc1d941053329a7b33275b478ad","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                      \" needed to override superclass.\")"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def test_internal_set_host_enabled(self):"},{"line_number":905,"context_line":"        self.mox.UnsetStubs()"},{"line_number":906,"context_line":"        service_mock \u003d mock.MagicMock()"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"        # Previous status of the service: disabled: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_2bea75d7","side":"PARENT","line":905,"range":{"start_line":905,"start_character":8,"end_line":905,"end_character":29},"updated":"2018-04-10 22:55:21.000000000","message":"I assume this means get_admin_context is not supposed to be called/validated for this test method.  In which case, you should probably remove your mock from setUp and instead decorate all and only the methods that use it.  Or split those out into a separate test class.","commit_id":"f2c4680f087c8544a24ec9547b2ccb52d6ec1909"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5956515df05385d2be540f25c6f91fefd2eafe19","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                      \" needed to override superclass.\")"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def test_internal_set_host_enabled(self):"},{"line_number":905,"context_line":"        self.mox.UnsetStubs()"},{"line_number":906,"context_line":"        service_mock \u003d mock.MagicMock()"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"        # Previous status of the service: disabled: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_ce63c719","side":"PARENT","line":905,"range":{"start_line":905,"start_character":8,"end_line":905,"end_character":29},"in_reply_to":"bf659307_2bea75d7","updated":"2018-04-11 00:31:13.000000000","message":"Originally \u0027get_admin_context\u0027 is replaced by fixtures.MonkeyPatch. fixtures.MonkeyPatch does not use mox stubs.\nmox.UnsetStubs() unsets mox tubs. It does not effect fixtures.MonkeyPatch. So it is not problem.","commit_id":"f2c4680f087c8544a24ec9547b2ccb52d6ec1909"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"387d11df31d7881cfd4365e434fb6935e77c00dc","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                      \" needed to override superclass.\")"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def test_internal_set_host_enabled(self):"},{"line_number":905,"context_line":"        self.mox.UnsetStubs()"},{"line_number":906,"context_line":"        service_mock \u003d mock.MagicMock()"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"        # Previous status of the service: disabled: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_97e39ed8","side":"PARENT","line":905,"range":{"start_line":905,"start_character":8,"end_line":905,"end_character":29},"in_reply_to":"bf659307_ce63c719","updated":"2018-04-11 02:38:52.000000000","message":"Oh, I see, the mox\u0027d stub was only _set_host_enabled, which you\u0027ve removed entirely - cool.","commit_id":"f2c4680f087c8544a24ec9547b2ccb52d6ec1909"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5af7de48bd316cc1d941053329a7b33275b478ad","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        # Point _VirtDriverTestCase at the right module"},{"line_number":849,"context_line":"        self.driver_module \u003d \u0027nova.virt.libvirt.LibvirtDriver\u0027"},{"line_number":850,"context_line":"        super(LibvirtConnTestCase, self).setUp()"},{"line_number":851,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":852,"context_line":"            \u0027nova.context.get_admin_context\u0027, lambda: self.ctxt))"},{"line_number":853,"context_line":"        # This is needed for the live migration tests which spawn off the"},{"line_number":854,"context_line":"        # operation for monitoring."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_ebd8fd53","line":851,"range":{"start_line":851,"start_character":8,"end_line":851,"end_character":45},"updated":"2018-04-10 22:55:21.000000000","message":"Turns out this is exactly self.stub_out","commit_id":"5dae700309ffeffa387a89be543b3a7085f12aae"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5956515df05385d2be540f25c6f91fefd2eafe19","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        # Point _VirtDriverTestCase at the right module"},{"line_number":849,"context_line":"        self.driver_module \u003d \u0027nova.virt.libvirt.LibvirtDriver\u0027"},{"line_number":850,"context_line":"        super(LibvirtConnTestCase, self).setUp()"},{"line_number":851,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":852,"context_line":"            \u0027nova.context.get_admin_context\u0027, lambda: self.ctxt))"},{"line_number":853,"context_line":"        # This is needed for the live migration tests which spawn off the"},{"line_number":854,"context_line":"        # operation for monitoring."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_aea0d343","line":851,"range":{"start_line":851,"start_character":8,"end_line":851,"end_character":45},"in_reply_to":"bf659307_ebd8fd53","updated":"2018-04-11 00:31:13.000000000","message":"Done","commit_id":"5dae700309ffeffa387a89be543b3a7085f12aae"}]}