)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e4774352e60363f4e0d63205f29e7e5846412f8e","unresolved":false,"context_lines":[{"line_number":16731,"context_line":"        string_ver \u003d libvirt_utils.version_to_string((4, 33, 173))"},{"line_number":16732,"context_line":"        self.assertEqual(\"4.33.173\", string_ver)"},{"line_number":16733,"context_line":""},{"line_number":16734,"context_line":"    def test_virtuozzo_min_version_fail(self):"},{"line_number":16735,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":16736,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":16737,"context_line":"        with mock.patch.object(driver._conn, \u0027getVersion\u0027) as mock_getver:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_28d16955","line":16734,"range":{"start_line":16734,"start_character":8,"end_line":16734,"end_character":39},"updated":"2018-04-17 12:28:26.000000000","message":"MIN_LIBVIRT_VIRTUOZZO_VERSION has been removed.\nThen this test should be just removed.","commit_id":"312e07b4d2015ce3503f0ad48dded3c315018ff9"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"45706f95758f2c70c00ec2f486220e5f57d7a139","unresolved":false,"context_lines":[{"line_number":16731,"context_line":"        string_ver \u003d libvirt_utils.version_to_string((4, 33, 173))"},{"line_number":16732,"context_line":"        self.assertEqual(\"4.33.173\", string_ver)"},{"line_number":16733,"context_line":""},{"line_number":16734,"context_line":"    def test_virtuozzo_min_version_fail(self):"},{"line_number":16735,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":16736,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":16737,"context_line":"        with mock.patch.object(driver._conn, \u0027getVersion\u0027) as mock_getver:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_a8032273","line":16734,"range":{"start_line":16734,"start_character":8,"end_line":16734,"end_character":39},"in_reply_to":"9f6a8fd7_28d16955","updated":"2018-04-18 07:17:44.000000000","message":"Hmm.  Notice that there are *two* version constants:\n\n 1. MIN_LIBVIRT_VIRTUOZZO_VERSION\n 2. MIN_VIRTUOZZO_VERSION\n\nOnly the first one is removed.  So, I thought it\u0027s still fine to keep the MIN_VIRTUOZZO_VERSION.","commit_id":"312e07b4d2015ce3503f0ad48dded3c315018ff9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d766f3728869c93dd197380cd0f67497af71ee93","unresolved":false,"context_lines":[{"line_number":16731,"context_line":"        string_ver \u003d libvirt_utils.version_to_string((4, 33, 173))"},{"line_number":16732,"context_line":"        self.assertEqual(\"4.33.173\", string_ver)"},{"line_number":16733,"context_line":""},{"line_number":16734,"context_line":"    def test_virtuozzo_min_version_fail(self):"},{"line_number":16735,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":16736,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":16737,"context_line":"        with mock.patch.object(driver._conn, \u0027getVersion\u0027) as mock_getver:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_6a32c3a9","line":16734,"range":{"start_line":16734,"start_character":8,"end_line":16734,"end_character":39},"in_reply_to":"9f6a8fd7_a8032273","updated":"2018-04-19 06:40:16.000000000","message":"Fair enough.","commit_id":"312e07b4d2015ce3503f0ad48dded3c315018ff9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e4774352e60363f4e0d63205f29e7e5846412f8e","unresolved":false,"context_lines":[{"line_number":16745,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getVersion\u0027,"},{"line_number":16746,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":16747,"context_line":"                           libvirt_driver.MIN_VIRTUOZZO_VERSION))"},{"line_number":16748,"context_line":"    def test_virtuozzo_min_version_ok(self, mock_get_virtuozzo_version):"},{"line_number":16749,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":16750,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":16751,"context_line":"        driver.init_host(\u0027wibble\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_88bf55fa","line":16748,"range":{"start_line":16748,"start_character":8,"end_line":16748,"end_character":37},"updated":"2018-04-17 12:28:26.000000000","message":"ditto","commit_id":"312e07b4d2015ce3503f0ad48dded3c315018ff9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d766f3728869c93dd197380cd0f67497af71ee93","unresolved":false,"context_lines":[{"line_number":16762,"context_line":"    def test_virtuozzo_min_version_fail(self):"},{"line_number":16763,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":16764,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":16765,"context_line":"        with mock.patch.object(driver._conn, \u0027getVersion\u0027) as mock_getver:"},{"line_number":16766,"context_line":"            mock_getver.return_value \u003d \\"},{"line_number":16767,"context_line":"                versionutils.convert_version_to_int("},{"line_number":16768,"context_line":"                libvirt_driver.MIN_VIRTUOZZO_VERSION) - 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_0a10e700","line":16765,"range":{"start_line":16765,"start_character":7,"end_line":16765,"end_character":74},"updated":"2018-04-19 06:40:16.000000000","message":"It is not consistency with line 16773-16775.\nThe decorator can be used.","commit_id":"d34fa327ae217cbbe420f29915f4422f1acb6a90"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"7397d2fa66266cb86850ba1f3ffc01279914d552","unresolved":false,"context_lines":[{"line_number":16762,"context_line":"    def test_virtuozzo_min_version_fail(self):"},{"line_number":16763,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":16764,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":16765,"context_line":"        with mock.patch.object(driver._conn, \u0027getVersion\u0027) as mock_getver:"},{"line_number":16766,"context_line":"            mock_getver.return_value \u003d \\"},{"line_number":16767,"context_line":"                versionutils.convert_version_to_int("},{"line_number":16768,"context_line":"                libvirt_driver.MIN_VIRTUOZZO_VERSION) - 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_b0692a8c","line":16765,"range":{"start_line":16765,"start_character":7,"end_line":16765,"end_character":74},"in_reply_to":"9f6a8fd7_0a10e700","updated":"2018-04-19 08:00:39.000000000","message":"Hmm, I was just fixing the existing code pattern.  But that\u0027s a nice-to-have.","commit_id":"d34fa327ae217cbbe420f29915f4422f1acb6a90"}]}