)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"83199fb666b7ac521b7b494cd107d8d0e79a3b1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tetsuro Nakamura \u003cnakamura.tetsuro@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-27 15:51:22 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for alloc_cands with member_of"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_eeffbe64","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":8},"updated":"2018-05-02 15:20:10.000000000","message":"s/unit/functional/g  :)","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"11ac70235032d566e9ae8ef2c821de136d548a3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tetsuro Nakamura \u003cnakamura.tetsuro@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-27 15:51:22 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for alloc_cands with member_of"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_beaab816","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":8},"in_reply_to":"9f6a8fd7_eeffbe64","updated":"2018-05-03 09:48:32.000000000","message":"Done","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"60487d77020516c0f467ea2557b8d5448fbd1dd5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add unit tests for alloc_cands with member_of"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"},{"line_number":11,"context_line":"the specified aggregateion are picked, but the non shared provider"},{"line_number":12,"context_line":"brings shared providers from out of the specified aggregation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_f3aa4783","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":49},"updated":"2018-05-02 14:55:21.000000000","message":"s/shared/sharing/g","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"11ac70235032d566e9ae8ef2c821de136d548a3e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add unit tests for alloc_cands with member_of"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"},{"line_number":11,"context_line":"the specified aggregateion are picked, but the non shared provider"},{"line_number":12,"context_line":"brings shared providers from out of the specified aggregation."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_dea7744f","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":49},"in_reply_to":"9f6a8fd7_f3aa4783","updated":"2018-05-03 09:48:32.000000000","message":"Done","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"60487d77020516c0f467ea2557b8d5448fbd1dd5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"},{"line_number":11,"context_line":"the specified aggregateion are picked, but the non shared provider"},{"line_number":12,"context_line":"brings shared providers from out of the specified aggregation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie098bb6fa21b3656a8ea840f4e6d9407311bddcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_33a19faa","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":26},"updated":"2018-05-02 14:55:21.000000000","message":"aggregates","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"11ac70235032d566e9ae8ef2c821de136d548a3e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"},{"line_number":11,"context_line":"the specified aggregateion are picked, but the non shared provider"},{"line_number":12,"context_line":"brings shared providers from out of the specified aggregation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie098bb6fa21b3656a8ea840f4e6d9407311bddcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_7e62e018","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":26},"in_reply_to":"9f6a8fd7_33a19faa","updated":"2018-05-03 09:48:32.000000000","message":"Done","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"60487d77020516c0f467ea2557b8d5448fbd1dd5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"},{"line_number":11,"context_line":"the specified aggregateion are picked, but the non shared provider"},{"line_number":12,"context_line":"brings shared providers from out of the specified aggregation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie098bb6fa21b3656a8ea840f4e6d9407311bddcd"},{"line_number":15,"context_line":"Related-Bug: #1763907"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_d38f032c","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":61},"updated":"2018-05-02 14:55:21.000000000","message":"aggregates","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"11ac70235032d566e9ae8ef2c821de136d548a3e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch add a unit test which describes a bug that when the"},{"line_number":10,"context_line":"`member_of` parameter is present, only non shared providers in"},{"line_number":11,"context_line":"the specified aggregateion are picked, but the non shared provider"},{"line_number":12,"context_line":"brings shared providers from out of the specified aggregation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie098bb6fa21b3656a8ea840f4e6d9407311bddcd"},{"line_number":15,"context_line":"Related-Bug: #1763907"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_9e67bc26","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":61},"in_reply_to":"9f6a8fd7_d38f032c","updated":"2018-05-03 09:48:32.000000000","message":"Done","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"}],"nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"60487d77020516c0f467ea2557b8d5448fbd1dd5","unresolved":false,"context_lines":[{"line_number":1633,"context_line":"        # Covering the following setup:"},{"line_number":1634,"context_line":"        #"},{"line_number":1635,"context_line":"        #       CN1 (VCPU)            CN2 (VCPU)"},{"line_number":1636,"context_line":"        #      / agg3     \\ agg1     / agg1     \\ agg2"},{"line_number":1637,"context_line":"        #  SS3 (DISK_GB)   SS1 (DISK_GB)     SS2 (DISK_GB)"},{"line_number":1638,"context_line":"        cn1 \u003d self._create_provider(\u0027cn1\u0027, uuids.agg1, uuids.agg3)"},{"line_number":1639,"context_line":"        _add_inventory(cn1, fields.ResourceClass.VCPU, 24)"},{"line_number":1640,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_f3e6c7e8","line":1637,"range":{"start_line":1636,"start_character":1,"end_line":1637,"end_character":58},"updated":"2018-05-02 14:55:21.000000000","message":"small suggestion... it might be easier to list the aggregates in left-to-right order. So, agg2/ss2 would be the aggregate sharing with both CN1 and CN2","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"11ac70235032d566e9ae8ef2c821de136d548a3e","unresolved":false,"context_lines":[{"line_number":1633,"context_line":"        # Covering the following setup:"},{"line_number":1634,"context_line":"        #"},{"line_number":1635,"context_line":"        #       CN1 (VCPU)            CN2 (VCPU)"},{"line_number":1636,"context_line":"        #      / agg3     \\ agg1     / agg1     \\ agg2"},{"line_number":1637,"context_line":"        #  SS3 (DISK_GB)   SS1 (DISK_GB)     SS2 (DISK_GB)"},{"line_number":1638,"context_line":"        cn1 \u003d self._create_provider(\u0027cn1\u0027, uuids.agg1, uuids.agg3)"},{"line_number":1639,"context_line":"        _add_inventory(cn1, fields.ResourceClass.VCPU, 24)"},{"line_number":1640,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_be7f18aa","line":1637,"range":{"start_line":1636,"start_character":1,"end_line":1637,"end_character":58},"in_reply_to":"9f6a8fd7_f3e6c7e8","updated":"2018-05-03 09:48:32.000000000","message":"Good idea! Let\u0027s do that.","commit_id":"0b3e2f9bdf3d4eaae3a55307a57f911391ff62da"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e35830aa6c1d5bcc37278784cb052c4fd113f100","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        #      / agg1     \\ agg2     / agg2     \\ agg3"},{"line_number":1569,"context_line":"        #  SS1 (DISK_GB)   SS2 (DISK_GB)     SS3 (DISK_GB)"},{"line_number":1570,"context_line":"        cn1 \u003d self._create_provider(\u0027cn1\u0027, uuids.agg1, uuids.agg2)"},{"line_number":1571,"context_line":"        _add_inventory(cn1, fields.ResourceClass.VCPU, 24)"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        cn2 \u003d self._create_provider(\u0027cn2\u0027, uuids.agg2, uuids.agg3)"},{"line_number":1574,"context_line":"        _add_inventory(cn2, fields.ResourceClass.VCPU, 24)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_53f8b747","line":1571,"range":{"start_line":1571,"start_character":8,"end_line":1571,"end_character":22},"updated":"2018-05-10 17:39:01.000000000","message":"This is now test_base.add_inventory","commit_id":"4dd11dd0807a0241ec106b7797c199227bb31f33"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e35830aa6c1d5bcc37278784cb052c4fd113f100","unresolved":false,"context_lines":[{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"        # ss1 is connected to cn1"},{"line_number":1577,"context_line":"        ss1 \u003d self._create_provider(\u0027ss1\u0027, uuids.agg1)"},{"line_number":1578,"context_line":"        _set_traits(ss1, \"MISC_SHARES_VIA_AGGREGATE\")"},{"line_number":1579,"context_line":"        _add_inventory(ss1, fields.ResourceClass.DISK_GB, 1600)"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        # ss2 is connected to both cn1 and cn2"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_f396a3f0","line":1578,"range":{"start_line":1578,"start_character":8,"end_line":1578,"end_character":19},"updated":"2018-05-10 17:39:01.000000000","message":"etc.","commit_id":"4dd11dd0807a0241ec106b7797c199227bb31f33"}]}