)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"344023800cce3636a0d93d0459fbbd97fd1c73f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add (Same|Different)HostFilter to defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SameHostFilter and DifferentHostFilter filter hosts according to"},{"line_number":10,"context_line":"scheduler hints. The two filters are needed by many downstream CI"},{"line_number":11,"context_line":"jobs. Instead of every job overriding the enabled filters list, this"},{"line_number":12,"context_line":"patch adds the two filters to the defaults. What\u0027s best for CI isn\u0027t"},{"line_number":13,"context_line":"necessarily what\u0027s best for users - by that logic nova would enable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_f6bb62e2","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":16},"updated":"2018-04-16 22:18:31.000000000","message":"There are other scheduler hints which are tied to filters which aren\u0027t enabled by default, like SimpleCIDRAffinityFilter, so using this as justification is a slippery slope.\n\nAnd yes, supported scheduler hints in a cloud is not at all discoverable by the end user.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"344023800cce3636a0d93d0459fbbd97fd1c73f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add (Same|Different)HostFilter to defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SameHostFilter and DifferentHostFilter filter hosts according to"},{"line_number":10,"context_line":"scheduler hints. The two filters are needed by many downstream CI"},{"line_number":11,"context_line":"jobs. Instead of every job overriding the enabled filters list, this"},{"line_number":12,"context_line":"patch adds the two filters to the defaults. What\u0027s best for CI isn\u0027t"},{"line_number":13,"context_line":"necessarily what\u0027s best for users - by that logic nova would enable"},{"line_number":14,"context_line":"all of the filters by default like devstack does. However, we need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_d6e17e00","line":11,"range":{"start_line":10,"start_character":17,"end_line":11,"end_character":5},"updated":"2018-04-16 22:18:31.000000000","message":"This adds 0 justification for why we should do this.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"327afb27e01752a6a2792dc7d1d492fb4f811d95","unresolved":false,"context_lines":[{"line_number":10,"context_line":"scheduler hints. The two filters are needed by many downstream CI"},{"line_number":11,"context_line":"jobs. Instead of every job overriding the enabled filters list, this"},{"line_number":12,"context_line":"patch adds the two filters to the defaults. What\u0027s best for CI isn\u0027t"},{"line_number":13,"context_line":"necessarily what\u0027s best for users - by that logic nova would enable"},{"line_number":14,"context_line":"all of the filters by default like devstack does. However, we need"},{"line_number":15,"context_line":"some filters to be the defaults, so the line has to be drawn"},{"line_number":16,"context_line":"somehwere. Since (Same|Different)HostFilter are harmless, this patch"},{"line_number":17,"context_line":"proposes to put them on the other side of that line."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_d65e5ee5","line":14,"range":{"start_line":13,"start_character":36,"end_line":14,"end_character":49},"updated":"2018-04-16 22:14:04.000000000","message":"devstack doesn\u0027t enable all of the filters, it adds samehost and differenthost to the enabled_filters list but that\u0027s just because tempest has some tests based on those filters, which arguably shouldn\u0027t even live in tempest anymore.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"344023800cce3636a0d93d0459fbbd97fd1c73f2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"necessarily what\u0027s best for users - by that logic nova would enable"},{"line_number":14,"context_line":"all of the filters by default like devstack does. However, we need"},{"line_number":15,"context_line":"some filters to be the defaults, so the line has to be drawn"},{"line_number":16,"context_line":"somehwere. Since (Same|Different)HostFilter are harmless, this patch"},{"line_number":17,"context_line":"proposes to put them on the other side of that line."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also turns out we were incorrectly using the SameHostFilter with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_d6badedc","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":56},"updated":"2018-04-16 22:18:31.000000000","message":"It\u0027s arguably not harmless, since it adds a non-zero amount of processing time to a scheduling request.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"327afb27e01752a6a2792dc7d1d492fb4f811d95","unresolved":false,"context_lines":[{"line_number":13,"context_line":"necessarily what\u0027s best for users - by that logic nova would enable"},{"line_number":14,"context_line":"all of the filters by default like devstack does. However, we need"},{"line_number":15,"context_line":"some filters to be the defaults, so the line has to be drawn"},{"line_number":16,"context_line":"somehwere. Since (Same|Different)HostFilter are harmless, this patch"},{"line_number":17,"context_line":"proposes to put them on the other side of that line."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also turns out we were incorrectly using the SameHostFilter with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_7673d281","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":9},"updated":"2018-04-16 22:14:04.000000000","message":"somewhere","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b4b4c64fd06d2ac5ea8f57731d86273f986d1670","unresolved":false,"context_lines":[{"line_number":13,"context_line":"necessarily what\u0027s best for users - by that logic nova would enable"},{"line_number":14,"context_line":"all of the filters by default like devstack does. However, we need"},{"line_number":15,"context_line":"some filters to be the defaults, so the line has to be drawn"},{"line_number":16,"context_line":"somehwere. Since (Same|Different)HostFilter are harmless, this patch"},{"line_number":17,"context_line":"proposes to put them on the other side of that line."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also turns out we were incorrectly using the SameHostFilter with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_f2a5a5b6","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":56},"in_reply_to":"9f6a8fd7_d6badedc","updated":"2018-04-17 08:21:44.000000000","message":"Doesn\u0027t it only add processing *when* the scheduler_hints are invoked and otherwise they do nothing?\nhttps://github.com/openstack/nova/blob/fa2c1567c1a61c7cd606583100fd14af70095546/nova/scheduler/filters/affinity_filter.py#L54\n\n\n\nAt least that\u0027s my understanding o the code.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"327afb27e01752a6a2792dc7d1d492fb4f811d95","unresolved":false,"context_lines":[{"line_number":17,"context_line":"proposes to put them on the other side of that line."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also turns out we were incorrectly using the SameHostFilter with"},{"line_number":20,"context_line":"regular expressions instead of a UUID in the same_host scheduler hint."},{"line_number":21,"context_line":"This is removed in this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I0f4c8d0a0ae539e7d440695ed242a73c469696f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_b60e4ae3","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":70},"updated":"2018-04-16 22:14:04.000000000","message":"For a specific API samples functional test, right? You should probably clarify here, and I\u0027d pull that out into a separate change.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"}],"nova/conf/scheduler.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"327afb27e01752a6a2792dc7d1d492fb4f811d95","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"* enabled_filters"},{"line_number":302,"context_line":"\"\"\"),"},{"line_number":303,"context_line":"    cfg.ListOpt(\"enabled_filters\","},{"line_number":304,"context_line":"        default\u003d["},{"line_number":305,"context_line":"          \"RetryFilter\","},{"line_number":306,"context_line":"          \"AvailabilityZoneFilter\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_96f546ce","line":303,"updated":"2018-04-16 22:14:04.000000000","message":"This is a release note at a minimum for the default change.","commit_id":"35945c4e0eafdc6d910a29dfd2b156eef29eefa8"}]}