)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0e90d922466dff245045fa1d08f569ad0f288ed8","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"        uuids \u003d [instance.uuid for instance in instances]"},{"line_number":1632,"context_line":"        self.scheduler_client.sync_instance_info(context, self.host, uuids)"},{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"    def _notify_about_instance_usage(self, context, instance, event_suffix,"},{"line_number":1635,"context_line":"                                     network_info\u003dNone, extra_usage_info\u003dNone,"},{"line_number":1636,"context_line":"                                     fault\u003dNone):"},{"line_number":1637,"context_line":"        compute_utils.notify_about_instance_usage("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_29780bc2","line":1634,"range":{"start_line":1634,"start_character":8,"end_line":1634,"end_character":36},"updated":"2018-04-23 14:57:03.000000000","message":"I checked all calls of this to make sure we weren\u0027t falling into the not-naming-named-args trap.  We aren\u0027t.","commit_id":"3205caf0be5e9b5998bdf83ee12f7e9cc74b1398"}],"nova/compute/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0e90d922466dff245045fa1d08f569ad0f288ed8","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    :param ignore_missing_network_data: if True, log any exceptions generated"},{"line_number":277,"context_line":"        while getting network info; if False, raise the exception."},{"line_number":278,"context_line":"    :param system_metadata: system_metadata override for the instance. If"},{"line_number":279,"context_line":"        None, the instance_ref.system_metadata will be used."},{"line_number":280,"context_line":"    :param extra_usage_info: Dictionary containing extra values to add or"},{"line_number":281,"context_line":"        override in the notification if not None."},{"line_number":282,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_6911235d","line":279,"range":{"start_line":279,"start_character":18,"end_line":279,"end_character":30},"updated":"2018-04-23 14:57:03.000000000","message":"Well gosh, since you\u0027re cleaning up the docstring, adding a :param entry for this guy would be nice.\n\nUnless it\u0027s obvious.  Which maybe it is.  Except the \u0027ref\u0027 part, which makes me wonder if it\u0027s still actually an Instance object.","commit_id":"3205caf0be5e9b5998bdf83ee12f7e9cc74b1398"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf4bae7a830e741846c136b7516edd04eea5a42f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    :param ignore_missing_network_data: if True, log any exceptions generated"},{"line_number":277,"context_line":"        while getting network info; if False, raise the exception."},{"line_number":278,"context_line":"    :param system_metadata: system_metadata override for the instance. If"},{"line_number":279,"context_line":"        None, the instance_ref.system_metadata will be used."},{"line_number":280,"context_line":"    :param extra_usage_info: Dictionary containing extra values to add or"},{"line_number":281,"context_line":"        override in the notification if not None."},{"line_number":282,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_af85fb5b","line":279,"range":{"start_line":279,"start_character":18,"end_line":279,"end_character":30},"in_reply_to":"9f6a8fd7_6911235d","updated":"2018-04-23 15:05:24.000000000","message":"\u003e Well gosh, since you\u0027re cleaning up the docstring, adding a :param entry for this guy would be nice.\n\nDone\n\n\u003e Except the \u0027ref\u0027 part, which makes me wonder if it\u0027s still actually an Instance object.\n\nYes it\u0027s an Instance object, the instance_ref name usage is from a bygone time where this was a dict (or model object from the DB API).","commit_id":"3205caf0be5e9b5998bdf83ee12f7e9cc74b1398"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0e90d922466dff245045fa1d08f569ad0f288ed8","unresolved":false,"context_lines":[{"line_number":1547,"context_line":"            compute_utils.notify_about_instance_usage("},{"line_number":1548,"context_line":"                        self.compute_api.notifier, self.context,"},{"line_number":1549,"context_line":"                        inst, \u0027delete.end\u0027,"},{"line_number":1550,"context_line":"                        system_metadata\u003dinst.system_metadata)"},{"line_number":1551,"context_line":"            inst.info_cache \u003d None"},{"line_number":1552,"context_line":"            self.compute_api._local_delete(self.context, inst, [],"},{"line_number":1553,"context_line":"                                           \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_e4bc7a07","line":1550,"range":{"start_line":1550,"start_character":24,"end_line":1550,"end_character":60},"updated":"2018-04-23 14:57:03.000000000","message":"x\n\nThis is passing because we\u0027re calling into a mock, which is gonna do basically nothing.  Is this test bogus?","commit_id":"3205caf0be5e9b5998bdf83ee12f7e9cc74b1398"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0bacbb9f12a19ceb3ff4484adff2a2e2ccf488ce","unresolved":false,"context_lines":[{"line_number":1547,"context_line":"            compute_utils.notify_about_instance_usage("},{"line_number":1548,"context_line":"                        self.compute_api.notifier, self.context,"},{"line_number":1549,"context_line":"                        inst, \u0027delete.end\u0027,"},{"line_number":1550,"context_line":"                        system_metadata\u003dinst.system_metadata)"},{"line_number":1551,"context_line":"            inst.info_cache \u003d None"},{"line_number":1552,"context_line":"            self.compute_api._local_delete(self.context, inst, [],"},{"line_number":1553,"context_line":"                                           \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_0f4f4734","line":1550,"range":{"start_line":1550,"start_character":24,"end_line":1550,"end_character":60},"in_reply_to":"9f6a8fd7_cf7cef84","updated":"2018-04-23 15:10:50.000000000","message":"Wow yeah this test was copied from the other local_delete mox-based tests in here, like self.context.elevated().MultipleTimes().AndReturn(self.context) doesn\u0027t even make sense.","commit_id":"3205caf0be5e9b5998bdf83ee12f7e9cc74b1398"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf4bae7a830e741846c136b7516edd04eea5a42f","unresolved":false,"context_lines":[{"line_number":1547,"context_line":"            compute_utils.notify_about_instance_usage("},{"line_number":1548,"context_line":"                        self.compute_api.notifier, self.context,"},{"line_number":1549,"context_line":"                        inst, \u0027delete.end\u0027,"},{"line_number":1550,"context_line":"                        system_metadata\u003dinst.system_metadata)"},{"line_number":1551,"context_line":"            inst.info_cache \u003d None"},{"line_number":1552,"context_line":"            self.compute_api._local_delete(self.context, inst, [],"},{"line_number":1553,"context_line":"                                           \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_cf7cef84","line":1550,"range":{"start_line":1550,"start_character":24,"end_line":1550,"end_character":60},"in_reply_to":"9f6a8fd7_e4bc7a07","updated":"2018-04-23 15:05:24.000000000","message":"Good catch. I don\u0027t know why the test is calling the mock, but it\u0027s always been that way:\n\nIe0bba032615d3da06cdd95b221beb37a9b8a377d\n\nI figured maybe this was a mistake switching a test from mox to mock, but it\u0027s not. I\u0027ll just remove the calls to the mock here and above.","commit_id":"3205caf0be5e9b5998bdf83ee12f7e9cc74b1398"}]}