)]}'
{"doc/api_samples/os-instance-actions/v2.58/instance-actions-list-with-marker-resp.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6273812e6bb500faab794a937d06b463bfcb1b6a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"request_id\": \"req-922232c3-faf8-4628-9c40-0e8f0cdab020\","},{"line_number":9,"context_line":"            \"start_time\": \"2018-04-25T01:26:33.694447\","},{"line_number":10,"context_line":"            \"updated_at\": \"2018-04-25T01:26:35.944525\","},{"line_number":11,"context_line":"            \"user_id\": \"fake\""},{"line_number":12,"context_line":"        }"},{"line_number":13,"context_line":"    ]"},{"line_number":14,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"9f6a8fd7_faccca89","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":29},"updated":"2018-04-26 06:56:25.000000000","message":"yea, this is not guranted to be always \u0027admin\u0027 as same tests is run for non admin and that share the same sample files of folder 2.58. it depends on which tests run first and it will be \u0027admin\u0027 or \u0027fake\u0027.\n\nthat said, it should not really matter so lgtm.\n\n- ServerActionsV258NonAdminSampleJsonTest","commit_id":"577cb4b2f4a2c5c7b825e28cdb4057740c09f0fa"}],"nova/tests/functional/api_sample_tests/api_samples/os-instance-actions/instance-action-get-resp.json.tpl":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f8e3bf10fae6f58fcb3f80be826a32fd58fa068d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                \"start_time\": \"%(strtime)s\","},{"line_number":14,"context_line":"                \"finish_time\": \"%(strtime)s\","},{"line_number":15,"context_line":"                \"result\": \"Success\","},{"line_number":16,"context_line":"                \"traceback\": \"\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ]"},{"line_number":19,"context_line":"    }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_127c42ea","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":31},"updated":"2018-04-24 00:33:55.000000000","message":"I admit I can\u0027t tell how this \"\" from the template ends up as \"traceback\": null in the responses.","commit_id":"d214a6d102fc9b38edaaa3c5cad9d082cf71a3bd"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"c8102850abc09d043ad16584a4eb977c57f8db8a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                \"start_time\": \"%(strtime)s\","},{"line_number":14,"context_line":"                \"finish_time\": \"%(strtime)s\","},{"line_number":15,"context_line":"                \"result\": \"Success\","},{"line_number":16,"context_line":"                \"traceback\": \"\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ]"},{"line_number":19,"context_line":"    }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_95a59ca4","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":31},"in_reply_to":"9f6a8fd7_127c42ea","updated":"2018-04-24 01:55:06.000000000","message":"Thanks, good catch, you remind me, and it\u0027s due to\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/api_samples_test_base.py#L43-L44\n\nDetail info:\nour expected string is \"\", and result string is null:\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/api_samples_test_base.py#L277\n\nI think I should change all \"\" to null in template, but I also find these nits in previous template, So, I can fix all these nits in follow patch.","commit_id":"d214a6d102fc9b38edaaa3c5cad9d082cf71a3bd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3d644c9e9c7bb7ea963d74a525e0e0b663ea491c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                \"start_time\": \"%(strtime)s\","},{"line_number":14,"context_line":"                \"finish_time\": \"%(strtime)s\","},{"line_number":15,"context_line":"                \"result\": \"Success\","},{"line_number":16,"context_line":"                \"traceback\": \"\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ]"},{"line_number":19,"context_line":"    }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_ba78a98f","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":31},"in_reply_to":"9f6a8fd7_395350e4","updated":"2018-04-25 09:49:35.000000000","message":"Yea we should generate the new doc sample when we change the template. \n\nFor melanie query - empty string \u0027\u0027 is being converted to null in template from the code Kero mentioned.\n\n\u0027user_id\u0027 is admin because of [1]. this is user id used in request context. this test is admin test so \u0027admin\u0027 as user_id.\n\n..1 https://github.com/openstack/nova/blob/0a642e2eee8d430ddcccf2947aedcca1a0a0b005/nova/tests/fixtures.py#L858","commit_id":"d214a6d102fc9b38edaaa3c5cad9d082cf71a3bd"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"63ae8cbaa4f5ffa0e2e664580c15fa61f6b294b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                \"start_time\": \"%(strtime)s\","},{"line_number":14,"context_line":"                \"finish_time\": \"%(strtime)s\","},{"line_number":15,"context_line":"                \"result\": \"Success\","},{"line_number":16,"context_line":"                \"traceback\": \"\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ]"},{"line_number":19,"context_line":"    }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_395350e4","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":31},"in_reply_to":"9f6a8fd7_6a7a50ba","updated":"2018-04-25 01:48:24.000000000","message":"Oh, The answer is YES.\n\nI even didn\u0027t know we can generate json from tpl + response, I generated these json manually, LOL.\n\nGood to know that, and I put the fresh regenerating result in https://review.openstack.org/#/c/563802/3\n\n@melanie, thanks for your patient explaination.","commit_id":"d214a6d102fc9b38edaaa3c5cad9d082cf71a3bd"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"878f8b05687cc752985c81474aa06a48aacc73c5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                \"start_time\": \"%(strtime)s\","},{"line_number":14,"context_line":"                \"finish_time\": \"%(strtime)s\","},{"line_number":15,"context_line":"                \"result\": \"Success\","},{"line_number":16,"context_line":"                \"traceback\": \"\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ]"},{"line_number":19,"context_line":"    }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_b57460d0","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":31},"in_reply_to":"9f6a8fd7_95a59ca4","updated":"2018-04-24 02:23:58.000000000","message":"@melanie\nhere: https://review.openstack.org/#/c/563802/","commit_id":"d214a6d102fc9b38edaaa3c5cad9d082cf71a3bd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4007d0ca869861a5db78ed3919010a80c073fa73","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                \"start_time\": \"%(strtime)s\","},{"line_number":14,"context_line":"                \"finish_time\": \"%(strtime)s\","},{"line_number":15,"context_line":"                \"result\": \"Success\","},{"line_number":16,"context_line":"                \"traceback\": \"\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ]"},{"line_number":19,"context_line":"    }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_6a7a50ba","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":31},"in_reply_to":"9f6a8fd7_b57460d0","updated":"2018-04-24 20:51:51.000000000","message":"What I meant was, if I remember correctly, the doc/api_samples/*.json files are generated by the api-samples tox target based on the .tpl template files. So I just didn\u0027t understand how specifying \"\" here would be generated as null during the generation of the doc/api_samples/*.json files.\n\nThat said, when I delete (for example) doc/api_samples/os-instance-actions/instance-action-get-resp.json and run \u0027tox -eapi-samples\u0027 to generate it again, I do get \"message\": null and \"traceback\": null with the nova/tests/functional/api_sample_tests/api_samples/os-instance-actions/instance-action-get-resp.json.tpl file in this patch. I also get \"user_id\": \"admin\".\n\nYou must not be re-generating the doc/api_samples/*.json files after you change the .tpl files?","commit_id":"d214a6d102fc9b38edaaa3c5cad9d082cf71a3bd"}]}