)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b77d1a2ac795cdd5e9ba1345a8f2884a99e4d054","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The CONF.cpu_shared_set option will be used for best-effort guest vCPU"},{"line_number":10,"context_line":"resources."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s to note that an other effort done by spec cpu-resources will use"},{"line_number":13,"context_line":"that same option to provide isolation between dedicated and shared"},{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f6a8fd7_f266e129","line":12,"range":{"start_line":12,"start_character":18,"end_line":12,"end_character":27},"updated":"2018-04-18 11:35:47.000000000","message":"another","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b77d1a2ac795cdd5e9ba1345a8f2884a99e4d054","unresolved":false,"context_lines":[{"line_number":10,"context_line":"resources."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s to note that an other effort done by spec cpu-resources will use"},{"line_number":13,"context_line":"that same option to provide isolation between dedicated and shared"},{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibedd31e284ec9bc70e257e6a88b4d82b021db0fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f6a8fd7_926d2506","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":4},"updated":"2018-04-18 11:35:47.000000000","message":"this","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b77d1a2ac795cdd5e9ba1345a8f2884a99e4d054","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s to note that an other effort done by spec cpu-resources will use"},{"line_number":13,"context_line":"that same option to provide isolation between dedicated and shared"},{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibedd31e284ec9bc70e257e6a88b4d82b021db0fd"},{"line_number":17,"context_line":"Partial-implement: bp/overhead-pin-set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f6a8fd7_32a77952","line":14,"range":{"start_line":14,"start_character":49,"end_line":14,"end_character":66},"updated":"2018-04-18 11:35:47.000000000","message":"s/that whole series/this series/","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"69578fe80876359a848d8737bfa331fcbe0aae15","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s to note that an other effort done by spec cpu-resources will use"},{"line_number":13,"context_line":"that same option to provide isolation between dedicated and shared"},{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibedd31e284ec9bc70e257e6a88b4d82b021db0fd"},{"line_number":17,"context_line":"Partial-implement: bp/overhead-pin-set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f6a8fd7_1e74ad98","line":14,"range":{"start_line":14,"start_character":60,"end_line":14,"end_character":65},"updated":"2018-04-19 02:05:15.000000000","message":"series?","commit_id":"d395e0f63526d4ec0108f8294b8834ff5d164841"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"03d16a2962f7912b0953d66732903d653ce57b4f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibedd31e284ec9bc70e257e6a88b4d82b021db0fd"},{"line_number":17,"context_line":"Partial-implement: bp/overhead-pin-set"},{"line_number":18,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f6a8fd7_3b32e311","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":38},"updated":"2018-04-19 01:41:37.000000000","message":"nit: blueprint link is not generated. It should be:\n\nPartially Implements: blueprint overhead-pin-set","commit_id":"d395e0f63526d4ec0108f8294b8834ff5d164841"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4c7485df37d4494f19c726654eb075775c17174e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The CONF.compute.cpu_shared_set option will be used for best-effort"},{"line_number":10,"context_line":"guest vCPU resources."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s to note that an other effort done by spec cpu-resources will use"},{"line_number":13,"context_line":"that same option to provide isolation between dedicated and shared"},{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5f7c97a3_7dd10223","line":12,"range":{"start_line":12,"start_character":18,"end_line":12,"end_character":26},"updated":"2018-05-10 16:02:11.000000000","message":"another","commit_id":"30cda5113c3157620969d379b6f7f779318bd658"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4c7485df37d4494f19c726654eb075775c17174e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s to note that an other effort done by spec cpu-resources will use"},{"line_number":13,"context_line":"that same option to provide isolation between dedicated and shared"},{"line_number":14,"context_line":"instances. But currently outside of the scope of that whole serie."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibedd31e284ec9bc70e257e6a88b4d82b021db0fd"},{"line_number":17,"context_line":"Partial-implement: bp/overhead-pin-set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5f7c97a3_ddb856e6","line":14,"range":{"start_line":14,"start_character":60,"end_line":14,"end_character":65},"updated":"2018-05-10 16:02:11.000000000","message":"series :)","commit_id":"30cda5113c3157620969d379b6f7f779318bd658"}],"nova/conf/compute.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"660baacfdf3bb4928262831005f30d3cf1e010ee","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    vcpu_pin_set \u003d \"4-12,^8,15\""},{"line_number":338,"context_line":"\"\"\"),"},{"line_number":339,"context_line":"    cfg.StrOpt(\u0027cpu_share_set\u0027,"},{"line_number":340,"context_line":"        help\u003d\"\"\""},{"line_number":341,"context_line":"Defines which physical CPUs (pCPUs) can be considered to be used for best"},{"line_number":342,"context_line":"efforts workload."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_6759c758","line":339,"range":{"start_line":339,"start_character":16,"end_line":339,"end_character":29},"updated":"2018-04-17 18:35:11.000000000","message":"Can we make this cpu_shared_set (and soon, cpu_dedicated_set) please?","commit_id":"576411c9875084926f678a87c8fefb5f010449ab"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"32655e307749290a24da6dd65a2a830b4196721e","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    vcpu_pin_set \u003d \"4-12,^8,15\""},{"line_number":338,"context_line":"\"\"\"),"},{"line_number":339,"context_line":"    cfg.StrOpt(\u0027cpu_share_set\u0027,"},{"line_number":340,"context_line":"        help\u003d\"\"\""},{"line_number":341,"context_line":"Defines which physical CPUs (pCPUs) can be considered to be used for best"},{"line_number":342,"context_line":"efforts workload."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_a83ec2d7","line":339,"range":{"start_line":339,"start_character":16,"end_line":339,"end_character":29},"in_reply_to":"9f6a8fd7_6759c758","updated":"2018-04-18 08:16:31.000000000","message":"Done I should have double checked that.","commit_id":"576411c9875084926f678a87c8fefb5f010449ab"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"660baacfdf3bb4928262831005f30d3cf1e010ee","unresolved":false,"context_lines":[{"line_number":338,"context_line":"\"\"\"),"},{"line_number":339,"context_line":"    cfg.StrOpt(\u0027cpu_share_set\u0027,"},{"line_number":340,"context_line":"        help\u003d\"\"\""},{"line_number":341,"context_line":"Defines which physical CPUs (pCPUs) can be considered to be used for best"},{"line_number":342,"context_line":"efforts workload."},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Currently only used by libvirt driver to isolate guests emulator threads on"},{"line_number":345,"context_line":"when hw:emulator_threads_policy:share."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_c721b3b6","line":342,"range":{"start_line":341,"start_character":36,"end_line":342,"end_character":17},"updated":"2018-04-17 18:35:11.000000000","message":"\"will be used for best-effort guest vCPU resources\"","commit_id":"576411c9875084926f678a87c8fefb5f010449ab"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"660baacfdf3bb4928262831005f30d3cf1e010ee","unresolved":false,"context_lines":[{"line_number":341,"context_line":"Defines which physical CPUs (pCPUs) can be considered to be used for best"},{"line_number":342,"context_line":"efforts workload."},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Currently only used by libvirt driver to isolate guests emulator threads on"},{"line_number":345,"context_line":"when hw:emulator_threads_policy:share."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    cpu_share_set \u003d \"4-12,^8,15\""},{"line_number":348,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_0719eb83","line":345,"range":{"start_line":344,"start_character":41,"end_line":345,"end_character":4},"updated":"2018-04-17 18:35:11.000000000","message":"\"place guest emulator threads when\"","commit_id":"576411c9875084926f678a87c8fefb5f010449ab"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"93825b2ea0efbd0f8da94df9ecdba107f7c110cf","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    vcpu_pin_set \u003d \"4-12,^8,15\""},{"line_number":338,"context_line":"\"\"\"),"},{"line_number":339,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":340,"context_line":"        help\u003d\"\"\""},{"line_number":341,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":342,"context_line":"resources."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5e6f9c91","line":339,"range":{"start_line":339,"start_character":15,"end_line":339,"end_character":31},"updated":"2018-04-18 09:05:36.000000000","message":"In Jay\u0027s spec [1] we are planning to define this config option under [compute] section. So is it possible for you to move this under compute section?\n\n[1] https://review.openstack.org/#/c/555081/8/specs/rocky/approved/cpu-resources.rst@152","commit_id":"23267aa4cab7fda8556e6799c2cc6663179a2bc5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"107811a48c8e9b9518234db82337b4b88af10da8","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    vcpu_pin_set \u003d \"4-12,^8,15\""},{"line_number":338,"context_line":"\"\"\"),"},{"line_number":339,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":340,"context_line":"        help\u003d\"\"\""},{"line_number":341,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":342,"context_line":"resources."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5ccc8469","line":339,"range":{"start_line":339,"start_character":15,"end_line":339,"end_character":31},"in_reply_to":"9f6a8fd7_5e6f9c91","updated":"2018-04-18 10:03:32.000000000","message":"Yes good point, Thanks.","commit_id":"23267aa4cab7fda8556e6799c2cc6663179a2bc5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9df0c7acedc86be89eb4be7e046ccb4342d58b8","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":320,"context_line":"  configured as HVM."},{"line_number":321,"context_line":" \"\"\"),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":323,"context_line":"        help\u003d\"\"\""},{"line_number":324,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":325,"context_line":"resources."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_9763d2b1","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":16},"updated":"2018-04-18 14:00:16.000000000","message":"Shouldn\u0027t this be grouped with resource_tracker_opts below, like \u0027vcpu_pin_set\u0027? More importantly, aren\u0027t we moving away from having things in the DEFAULT group. Do we want to move this into another group (placement?) now rather than having to do it later?","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"00768819169989aae91917df1a2038bad379385b","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":320,"context_line":"  configured as HVM."},{"line_number":321,"context_line":" \"\"\"),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":323,"context_line":"        help\u003d\"\"\""},{"line_number":324,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":325,"context_line":"resources."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_dab3af4c","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":16},"in_reply_to":"9f6a8fd7_5a0c7f3a","updated":"2018-04-18 14:24:49.000000000","message":"Hmmm... yes, I see now that there\u0027s only a single option in the [compute] group and it is the \"consecutive_build_service_disable_threshold\" option... :(\n\nMeh, not sure I can all that much, really. I guess this option should go in the [compute] group and thus be added to the compute_group_opts variable below on line 637. But at the same time, I\u0027d be fine with it being in [DEFAULT] as well.","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"69c44736819b9c74f73d3d5228a93cd087b61cda","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":320,"context_line":"  configured as HVM."},{"line_number":321,"context_line":" \"\"\"),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":323,"context_line":"        help\u003d\"\"\""},{"line_number":324,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":325,"context_line":"resources."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_b79296f5","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":16},"in_reply_to":"9f6a8fd7_9763d2b1","updated":"2018-04-18 14:13:25.000000000","message":"vcpu_pin_set will eventually be deprecated (it\u0027s being replaced with cpu_shared_set + cpu_dedicated_set).\n\nI think keeping it in the [compute] group is just fine. It\u0027s actually not placement-specific. It\u0027s nova-compute specific.","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9018099a1ab2c7517637507d89b9b54dc2856775","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":320,"context_line":"  configured as HVM."},{"line_number":321,"context_line":" \"\"\"),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":323,"context_line":"        help\u003d\"\"\""},{"line_number":324,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":325,"context_line":"resources."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_5a0c7f3a","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":16},"in_reply_to":"9f6a8fd7_b79296f5","updated":"2018-04-18 14:19:20.000000000","message":"To be clear, none of these are in the [compute] group. They\u0027re registered in the [DEFAULT] group. That still OK with you?","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"02909d9288f519410e796b387368e944f6fa8966","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":320,"context_line":"  configured as HVM."},{"line_number":321,"context_line":" \"\"\"),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":323,"context_line":"        help\u003d\"\"\""},{"line_number":324,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":325,"context_line":"resources."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_9a7c57ec","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":16},"in_reply_to":"9f6a8fd7_dab3af4c","updated":"2018-04-18 14:45:23.000000000","message":"Oh yes... I wanted to put it under [compute] as suggested by Dinesh.\n\nLet me fix that Jay. And thanks Stephen for pointing it.","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9df0c7acedc86be89eb4be7e046ccb4342d58b8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"Currently only used by libvirt driver to place guest emulator threads when"},{"line_number":328,"context_line":"hw:emulator_threads_policy:share."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    cpu_shared_set \u003d \"4-12,^8,15\""},{"line_number":331,"context_line":"\"\"\")"},{"line_number":332,"context_line":"]"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_d7e14a2c","line":330,"range":{"start_line":330,"start_character":0,"end_line":330,"end_character":33},"updated":"2018-04-18 14:00:16.000000000","message":"I was worried that this would render invalidly but it seems to be OK. However, it should be preceded by a \u0027::\u0027. Can you address this in a follow-up?","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ee4931e8d9e79d8e275722a2595923079fd617a","unresolved":false,"context_lines":[{"line_number":327,"context_line":"Currently only used by libvirt driver to place guest emulator threads when"},{"line_number":328,"context_line":"hw:emulator_threads_policy:share."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    cpu_shared_set \u003d \"4-12,^8,15\""},{"line_number":331,"context_line":"\"\"\")"},{"line_number":332,"context_line":"]"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_659be8c8","line":330,"range":{"start_line":330,"start_character":0,"end_line":330,"end_character":33},"in_reply_to":"9f6a8fd7_d7e14a2c","updated":"2018-04-18 14:54:43.000000000","message":"To be clear, I mean it should like so:\n\n  when ``hw:emulator_threads_policy\u003dshare``::\n\n      cpu_shared_set \u003d \"4-12,^8,15\"","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f976c0a2e279d308ddd4b74e56ecda43fb1ef435","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"* ``shutdown_timeout``"},{"line_number":662,"context_line":"\"\"\"),"},{"line_number":663,"context_line":"        cfg.StrOpt(\u0027cpu_shared_set\u0027,"},{"line_number":664,"context_line":"        help\u003d\"\"\""},{"line_number":665,"context_line":"Defines which physical CPUs (pCPUs) will be used for best-effort guest vCPU"},{"line_number":666,"context_line":"resources."}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_465a6a2a","line":663,"range":{"start_line":663,"start_character":4,"end_line":663,"end_character":8},"updated":"2018-04-18 16:25:59.000000000","message":"This looks like a mistake?","commit_id":"1fdcd6536b47a0437aa1eda866cbcc1881e4ef99"}],"nova/virt/hardware.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"93825b2ea0efbd0f8da94df9ecdba107f7c110cf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    if not CONF.cpu_shared_set:"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    shared_ids \u003d parse_cpu_spec(CONF.cpu_shared_set)"},{"line_number":66,"context_line":"    if not shared_ids:"},{"line_number":67,"context_line":"        raise exception.Invalid(_(\"No CPUs available after parsing \""},{"line_number":68,"context_line":"                                  \"cpu_shared_set config. %r \") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5ead5c2f","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":14},"updated":"2018-04-18 09:05:36.000000000","message":"-1: The existing \"vcpu_pin_set\" and this \"cpu_shared_set\" should be disjoint sets.\n\nIf operator configures these options incorrectly then it will remain unnoticed and it will impact the performance of instances.","commit_id":"23267aa4cab7fda8556e6799c2cc6663179a2bc5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"107811a48c8e9b9518234db82337b4b88af10da8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    if not CONF.cpu_shared_set:"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    shared_ids \u003d parse_cpu_spec(CONF.cpu_shared_set)"},{"line_number":66,"context_line":"    if not shared_ids:"},{"line_number":67,"context_line":"        raise exception.Invalid(_(\"No CPUs available after parsing \""},{"line_number":68,"context_line":"                                  \"cpu_shared_set config. %r \") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_7c3aa834","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":14},"in_reply_to":"9f6a8fd7_5ead5c2f","updated":"2018-04-18 10:03:32.000000000","message":"Not sure about that. cpu_shared_set and cpu_dedicated_set would be disjoint sets.\n\nFor vcpu_pin_set tt\u0027s not really clear. From my point of view we should have cpu_shared_set and cpu_dedicated_set subsets of vcpu_pin_set that because this option globally represents which pCPUs Nova will use. But I know that there are some discussions.\n\nThe point is that this option is going to be deprecated so I would prefer not using it.","commit_id":"23267aa4cab7fda8556e6799c2cc6663179a2bc5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5cb513d442049dbefc2aa1ac55b40091370c9559","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    if not CONF.cpu_shared_set:"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    shared_ids \u003d parse_cpu_spec(CONF.cpu_shared_set)"},{"line_number":66,"context_line":"    if not shared_ids:"},{"line_number":67,"context_line":"        raise exception.Invalid(_(\"No CPUs available after parsing \""},{"line_number":68,"context_line":"                                  \"cpu_shared_set config. %r \") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_2d187c73","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":14},"in_reply_to":"9f6a8fd7_7c3aa834","updated":"2018-04-18 11:41:59.000000000","message":"Sahid is correct, Dinesh. To preserve backwards compatibility, we aren\u0027t changing the meaning nor implementation of vcpu_pin_set. Instead, we\u0027re introducing two new options. CONF.cpu_shared_set in this series and CONF.cpu_dedicated_set in your series.\n\nMake sense?","commit_id":"23267aa4cab7fda8556e6799c2cc6663179a2bc5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b77d1a2ac795cdd5e9ba1345a8f2884a99e4d054","unresolved":false,"context_lines":[{"line_number":57,"context_line":"def get_cpu_shared_set():"},{"line_number":58,"context_line":"    \"\"\"Parse cpu_shared_set config."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :returns: a set of pcpu ids can be used for best effort workloads"},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    if not CONF.cpu_shared_set:"},{"line_number":63,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_327c59b4","line":60,"range":{"start_line":60,"start_character":32,"end_line":60,"end_character":35},"updated":"2018-04-18 11:35:47.000000000","message":"that can","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"}]}