)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"75bd0fbd91687c5c45190d97a2201745a780bf20","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-17 11:20:46 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: pass emulator threads policy instead whether isolated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s necessary to pass the policy since in the following change we"},{"line_number":10,"context_line":"will handle the special case with SHARE and CONF.cpu_share_set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_e2562507","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":62},"updated":"2018-04-17 18:38:12.000000000","message":"not quite sure what you meant by \"instead whether isolated\". Maybe just say \"libvirt: always pass emulator threads policy\"?","commit_id":"c44388e2292a7dd6ac465168c8e7d7ce4f1514cc"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f44b80ede4705c08585ded77139738a6153f5e52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-17 11:20:46 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: pass emulator threads policy instead whether isolated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s necessary to pass the policy since in the following change we"},{"line_number":10,"context_line":"will handle the special case with SHARE and CONF.cpu_share_set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_ab5a3c27","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":62},"in_reply_to":"9f6a8fd7_e2562507","updated":"2018-04-18 08:17:14.000000000","message":"Yes Thanks I was totally stuck at finding a line to explain myself :)","commit_id":"c44388e2292a7dd6ac465168c8e7d7ce4f1514cc"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"75bd0fbd91687c5c45190d97a2201745a780bf20","unresolved":false,"context_lines":[{"line_number":4479,"context_line":"        guest_numa_tune.memnodes \u003d []"},{"line_number":4480,"context_line":""},{"line_number":4481,"context_line":"        emulator_threads_policy \u003d None"},{"line_number":4482,"context_line":"        if instance_numa_topology.obj_attr_is_set(\u0027emulator_threads_policy\u0027):"},{"line_number":4483,"context_line":"            emulator_threads_policy \u003d ("},{"line_number":4484,"context_line":"                instance_numa_topology.emulator_threads_policy)"},{"line_number":4485,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_a2690dbf","line":4482,"range":{"start_line":4482,"start_character":8,"end_line":4482,"end_character":77},"updated":"2018-04-17 18:38:12.000000000","message":"Unless I\u0027m mistaken, I believe the correct way to determine if an object attribute has a value is this:\n\n if \u0027emulator_threads_policy\u0027 in instance_numa_topology:\n\nJust an FYI, though.","commit_id":"c44388e2292a7dd6ac465168c8e7d7ce4f1514cc"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f44b80ede4705c08585ded77139738a6153f5e52","unresolved":false,"context_lines":[{"line_number":4479,"context_line":"        guest_numa_tune.memnodes \u003d []"},{"line_number":4480,"context_line":""},{"line_number":4481,"context_line":"        emulator_threads_policy \u003d None"},{"line_number":4482,"context_line":"        if instance_numa_topology.obj_attr_is_set(\u0027emulator_threads_policy\u0027):"},{"line_number":4483,"context_line":"            emulator_threads_policy \u003d ("},{"line_number":4484,"context_line":"                instance_numa_topology.emulator_threads_policy)"},{"line_number":4485,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_2b186c73","line":4482,"range":{"start_line":4482,"start_character":8,"end_line":4482,"end_character":77},"in_reply_to":"9f6a8fd7_a2690dbf","updated":"2018-04-18 08:17:14.000000000","message":"Yep fixed","commit_id":"c44388e2292a7dd6ac465168c8e7d7ce4f1514cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"318da74b19796492ef6e57ee055aace09ee81699","unresolved":false,"context_lines":[{"line_number":4479,"context_line":"        guest_numa_tune.memnodes \u003d []"},{"line_number":4480,"context_line":""},{"line_number":4481,"context_line":"        emulator_threads_isolated \u003d ("},{"line_number":4482,"context_line":"            instance_numa_topology.emulator_threads_isolated)"},{"line_number":4483,"context_line":""},{"line_number":4484,"context_line":"        # Set realtime scheduler for CPUTune"},{"line_number":4485,"context_line":"        vcpus_rt \u003d set([])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_57b53acc","side":"PARENT","line":4482,"range":{"start_line":4482,"start_character":35,"end_line":4482,"end_character":60},"updated":"2018-04-18 14:03:03.000000000","message":"We still use this property in nova/virt/hardware.py so no need to remove it yet","commit_id":"6ec1851d158e8cfe325283fb27c76d5995570760"}]}