)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"87b8a0b0188606339fc8d4250f1d00470b37ca75","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: unit: Fix \u0027test_live_migration_update_serial_console_xml\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This clean-up is part of the post libvirt / QEMU version bump in"},{"line_number":10,"context_line":"\"Rocky\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Use the migrateToURI3() API instead of migrateToURI2() in test"},{"line_number":13,"context_line":"test_live_migration_update_serial_console_xml."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I60311ee36eed8b4b1063f1ced0f0d0e30e880ca4"},{"line_number":16,"context_line":"Signed-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_9f47854c","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":46},"updated":"2018-04-17 15:06:15.000000000","message":"This doesn\u0027t explain to me why we need these changes since the tests aren\u0027t failing otherwise - if these are related to a specific change for the version stuff, why isn\u0027t it just in that patch? If it has good reason to be standalone, then you should probably explain why this is needed in more detail here because without having the full series context loaded into my brain, this doesn\u0027t make sense to me.","commit_id":"90de1f750fd21d1b7585b7c5ca2cd48dab009502"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"fc401986f56d6f970d8aa93efa4aee154a498513","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: unit: Fix \u0027test_live_migration_update_serial_console_xml\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This clean-up is part of the post libvirt / QEMU version bump in"},{"line_number":10,"context_line":"\"Rocky\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Use the migrateToURI3() API instead of migrateToURI2() in test"},{"line_number":13,"context_line":"test_live_migration_update_serial_console_xml."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I60311ee36eed8b4b1063f1ced0f0d0e30e880ca4"},{"line_number":16,"context_line":"Signed-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_df85fdae","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":46},"in_reply_to":"9f6a8fd7_9f47854c","updated":"2018-04-17 15:29:00.000000000","message":"The failure is indeed due to the patch that bumps libvirt / QEMU version: https://review.openstack.org/#/c/558783/\n\nI didn\u0027t included it in there for the sake of \"cleanliness\".  But, it\u0027s actually not all that large, and since the *source* of the test failures is version bump, it indeed makes sense to squash this in there. (And the other unit test change that also failed: https://review.openstack.org/#/c/561970/)\n\nIn total, along with what\u0027s already in the version bump patch, at least these 4 needs to be fixed (so I\u0027ll include these in there too):\n\nLibvirtConnTestCase.test_live_migration_update_graphics_xml\nLibvirtConnTestCase.test_live_migration_with_valid_target_connect_addr\nLibvirtConnTestCase.test_live_migration_raises_exception\nLibvirtConnTestCase.test_live_migration_update_serial_console_xml","commit_id":"90de1f750fd21d1b7585b7c5ca2cd48dab009502"}]}