)]}'
{"nova/virt/libvirt/connection.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"380095f9c8a65f5e5f5cbe88ed69e64b43c39003","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                               instance[\u0027name\u0027],"},{"line_number":1392,"context_line":"                                               \"ramdisk.rescue\")"},{"line_number":1393,"context_line":"            else:"},{"line_number":1394,"context_line":"                if instance[\u0027kernel_id\u0027]:"},{"line_number":1395,"context_line":"                    guest.os_kernel \u003d os.path.join(FLAGS.instances_path,"},{"line_number":1396,"context_line":"                                                   instance[\u0027name\u0027],"},{"line_number":1397,"context_line":"                                                   \"kernel\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F7qQ%3D","line":1394,"updated":"2012-03-21 16:32:43.000000000","message":"maybe change this to elif so the blocks line up?","commit_id":"247beda24a9ac32c102177fec523d3bb5bb1fb76"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dacf82b08db35e740a651c0c28e9faf677c5d97","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                               instance[\u0027name\u0027],"},{"line_number":1392,"context_line":"                                               \"ramdisk.rescue\")"},{"line_number":1393,"context_line":"            else:"},{"line_number":1394,"context_line":"                if instance[\u0027kernel_id\u0027]:"},{"line_number":1395,"context_line":"                    guest.os_kernel \u003d os.path.join(FLAGS.instances_path,"},{"line_number":1396,"context_line":"                                                   instance[\u0027name\u0027],"},{"line_number":1397,"context_line":"                                                   \"kernel\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFH%2F%2F%2F64%3D","line":1394,"in_reply_to":"AAAAE3%2F%2F6%2FM%3D","updated":"2012-03-23 11:56:51.000000000","message":"Absolutely there is lots more in the libvirt XML generation that should be configurable. That is one of the motivations for writing this patch series in the first place. It will be significantly easier/clearer to make this stuff configurable now we have replaced XML templates with  a formal API.\n\nI\u0027ll change the else/if indentation to use elif.","commit_id":"247beda24a9ac32c102177fec523d3bb5bb1fb76"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e0e19615e320ecffa5ad5f4ab8add625672c1019","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                               instance[\u0027name\u0027],"},{"line_number":1392,"context_line":"                                               \"ramdisk.rescue\")"},{"line_number":1393,"context_line":"            else:"},{"line_number":1394,"context_line":"                if instance[\u0027kernel_id\u0027]:"},{"line_number":1395,"context_line":"                    guest.os_kernel \u003d os.path.join(FLAGS.instances_path,"},{"line_number":1396,"context_line":"                                                   instance[\u0027name\u0027],"},{"line_number":1397,"context_line":"                                                   \"kernel\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F6%2FM%3D","line":1394,"in_reply_to":"AAAAE3%2F%2F7qQ%3D","updated":"2012-03-22 20:13:31.000000000","message":"+1 to that.  Also, I want to raise the idea that we may want to be able to configure some of the other constants above, such as os_init_path or os_kernel, just in case this gets used on a system where they are installed somewhere other than the standard locations.  That could be done as a follow-up patch, however.","commit_id":"247beda24a9ac32c102177fec523d3bb5bb1fb76"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e0e19615e320ecffa5ad5f4ab8add625672c1019","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"                    else:"},{"line_number":1401,"context_line":"                        guest.os_cmdline \u003d \"root\u003d\" + \\"},{"line_number":1402,"context_line":"                            (root_device_name or \"/dev/vda\") + \\"},{"line_number":1403,"context_line":"                            \" console\u003dttyS0\""},{"line_number":1404,"context_line":"                    if instance[\u0027ramdisk_id\u0027]:"},{"line_number":1405,"context_line":"                        guest.os_initrd \u003d os.path.join(FLAGS.instances_path,"},{"line_number":1406,"context_line":"                                                       instance[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F6%2FA%3D","line":1403,"updated":"2012-03-22 20:13:31.000000000","message":"This expression would probably be better as a format, i.e.:\n\n    guest.os_cmdline \u003d \"root\u003d%s console\u003dttyS0\" % (root_device_name or \"/dev/vda\",)","commit_id":"247beda24a9ac32c102177fec523d3bb5bb1fb76"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dacf82b08db35e740a651c0c28e9faf677c5d97","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"                    else:"},{"line_number":1401,"context_line":"                        guest.os_cmdline \u003d \"root\u003d\" + \\"},{"line_number":1402,"context_line":"                            (root_device_name or \"/dev/vda\") + \\"},{"line_number":1403,"context_line":"                            \" console\u003dttyS0\""},{"line_number":1404,"context_line":"                    if instance[\u0027ramdisk_id\u0027]:"},{"line_number":1405,"context_line":"                        guest.os_initrd \u003d os.path.join(FLAGS.instances_path,"},{"line_number":1406,"context_line":"                                                       instance[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFH%2F%2F%2F60%3D","line":1403,"in_reply_to":"AAAAE3%2F%2F6%2FA%3D","updated":"2012-03-23 11:56:51.000000000","message":"Done","commit_id":"247beda24a9ac32c102177fec523d3bb5bb1fb76"}]}