)]}'
{"id":"openstack%2Fnova~5621","triplet_id":"openstack%2Fnova~master~I5ff4ed7cbc69c8c141db840f4d6fc368a13f7f7a","project":"openstack/nova","branch":"master","topic":"bp/libvirt-xml-config-apis","hashtags":[],"change_id":"I5ff4ed7cbc69c8c141db840f4d6fc368a13f7f7a","subject":"Convert libvirt connection class to use config APIs for guests","status":"MERGED","created":"2012-03-21 14:23:45.000000000","updated":"2012-03-23 21:31:41.000000000","submitted":"2012-03-23 21:31:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"09b84ca2f1ded5754b6ca126f74632490e9b5784","_number":5621,"virtual_id_number":5621,"owner":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2012-03-23 21:31:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"date":"2012-03-23 21:31:38.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":2,"date":"2012-03-23 19:38:12.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":2,"date":"2012-03-23 21:31:41.000000000","post_submit":true,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":1,"date":"2012-03-23 19:38:12.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-21 16:32:43.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-03-23 15:30:01.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-03-23 19:38:12.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2012-03-23 21:31:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"380095f9c8a65f5e5f5cbe88ed69e64b43c39003","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-03-21 16:32:43.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e0e19615e320ecffa5ad5f4ab8add625672c1019","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-22 20:13:31.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\n(2 inline comments)\n\nI think nova/virt/libvirt/connection.py needs a little bit of logic clean-up…","accounts_in_message":[],"_revision_number":1},{"id":"8dacf82b08db35e740a651c0c28e9faf677c5d97","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2012-03-23 11:56:51.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1aa24178801bb7f8612c8b73d03870881eb7dc0d","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2012-03-23 14:37:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"94a0d7308a33fbb1c269158d938d8ae390154cb2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-23 15:30:01.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"066445dbbbcfd29c4e082bb537a599ebd0e7a56c","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-03-23 15:48:37.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"669a455de129be8b8d83ab282be2421c9122da18","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-23 16:25:59.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2892/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-merge/1982/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1638/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3363/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e31bd14e51aed46957af1a55dc3a2cf2b8fb8df1","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-03-23 16:27:19.000000000","message":"Patch Set 2:\n\nVolumes test failing is probably transient","accounts_in_message":[],"_revision_number":2},{"id":"f3624423839122a76bcc7d977d414e20b0990842","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-23 16:54:41.000000000","message":"Patch Set 2:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-nova-merge/1982/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1638/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3363/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2904/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"b4b446cc4039a05436780e70a1507129a0841ddb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-23 18:07:03.000000000","message":"Patch Set 2:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2902/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-merge/1992/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1648/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3373/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e4ca57dc921c7efccf28920230c1878669f3612f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-23 18:26:38.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-nova-merge/1992/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1648/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3373/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2918/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9961d8ad21e0f2a45e3517f1b74e7b0cf1f14358","date":"2012-03-23 18:26:41.000000000","message":"Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of If6244629, however the current patch set is 2.\n* Depends on patch set 2 of I0f09a86e, however the current patch set is 2.\n* Depends on patch set 2 of I9dad0317, however the current patch set is 2.\n* Depends on patch set 2 of I4fba2dda, however the current patch set is 2.\n* Depends on patch set 2 of I67031dad, however the current patch set is 2.\n* Depends on patch set 2 of Ifa18cab2, however the current patch set is 2.\n* Depends on patch set 2 of I4e977225, however the current patch set is 2.\n* Depends on patch set 2 of Ied1fad47, however the current patch set is 2.\n* Depends on patch set 2 of I2c5f19a0, however the current patch set is 2.\n* Depends on patch set 2 of I0474b664, however the current patch set is 2.\n* Depends on patch set 4 of I60cbff1c, however the current patch set is 5.\n\nPlease rebase the change and upload a replacement commit.","accounts_in_message":[],"_revision_number":2},{"id":"bc2a623dc6c7006fe5666c3bd5a9615ca58a8426","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2012-03-23 19:30:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a2a4762bd8a7e9e80c3f72d1a7722105a4588649","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-03-23 19:38:12.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\nJust a rebase, reapproving","accounts_in_message":[],"_revision_number":3},{"id":"b9a20fccdbb9426e93919d7e0fd9852b066de041","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-23 21:31:38.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/2936/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/2009/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1665/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/3390/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"806fde9182883a018557ec2adb2a211934925c0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-23 21:31:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c0f678778afefc71649253e685e8f5d6af96b3a9","revisions":{"247beda24a9ac32c102177fec523d3bb5bb1fb76":{"kind":"REWORK","_number":1,"created":"2012-03-21 14:23:45.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/21/5621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/5621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/5621/1"}}},"commit":{"parents":[{"commit":"6dbeefb331d3aa36d33177b3caac8028280033ac","subject":"Move NIC devices back after disk devices","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6dbeefb331d3aa36d33177b3caac8028280033ac"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2012-03-08 16:34:54.000000000","tz":-300},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2012-03-21 13:51:00.000000000","tz":0},"subject":"Convert libvirt connection class to use config APIs for guests","message":"Convert libvirt connection class to use config APIs for guests\n\nRemove the entire Cheetah XML template for libvirt guests\nand make the libvirt connection class use LibvirtConfingGuest\nclasses instead\n\nThe nova \u0027libvirt_xml_template\u0027 config parameter is now obsolete\nand removed.\n\nChange-Id: I5ff4ed7cbc69c8c141db840f4d6fc368a13f7f7a\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/247beda24a9ac32c102177fec523d3bb5bb1fb76"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/247beda24a9ac32c102177fec523d3bb5bb1fb76"}]},"branch":"refs/heads/master"},"d5c5c1b41036953baa076b53c30ee1bedb639c89":{"kind":"REWORK","_number":2,"created":"2012-03-23 14:37:11.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/21/5621/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/5621/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/5621/2"}}},"commit":{"parents":[{"commit":"3b4dcc25f125a5ded47405fc5887b1ba7cc5801a","subject":"Move NIC devices back after disk devices","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3b4dcc25f125a5ded47405fc5887b1ba7cc5801a"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2012-03-08 16:34:54.000000000","tz":-300},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2012-03-23 14:36:39.000000000","tz":0},"subject":"Convert libvirt connection class to use config APIs for guests","message":"Convert libvirt connection class to use config APIs for guests\n\nRemove the entire Cheetah XML template for libvirt guests\nand make the libvirt connection class use LibvirtConfingGuest\nclasses instead\n\nThe nova \u0027libvirt_xml_template\u0027 config parameter is now obsolete\nand removed.\n\nblueprint libvirt-xml-config-apis\nChange-Id: I5ff4ed7cbc69c8c141db840f4d6fc368a13f7f7a\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5c5c1b41036953baa076b53c30ee1bedb639c89"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5c5c1b41036953baa076b53c30ee1bedb639c89"}]},"branch":"refs/heads/master"},"c0f678778afefc71649253e685e8f5d6af96b3a9":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2012-03-23 19:30:44.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/21/5621/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/5621/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/5621/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/5621/3"}}},"commit":{"parents":[{"commit":"80b70c6b30d89fe856b4a305cc641ef0dd7a8b80","subject":"Move NIC devices back after disk devices","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80b70c6b30d89fe856b4a305cc641ef0dd7a8b80"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2012-03-08 16:34:54.000000000","tz":-300},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2012-03-23 19:23:13.000000000","tz":0},"subject":"Convert libvirt connection class to use config APIs for guests","message":"Convert libvirt connection class to use config APIs for guests\n\nRemove the entire Cheetah XML template for libvirt guests\nand make the libvirt connection class use LibvirtConfingGuest\nclasses instead\n\nThe nova \u0027libvirt_xml_template\u0027 config parameter is now obsolete\nand removed.\n\nblueprint libvirt-xml-config-apis\nChange-Id: I5ff4ed7cbc69c8c141db840f4d6fc368a13f7f7a\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c0f678778afefc71649253e685e8f5d6af96b3a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c0f678778afefc71649253e685e8f5d6af96b3a9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
