)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"163bc538c16a5dbd2ee211b6990d1a6634209d9a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"soft_deleted is support in query but we didn\u0027t mention in the doc"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#2127"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c5577a501144170e82c96c04cffbf32dcaa5cff"},{"line_number":14,"context_line":"Closes-Bug: 1765575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_4d35a645","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":45},"updated":"2018-05-08 19:34:24.000000000","message":"You should use a hash or tag in the link otherwise this reference is going to get stale very quickly.","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cf7b084c86a470a5c4a5a4a0f8581926c45f5af6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"soft_deleted is support in query but we didn\u0027t mention in the doc"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#2127"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1c5577a501144170e82c96c04cffbf32dcaa5cff"},{"line_number":14,"context_line":"Closes-Bug: 1765575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_8a73964d","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":45},"in_reply_to":"5f7c97a3_4d35a645","updated":"2018-05-09 09:44:31.000000000","message":"ok, updated it","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d93b857b0c51fbfa8af8f76ddb6544dfd6846dd7","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"  type: string"},{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list with soft_deleted state, it is only valid when"},{"line_number":1118,"context_line":"    ``deleted`` keyword also in the search filter."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"},{"line_number":1121,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_f2de386b","line":1118,"range":{"start_line":1117,"start_character":0,"end_line":1118,"end_character":50},"updated":"2018-04-25 23:00:16.000000000","message":"This should mention the allowable values (which I assume are True and False).\n\nAlso suggest s/with/by/ and making the second clause its own sentence: \"This parameter is only valid when ``deleted`` is also specified.``  (Or is this parameter only valid when deleted\u003dTrue?)","commit_id":"04dbfc927c4279b8d6e889280621518e9f004658"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2add2adcc8d9d3ea942466c483f72bc7a8b2c305","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"  type: string"},{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list with soft_deleted state, it is only valid when"},{"line_number":1118,"context_line":"    ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f6a8fd7_e1607138","line":1117,"range":{"start_line":1117,"start_character":50,"end_line":1117,"end_character":54},"updated":"2018-04-28 15:33:54.000000000","message":". This parameter","commit_id":"c284d47d44458392040c421487b35b01de1a22c5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2add2adcc8d9d3ea942466c483f72bc7a8b2c305","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"  type: string"},{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list with soft_deleted state, it is only valid when"},{"line_number":1118,"context_line":"    ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f6a8fd7_41727d13","line":1117,"range":{"start_line":1117,"start_character":27,"end_line":1117,"end_character":31},"updated":"2018-04-28 15:33:54.000000000","message":"by","commit_id":"c284d47d44458392040c421487b35b01de1a22c5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"163bc538c16a5dbd2ee211b6990d1a6634209d9a","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"  type: string"},{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list by soft_deleted state, This parameter is only valid"},{"line_number":1118,"context_line":"    when ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_2d686a1f","line":1117,"range":{"start_line":1117,"start_character":30,"end_line":1117,"end_character":48},"updated":"2018-05-08 19:34:24.000000000","message":"\"``SOFT_DELETED`` status\"\n\nto match the API guide on server status:\n\nhttps://developer.openstack.org/api-guide/compute/server_concepts.html#server-status","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"163bc538c16a5dbd2ee211b6990d1a6634209d9a","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"  type: string"},{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list by soft_deleted state, This parameter is only valid"},{"line_number":1118,"context_line":"    when ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_0d3fae25","line":1117,"range":{"start_line":1117,"start_character":48,"end_line":1117,"end_character":49},"updated":"2018-05-08 19:34:24.000000000","message":"s/,/./","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cf7b084c86a470a5c4a5a4a0f8581926c45f5af6","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"  type: string"},{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list by soft_deleted state, This parameter is only valid"},{"line_number":1118,"context_line":"    when ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_aac69299","line":1117,"range":{"start_line":1117,"start_character":30,"end_line":1117,"end_character":48},"in_reply_to":"5f7c97a3_2d686a1f","updated":"2018-05-09 09:44:31.000000000","message":"Done","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"163bc538c16a5dbd2ee211b6990d1a6634209d9a","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list by soft_deleted state, This parameter is only valid"},{"line_number":1118,"context_line":"    when ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"},{"line_number":1121,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_ed1cb2c2","line":1118,"range":{"start_line":1118,"start_character":9,"end_line":1118,"end_character":29},"updated":"2018-05-08 19:34:24.000000000","message":"When I first read this, I thought you were talking about a \u0027deleted\u0027 field in the servers response, which doesn\u0027t exist, but now I realize you mean the \u0027deleted\u0027 filter. So maybe this would be more clear if you said, \"This parameter is only valid when the ``deleted\u003dTrue`` filter parameter is specified.\"","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cf7b084c86a470a5c4a5a4a0f8581926c45f5af6","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list by soft_deleted state, This parameter is only valid"},{"line_number":1118,"context_line":"    when ``deleted`` is True."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"},{"line_number":1121,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_aa4bf228","line":1118,"range":{"start_line":1118,"start_character":9,"end_line":1118,"end_character":29},"in_reply_to":"5f7c97a3_ed1cb2c2","updated":"2018-05-09 09:44:31.000000000","message":"yes, that\u0027s exactly what I mean, thanks for the rewording","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"239a8c9ffb6e392dcb92f6ace8943e2d710d12d8","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"soft_deleted_server:"},{"line_number":1116,"context_line":"  description: |"},{"line_number":1117,"context_line":"    Filter the server list by ``SOFT_DELETED`` status. This parameter is only valid"},{"line_number":1118,"context_line":"    when ``deleted\u003dTrue`` filter parameter is specified."},{"line_number":1119,"context_line":"  in: query"},{"line_number":1120,"context_line":"  required: false"},{"line_number":1121,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_efb81477","line":1118,"range":{"start_line":1118,"start_character":4,"end_line":1118,"end_character":9},"updated":"2018-05-09 14:41:00.000000000","message":"when the","commit_id":"8d35015163a123d5085decd5203b8f294d8c4768"}],"api-ref/source/servers.inc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"163bc538c16a5dbd2ee211b6990d1a6634209d9a","unresolved":false,"context_lines":[{"line_number":468,"context_line":"   :language: javascript"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"List Servers Detailed"},{"line_number":472,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":".. rest_method:: GET /servers/detail"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_cd769607","line":471,"updated":"2018-05-08 19:34:24.000000000","message":"The filter parameter also applies to this API right?","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cf7b084c86a470a5c4a5a4a0f8581926c45f5af6","unresolved":false,"context_lines":[{"line_number":468,"context_line":"   :language: javascript"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"List Servers Detailed"},{"line_number":472,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":".. rest_method:: GET /servers/detail"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_6a6e3a96","line":471,"in_reply_to":"5f7c97a3_cd769607","updated":"2018-05-09 09:44:31.000000000","message":"yes","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"163bc538c16a5dbd2ee211b6990d1a6634209d9a","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    # For backward-compatible additionalProperties is set to be True here."},{"line_number":393,"context_line":"    # And we will either strip the extra params out or raise HTTP 400"},{"line_number":394,"context_line":"    # according to the params\u0027 value in the later process."},{"line_number":395,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":396,"context_line":"    # Prevent internal-attributes that are started with underscore from"},{"line_number":397,"context_line":"    # being striped out in schema validation, and raise HTTP 400 in API."},{"line_number":398,"context_line":"    \u0027patternProperties\u0027: {\"^_\": parameter_types.common_query_param}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8dc73e13","line":395,"updated":"2018-05-08 19:34:24.000000000","message":"OK so this wouldn\u0027t fail if specified because of this.","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cf7b084c86a470a5c4a5a4a0f8581926c45f5af6","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    # For backward-compatible additionalProperties is set to be True here."},{"line_number":393,"context_line":"    # And we will either strip the extra params out or raise HTTP 400"},{"line_number":394,"context_line":"    # according to the params\u0027 value in the later process."},{"line_number":395,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":396,"context_line":"    # Prevent internal-attributes that are started with underscore from"},{"line_number":397,"context_line":"    # being striped out in schema validation, and raise HTTP 400 in API."},{"line_number":398,"context_line":"    \u0027patternProperties\u0027: {\"^_\": parameter_types.common_query_param}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0a13060f","line":395,"in_reply_to":"5f7c97a3_8dc73e13","updated":"2018-05-09 09:44:31.000000000","message":"right, we allow additional param","commit_id":"802d04c46e3ad7abca3eaed2f45b4e9149a90f2f"}]}