)]}'
{"nova/tests/virt/test_virt_drivers.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"b0d1ef893c4a243a14e9cd97bf286bb2a806a085","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        service_mock_admin.disabled_reason \u003d \u0027Admin...\u0027"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        from nova.objects import service as service_obj"},{"line_number":741,"context_line":"        self.mox.StubOutWithMock(service_obj.Service,"},{"line_number":742,"context_line":"                                 \u0027get_by_compute_host\u0027)"},{"line_number":743,"context_line":"        service_obj.Service.get_by_compute_host(self.ctxt,"},{"line_number":744,"context_line":"                                    \u0027fake-mini\u0027).AndReturn(service_mock_driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B%2Bck%3D","line":741,"updated":"2013-11-17 09:07:06.000000000","message":"Can you please use mock but not mox in your new unit test as we are planning to use mock for all unit test.\n\nPlease refer to https://blueprints.launchpad.net/nova/+spec/mox-to-mock-conversion for more detail. Thanks.","commit_id":"f89c09cb40a0c29057c43ff29622f8f8300ff56b"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"9688039f3fde3016171a278011cb6d10dfcf890c","unresolved":false,"context_lines":[{"line_number":2613,"context_line":"                self.last_disable_reason \u003d disabled_reason"},{"line_number":2614,"context_line":"                return True"},{"line_number":2615,"context_line":"            elif not disable_service and \\"},{"line_number":2616,"context_line":"                                disabled_reason \u003d\u003d self.last_disable_reason:"},{"line_number":2617,"context_line":"                self.last_disable_reason \u003d None"},{"line_number":2618,"context_line":"                return True"},{"line_number":2619,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FE0c%3D","line":2616,"updated":"2013-11-14 22:01:03.000000000","message":"Should you still check \"not disable_service\" here?","commit_id":"b4b86788413d6714c6d61d403856366532b70924"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"b0d1ef893c4a243a14e9cd97bf286bb2a806a085","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            self.disk_cachemodes[disk_type] \u003d cache_mode"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        self._volume_api \u003d volume.API()"},{"line_number":369,"context_line":"        self._last_disable_reason \u003d \u0027None\u0027"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    @property"},{"line_number":372,"context_line":"    def disk_cachemode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B%2Bcc%3D","line":369,"updated":"2013-11-17 09:07:06.000000000","message":"You can just set self._last_disable_reason as None but not \u0027None\u0027.","commit_id":"f89c09cb40a0c29057c43ff29622f8f8300ff56b"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"b0d1ef893c4a243a14e9cd97bf286bb2a806a085","unresolved":false,"context_lines":[{"line_number":2633,"context_line":"        try:"},{"line_number":2634,"context_line":"            service \u003d service_obj.Service.get_by_compute_host(ctx, CONF.host)"},{"line_number":2635,"context_line":""},{"line_number":2636,"context_line":"            if service.disabled !\u003d disable_service and \\"},{"line_number":2637,"context_line":"                                   should_update(disable_service,"},{"line_number":2638,"context_line":"                                                 service.disabled_reason):"},{"line_number":2639,"context_line":"                service.disabled \u003d disable_service"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B%2BcY%3D","line":2636,"updated":"2013-11-17 09:07:06.000000000","message":"Do not use \\ but () to connect a long sentence.","commit_id":"f89c09cb40a0c29057c43ff29622f8f8300ff56b"}]}