)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"70050dceae0e531d934ed11290815d6e4616d620","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        # Associate the node with an instance"},{"line_number":360,"context_line":"        if not node.instance_uuid:"},{"line_number":361,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_uuid\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":362,"context_line":"                          \u0027value\u0027: instance.uuid})"},{"line_number":363,"context_line":"        try:"},{"line_number":364,"context_line":"            # FIXME(lucasagomes): The \"retry_on_conflict\" parameter was added"},{"line_number":365,"context_line":"            # to basically causes the deployment to fail faster in case the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_7def82e8","line":362,"updated":"2018-04-24 13:48:54.000000000","message":"Is there a code path that wouldn\u0027t already have this set? This feels incredibly dangerous to do, as having this in the patch prevents the patch from updating the node if there\u0027s already an instance_uuid set (e.g. on an active node).","commit_id":"d2fe215bc63ac50f8b59d573d084f447e98bc050"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"70050dceae0e531d934ed11290815d6e4616d620","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"                         \"when provisioning the instance %(instance)s\")"},{"line_number":1412,"context_line":"                       % {\u0027node\u0027: node.uuid, \u0027instance\u0027: instance.uuid})"},{"line_number":1413,"context_line":"                LOG.error(msg)"},{"line_number":1414,"context_line":"                raise exception.InstanceDeployFailure(msg)"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"        # NOTE(PhilDay): Accessing network_info will block if the thread"},{"line_number":1417,"context_line":"        # it wraps hasn\u0027t finished, so do this ahead of time so that we"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_5d907e4a","line":1414,"updated":"2018-04-24 13:48:54.000000000","message":"This whole thing feels out of place here - I think doing it explicitly might be better, something like: https://review.openstack.org/#/c/563722/\n\nAlso, what happens when we have another method that comes before `prepare_networks_before_block_device_mapping` which has similar effects? :)","commit_id":"d2fe215bc63ac50f8b59d573d084f447e98bc050"}]}