)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c3c692d6f307ea65e3a3ce6f63e337bf1e905c3e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"device was inadvertantly dropped, presumably because there was"},{"line_number":12,"context_line":"no test for that case."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The validation is added back here along with a test. The code"},{"line_number":15,"context_line":"change itself is based on a review comment suggestion from"},{"line_number":16,"context_line":"Stephen Finucane in I8a3e7e6c4b72eb1c3707d54049d18dc29f606fe5."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_8c8fa528","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":33},"updated":"2018-04-25 21:16:44.000000000","message":"It\u0027s not.  See inline.","commit_id":"ce5844fac41885c2a3e9a03d54d7bb8a7bf3a4cd"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e96b833c67870332f0cd35ede64a7ea50ba621b4","unresolved":false,"context_lines":[{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"        # Each device which is capable of being used as boot device should"},{"line_number":1289,"context_line":"        # be given a unique boot index, starting from 0 in ascending order."},{"line_number":1290,"context_line":"        if boot_indexes !\u003d range(0, len(boot_indexes)):"},{"line_number":1291,"context_line":"            # Convert the BlockDeviceMappingList to a list for repr details."},{"line_number":1292,"context_line":"            LOG.debug(\u0027Invalid block device mapping boot sequence for \u0027"},{"line_number":1293,"context_line":"                      \u0027instance: %s\u0027, list(block_device_mappings),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_1dad269a","line":1290,"range":{"start_line":1290,"start_character":27,"end_line":1290,"end_character":54},"updated":"2018-04-24 13:48:27.000000000","message":"For some reason this generates an xrange sometimes:\n\nwebob.exc.HTTPBadRequest: boot_indexes ([0]) !\u003d range(0, len(boot_indexes)) (xrange(1)): [BlockDeviceMapping(attachment_id\u003d\u003c?\u003e,boot_index\u003d0,connection_info\u003dNone,created_at\u003d\u003c?\u003e,delete_on_termination\u003dTrue,deleted\u003d\u003c?\u003e,deleted_at\u003d\u003c?\u003e,destination_type\u003d\u0027local\u0027,device_name\u003dNone,device_type\u003d\u0027disk\u0027,disk_bus\u003dNone,guest_format\u003dNone,id\u003d\u003c?\u003e,image_id\u003d\u002776fa36fc-c930-4bf3-8c8a-ea2a2420deb6\u0027,instance\u003d\u003c?\u003e,instance_uuid\u003d\u003c?\u003e,no_device\u003dFalse,snapshot_id\u003dNone,source_type\u003d\u0027image\u0027,tag\u003dNone,updated_at\u003d\u003c?\u003e,uuid\u003d\u003c?\u003e,volume_id\u003dNone,volume_size\u003dNone)]\n\nSo we need to cast it to a list so we\u0027re not trying to compare a list to an xrange generator.","commit_id":"9515c47e03e2b50d6e54cc06bf7762328499dad6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c3c692d6f307ea65e3a3ce6f63e337bf1e905c3e","unresolved":false,"context_lines":[{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"        # Each device which is capable of being used as boot device should"},{"line_number":1289,"context_line":"        # be given a unique boot index, starting from 0 in ascending order."},{"line_number":1290,"context_line":"        if boot_indexes !\u003d list(range(len(boot_indexes))):"},{"line_number":1291,"context_line":"            # Convert the BlockDeviceMappingList to a list for repr details."},{"line_number":1292,"context_line":"            LOG.debug(\u0027Invalid block device mapping boot sequence for \u0027"},{"line_number":1293,"context_line":"                      \u0027instance: %s\u0027, list(block_device_mappings),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_cc97dd44","line":1290,"range":{"start_line":1290,"start_character":0,"end_line":1290,"end_character":58},"updated":"2018-04-25 21:16:44.000000000","message":"Sorry, I don\u0027t see how you\u0027ve changed anything logically here.  The commit message says you\u0027ve added back in a check for a boot_index of 0, but...\n\n In [21]: boot_indexes \u003d []\n\n In [22]: any(x !\u003d y for x, y in enumerate(boot_indexes))\n Out[22]: False\n\n In [23]: boot_indexes !\u003d list(range(len(boot_indexes)))\n Out[23]: False","commit_id":"ce5844fac41885c2a3e9a03d54d7bb8a7bf3a4cd"}]}