)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15b65d2edeb958e74380742f8f8edb226fc9b433","unresolved":false,"context_lines":[{"line_number":9834,"context_line":"    @mock.patch.object(host.Host, \"get_connection\")"},{"line_number":9835,"context_line":"    @mock.patch(\u0027nova.objects.BlockDeviceMappingList.get_by_instance_uuid\u0027)"},{"line_number":9836,"context_line":"    @mock.patch.object(fakelibvirt.Domain, \"XMLDesc\")"},{"line_number":9837,"context_line":"    def test_live_migration_copy_disk_paths(self, mock_xml,"},{"line_number":9838,"context_line":"                                            mock_get_instance, mock_conn):"},{"line_number":9839,"context_line":"        xml \u003d \"\"\""},{"line_number":9840,"context_line":"        \u003cdomain\u003e"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_c671ec0e","line":9837,"range":{"start_line":9837,"start_character":8,"end_line":9837,"end_character":43},"updated":"2018-04-26 14:06:18.000000000","message":"This is now a duplicate of test_live_migration_copy_disk_paths_selective_block_migration right? Seems like we can just remove this test as well.","commit_id":"79d63ee2e8f2d2ed2cec4039ce8218e495970755"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"d56d2ff0347c7b7bc4819a3f1b5b7066ee7d393c","unresolved":false,"context_lines":[{"line_number":9834,"context_line":"    @mock.patch.object(host.Host, \"get_connection\")"},{"line_number":9835,"context_line":"    @mock.patch(\u0027nova.objects.BlockDeviceMappingList.get_by_instance_uuid\u0027)"},{"line_number":9836,"context_line":"    @mock.patch.object(fakelibvirt.Domain, \"XMLDesc\")"},{"line_number":9837,"context_line":"    def test_live_migration_copy_disk_paths(self, mock_xml,"},{"line_number":9838,"context_line":"                                            mock_get_instance, mock_conn):"},{"line_number":9839,"context_line":"        xml \u003d \"\"\""},{"line_number":9840,"context_line":"        \u003cdomain\u003e"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_8269698c","line":9837,"range":{"start_line":9837,"start_character":8,"end_line":9837,"end_character":43},"in_reply_to":"9f6a8fd7_c671ec0e","updated":"2018-04-30 11:23:02.000000000","message":"After examining the other test more closely, yes, we can.  Damn, spent a few hours debugging this unit test.  Could have saved that time.","commit_id":"79d63ee2e8f2d2ed2cec4039ce8218e495970755"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15b65d2edeb958e74380742f8f8edb226fc9b433","unresolved":false,"context_lines":[{"line_number":6947,"context_line":"                    libvirt.VIR_MIGRATE_TUNNELLED \u003d\u003d 0):"},{"line_number":6948,"context_line":"                    migrate_uri \u003d self._migrate_uri(dest)"},{"line_number":6949,"context_line":""},{"line_number":6950,"context_line":"            params \u003d None"},{"line_number":6951,"context_line":"            new_xml_str \u003d None"},{"line_number":6952,"context_line":"            if CONF.libvirt.virt_type !\u003d \"parallels\":"},{"line_number":6953,"context_line":"                new_xml_str \u003d libvirt_migrate.get_updated_guest_xml("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_26b0e8dd","line":6950,"range":{"start_line":6950,"start_character":12,"end_line":6950,"end_character":25},"updated":"2018-04-26 14:06:18.000000000","message":"nit: you can remove this since it\u0027s going to be overwritten below.","commit_id":"79d63ee2e8f2d2ed2cec4039ce8218e495970755"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"d56d2ff0347c7b7bc4819a3f1b5b7066ee7d393c","unresolved":false,"context_lines":[{"line_number":6947,"context_line":"                    libvirt.VIR_MIGRATE_TUNNELLED \u003d\u003d 0):"},{"line_number":6948,"context_line":"                    migrate_uri \u003d self._migrate_uri(dest)"},{"line_number":6949,"context_line":""},{"line_number":6950,"context_line":"            params \u003d None"},{"line_number":6951,"context_line":"            new_xml_str \u003d None"},{"line_number":6952,"context_line":"            if CONF.libvirt.virt_type !\u003d \"parallels\":"},{"line_number":6953,"context_line":"                new_xml_str \u003d libvirt_migrate.get_updated_guest_xml("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_e20dc5e8","line":6950,"range":{"start_line":6950,"start_character":12,"end_line":6950,"end_character":25},"in_reply_to":"9f6a8fd7_26b0e8dd","updated":"2018-04-30 11:23:02.000000000","message":"Good call, indeed; will remove.","commit_id":"79d63ee2e8f2d2ed2cec4039ce8218e495970755"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6964441d5ee40081342eb9729e753f7a93ebd2a","unresolved":false,"context_lines":[{"line_number":226,"context_line":"NEXT_MIN_LIBVIRT_VERSION \u003d (3, 0, 0)"},{"line_number":227,"context_line":"NEXT_MIN_QEMU_VERSION \u003d (2, 8, 0)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# When the above version matches/exceeds this version"},{"line_number":230,"context_line":"# delete it \u0026 corresponding code using it"},{"line_number":231,"context_line":"# Libvirt version 1.2.17 is required for successful block live migration"},{"line_number":232,"context_line":"# of vm booted from image with attached devices"},{"line_number":233,"context_line":"MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION \u003d (1, 2, 17)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_5391e1f0","side":"PARENT","line":230,"range":{"start_line":229,"start_character":0,"end_line":230,"end_character":41},"updated":"2018-04-30 14:33:08.000000000","message":"I would have kept this, though I guess it\u0027s pretty self-explanatory","commit_id":"95d4d471b90f2e05a32a50ebe5ba8c20c7ed49d4"}]}