)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8d35d906d0828461b2a55e93e4e3ca136b39174","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When hard rebooting an instance, if libvirt doesn\u0027t know about it,"},{"line_number":10,"context_line":"we had a raised InstanceNotFound exception."},{"line_number":11,"context_line":"Lots of operators use hard reboot for recrating the libvirt XML"},{"line_number":12,"context_line":"in case of a problem with some instance, so it was then an issue"},{"line_number":13,"context_line":"if because of the bug it wasn\u0027t possible now."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_23d31106","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":47},"updated":"2018-04-25 15:49:42.000000000","message":"recreating","commit_id":"1ed859fd0ac5fbc02c10f30bbe49437edb475256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8d35d906d0828461b2a55e93e4e3ca136b39174","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When hard rebooting an instance, if libvirt doesn\u0027t know about it,"},{"line_number":10,"context_line":"we had a raised InstanceNotFound exception."},{"line_number":11,"context_line":"Lots of operators use hard reboot for recrating the libvirt XML"},{"line_number":12,"context_line":"in case of a problem with some instance, so it was then an issue"},{"line_number":13,"context_line":"if because of the bug it wasn\u0027t possible now."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iff30e59ced63a94c5c3377317a2e2a502f96eb91"},{"line_number":16,"context_line":"Closes-Bug: #1764460"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_43ce455a","line":13,"range":{"start_line":12,"start_character":41,"end_line":13,"end_character":45},"updated":"2018-04-25 15:49:42.000000000","message":"what? also, mention the regression (mdev stuff)","commit_id":"1ed859fd0ac5fbc02c10f30bbe49437edb475256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa30ff966841f9442096d480d9162dd9c5d25a3c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: fix hard reboot issue with mdevs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sometimes, a Nova instance can\u0027t have an associated libvirt guest."},{"line_number":10,"context_line":"The usual way to fix that is to hard reboot the instance, so the"},{"line_number":11,"context_line":"virt driver recreates the guest."},{"line_number":12,"context_line":"Unfortunately, we introduced a regression in Queens with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_1efbc0c0","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":32},"updated":"2018-04-25 16:16:21.000000000","message":"nit: doesn\u0027t?\n\nNot having a guest in the hypervisor is an exceptional scenario, correct? As in live migration failed and now the hypervisor on one of the nodes is out of whack.","commit_id":"b5dc08c865e72fa1bd3d592d84a65f174dff82cc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa30ff966841f9442096d480d9162dd9c5d25a3c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Ie6c9108808a461359d717d8a9e9399c8a407bfe9 because we weren\u0027t"},{"line_number":14,"context_line":"checking whether the guest was there or not."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"That fix aims to catch the InstanceNotFound exception that\u0027s"},{"line_number":17,"context_line":"raised and just tell there are no mediated devices attached to that"},{"line_number":18,"context_line":"instance (given we can no longer know them)."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_de00e8ad","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"updated":"2018-04-25 16:16:21.000000000","message":"This fix. \"That\" sounds like you\u0027re referring to Ie6c9108808a461359d717d8a9e9399c8a407bfe9.","commit_id":"b5dc08c865e72fa1bd3d592d84a65f174dff82cc"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"060b3e693e8b1bd7f29b2fdb42b26674116134c7","unresolved":false,"context_lines":[{"line_number":6050,"context_line":"        \"\"\""},{"line_number":6051,"context_line":"        allocated_mdevs \u003d {}"},{"line_number":6052,"context_line":"        if instance:"},{"line_number":6053,"context_line":"            # Make sure the libvirt guest is existing"},{"line_number":6054,"context_line":"            try:"},{"line_number":6055,"context_line":"                guest \u003d self._host.get_guest(instance)"},{"line_number":6056,"context_line":"            except exception.InstanceNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_63fee96b","line":6053,"range":{"start_line":6053,"start_character":12,"end_line":6053,"end_character":53},"updated":"2018-04-25 15:50:37.000000000","message":"You should probably give some more context about which cases this might happen, like during a hard reboot.","commit_id":"1ed859fd0ac5fbc02c10f30bbe49437edb475256"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c9476d6a4b4688ccd8ca3f63fd467366147fbb2","unresolved":false,"context_lines":[{"line_number":6052,"context_line":"        if instance:"},{"line_number":6053,"context_line":"            # NOTE(sbauza): In some cases (like a migration issue), the"},{"line_number":6054,"context_line":"            # instance can exist in the Nova database but libvirt doesn\u0027t know"},{"line_number":6055,"context_line":"            # about it. For such cases, the way to fix that is to hard reboot"},{"line_number":6056,"context_line":"            # the instance, which will recreate the libvirt guest."},{"line_number":6057,"context_line":"            # For that reason, we need to support that case by making sure"},{"line_number":6058,"context_line":"            # we don\u0027t raise an exception if the libvirt guest doesn\u0027t exist."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_90480f5c","line":6055,"range":{"start_line":6055,"start_character":55,"end_line":6055,"end_character":59},"updated":"2018-04-26 08:29:42.000000000","message":"this","commit_id":"8941c79f0924413822b15824a298e081e345e616"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c9476d6a4b4688ccd8ca3f63fd467366147fbb2","unresolved":false,"context_lines":[{"line_number":6054,"context_line":"            # instance can exist in the Nova database but libvirt doesn\u0027t know"},{"line_number":6055,"context_line":"            # about it. For such cases, the way to fix that is to hard reboot"},{"line_number":6056,"context_line":"            # the instance, which will recreate the libvirt guest."},{"line_number":6057,"context_line":"            # For that reason, we need to support that case by making sure"},{"line_number":6058,"context_line":"            # we don\u0027t raise an exception if the libvirt guest doesn\u0027t exist."},{"line_number":6059,"context_line":"            try:"},{"line_number":6060,"context_line":"                guest \u003d self._host.get_guest(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5078378e","line":6057,"range":{"start_line":6057,"start_character":50,"end_line":6057,"end_character":54},"updated":"2018-04-26 08:29:42.000000000","message":"this","commit_id":"8941c79f0924413822b15824a298e081e345e616"}]}