)]}'
{"nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f0056967fffc4b15b5edda19106568ede04cd174","unresolved":false,"context_lines":[{"line_number":26,"context_line":"_set_traits \u003d tb._set_traits"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ProviderDBHelperTestCase(tb.PlacementDbBaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_get_provider_ids_matching(self):"},{"line_number":32,"context_line":"        # These RPs are named based on whether we expect them to be \u0027incl\u0027uded"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_33bbdac4","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":22},"updated":"2018-05-02 17:50:06.000000000","message":"by \"DBHelper\", you are referring to the fact that these functional tests are directly executing functions in the objects/resource_provider.py module space (as opposed to functions like AllocationCandidates.get_by_requests())?","commit_id":"8ce4c458630265ad66cee80608486a7eae1251f7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a1f48e1f1231bc695753643b403741b22ed3ef2d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"_set_traits \u003d tb._set_traits"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ProviderDBHelperTestCase(tb.PlacementDbBaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_get_provider_ids_matching(self):"},{"line_number":32,"context_line":"        # These RPs are named based on whether we expect them to be \u0027incl\u0027uded"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5c721b4b","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":22},"in_reply_to":"9f6a8fd7_33bbdac4","updated":"2018-05-02 20:09:05.000000000","message":"I didn\u0027t come up with this name.  I assumed it was the same \"DB\" as in the file path.","commit_id":"8ce4c458630265ad66cee80608486a7eae1251f7"}],"nova/tests/functional/api/openstack/placement/db/test_base.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"069b3f1a7a006b65626da6e87e379888529a5577","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova.tests import uuidsentinel as uuids"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DISK_INVENTORY \u003d dict("},{"line_number":27,"context_line":"    total\u003d200,"},{"line_number":28,"context_line":"    reserved\u003d10,"},{"line_number":29,"context_line":"    min_unit\u003d2,"},{"line_number":30,"context_line":"    max_unit\u003d5,"},{"line_number":31,"context_line":"    step_size\u003d1,"},{"line_number":32,"context_line":"    allocation_ratio\u003d1.0,"},{"line_number":33,"context_line":"    resource_class\u003dfields.ResourceClass.DISK_GB"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DISK_ALLOCATION \u003d dict("},{"line_number":37,"context_line":"    consumer_id\u003duuids.disk_consumer,"},{"line_number":38,"context_line":"    used\u003d2,"},{"line_number":39,"context_line":"    resource_class\u003dfields.ResourceClass.DISK_GB"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _add_inventory(rp, rc, total, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_021330ba","line":40,"range":{"start_line":26,"start_character":0,"end_line":40,"end_character":1},"updated":"2018-04-27 18:34:17.000000000","message":"would be nice if we didn\u0027t bring these over into the base class and instead modified _make_allocation() to require the inv_dict parameter.","commit_id":"433aefa13b994eb437c26c39bdc7bde356c24952"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0fcf5a456020d43fa79f8a25293a281a0e917355","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova.tests import uuidsentinel as uuids"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DISK_INVENTORY \u003d dict("},{"line_number":27,"context_line":"    total\u003d200,"},{"line_number":28,"context_line":"    reserved\u003d10,"},{"line_number":29,"context_line":"    min_unit\u003d2,"},{"line_number":30,"context_line":"    max_unit\u003d5,"},{"line_number":31,"context_line":"    step_size\u003d1,"},{"line_number":32,"context_line":"    allocation_ratio\u003d1.0,"},{"line_number":33,"context_line":"    resource_class\u003dfields.ResourceClass.DISK_GB"},{"line_number":34,"context_line":")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DISK_ALLOCATION \u003d dict("},{"line_number":37,"context_line":"    consumer_id\u003duuids.disk_consumer,"},{"line_number":38,"context_line":"    used\u003d2,"},{"line_number":39,"context_line":"    resource_class\u003dfields.ResourceClass.DISK_GB"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _add_inventory(rp, rc, total, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_ff500e0d","line":40,"range":{"start_line":26,"start_character":0,"end_line":40,"end_character":1},"in_reply_to":"9f6a8fd7_021330ba","updated":"2018-04-27 22:31:39.000000000","message":"Done","commit_id":"433aefa13b994eb437c26c39bdc7bde356c24952"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"069b3f1a7a006b65626da6e87e379888529a5577","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    ).create_all()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ProviderBaseTestCase(test.NoDBTestCase):"},{"line_number":75,"context_line":"    USES_DB_SELF \u003d True"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_826bc01d","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":18},"updated":"2018-04-27 18:34:17.000000000","message":"How about PlacementDbBaseTestCase?","commit_id":"433aefa13b994eb437c26c39bdc7bde356c24952"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0fcf5a456020d43fa79f8a25293a281a0e917355","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    ).create_all()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ProviderBaseTestCase(test.NoDBTestCase):"},{"line_number":75,"context_line":"    USES_DB_SELF \u003d True"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_9f5552fd","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":18},"in_reply_to":"9f6a8fd7_826bc01d","updated":"2018-04-27 22:31:39.000000000","message":"Done","commit_id":"433aefa13b994eb437c26c39bdc7bde356c24952"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f0056967fffc4b15b5edda19106568ede04cd174","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _allocate_from_provider(rp, rc, used):"},{"line_number":46,"context_line":"    # NOTE(efried): Always use a random consumer UUID - we don\u0027t want to"},{"line_number":47,"context_line":"    # override any existing allocations from the test case."},{"line_number":48,"context_line":"    rp_obj.AllocationList("},{"line_number":49,"context_line":"        rp._context, objects\u003d["}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_d3e61ee9","line":46,"range":{"start_line":46,"start_character":20,"end_line":46,"end_character":53},"updated":"2018-05-02 17:50:06.000000000","message":"Probably not what we want if/when the Consumer object patches land, since those test for specific expected consumer UUIDs. But, meh, not an issue in this patch really.","commit_id":"8ce4c458630265ad66cee80608486a7eae1251f7"}]}