)]}'
{"nova/tests/functional/api/openstack/placement/db/test_base.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"464063c05d91f8a499294a2c59afb920ccfe32ac","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return inv"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def add_disk_inventory(rp):"},{"line_number":53,"context_line":"    # Copy"},{"line_number":54,"context_line":"    inv \u003d dict(DISK_INVENTORY)"},{"line_number":55,"context_line":"    add_inventory(rp, inv.pop(\u0027resource_class\u0027), inv.pop(\u0027total\u0027), **inv)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def set_traits(rp, *traits):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_a2ffe432","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":73},"updated":"2018-04-27 18:38:48.000000000","message":"I don\u0027t really see a value in having an add_disk_inventory() function.","commit_id":"946a3896eeefcef92a2a1c58984b42e70e5ac82b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bfc9540bcd64ee15d1b2c427f90e5343020bea2f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return inv"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def add_disk_inventory(rp):"},{"line_number":53,"context_line":"    # Copy"},{"line_number":54,"context_line":"    inv \u003d dict(DISK_INVENTORY)"},{"line_number":55,"context_line":"    add_inventory(rp, inv.pop(\u0027resource_class\u0027), inv.pop(\u0027total\u0027), **inv)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def set_traits(rp, *traits):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_bf5a9627","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":73},"in_reply_to":"9f6a8fd7_a2ffe432","updated":"2018-04-27 22:31:44.000000000","message":"Done","commit_id":"946a3896eeefcef92a2a1c58984b42e70e5ac82b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"464063c05d91f8a499294a2c59afb920ccfe32ac","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    return alloc_list"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def allocate_disk_from_provider(rp):"},{"line_number":85,"context_line":"    allocate_from_provider("},{"line_number":86,"context_line":"        rp, DISK_ALLOCATION[\u0027resource_class\u0027], DISK_ALLOCATION[\u0027used\u0027],"},{"line_number":87,"context_line":"        consumer_id\u003dDISK_ALLOCATION[\u0027consumer_id\u0027])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class ProviderBaseTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_a2ada432","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":51},"updated":"2018-04-27 18:38:48.000000000","message":"or an allocation_disk_from_provider() function.\n\nWhat I mean by that is are we going to have an add_vcpu_inventory() and add_ram_inventory() function, etc? This is partly why I want to get rid of the module-scoped DISK_INVENTORY constants and just have the make_allocations() function require an inv_dict param.","commit_id":"946a3896eeefcef92a2a1c58984b42e70e5ac82b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bfc9540bcd64ee15d1b2c427f90e5343020bea2f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    return alloc_list"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def allocate_disk_from_provider(rp):"},{"line_number":85,"context_line":"    allocate_from_provider("},{"line_number":86,"context_line":"        rp, DISK_ALLOCATION[\u0027resource_class\u0027], DISK_ALLOCATION[\u0027used\u0027],"},{"line_number":87,"context_line":"        consumer_id\u003dDISK_ALLOCATION[\u0027consumer_id\u0027])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class ProviderBaseTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_ff9eceb6","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":51},"in_reply_to":"9f6a8fd7_a2ada432","updated":"2018-04-27 22:31:44.000000000","message":"It was just to have a convenient way of using DISK_INVENTORY without having to peel it apart to use add_inventory (no, there was never a plan to add_vcpu_inventory etc.).  I didn\u0027t want to make add_inventory take kwargs (because its whole purpose is terseness, and I didn\u0027t want to go name the kwargs in the dozens of existing usages, which is kind of a bugbear of mine).  It wasn\u0027t used in that many places, so I just fixed those up to \"peel\" as stated and got rid of these methods.","commit_id":"946a3896eeefcef92a2a1c58984b42e70e5ac82b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d4e9ec1c9209dd2cdd139f8d1355b8629f5bc86b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    return tlist"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def allocate_from_provider(rp, rc, used, consumer_id\u003dNone):"},{"line_number":48,"context_line":"    # NOTE(efried): If not specified, use a random consumer UUID - we don\u0027t"},{"line_number":49,"context_line":"    # want to override any existing allocations from the test case."},{"line_number":50,"context_line":"    consumer_id \u003d consumer_id or uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_f337a24c","line":47,"range":{"start_line":47,"start_character":39,"end_line":47,"end_character":57},"updated":"2018-05-02 17:54:06.000000000","message":"ha! you were one step ahead of me already :)","commit_id":"ad47c319ef76ad5c8501d78bf4a7820f85e17f28"}]}