)]}'
{"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"493c321d35c2ddbdb86efdcbf247ca799bc44ed7","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027unshelve_instance\u0027)"},{"line_number":961,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027start_instance\u0027)"},{"line_number":962,"context_line":"    def test_unshelve_instance_on_host(self, mock_start, mock_unshelve):"},{"line_number":963,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":964,"context_line":"        instance.vm_state \u003d vm_states.SHELVED"},{"line_number":965,"context_line":"        instance.task_state \u003d task_states.UNSHELVING"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_36bc64db","line":962,"range":{"start_line":962,"start_character":57,"end_line":962,"end_character":70},"updated":"2018-05-07 08:44:39.000000000","message":"this also you can check call with assert_called_once_with","commit_id":"16bfacefa91945ae14bc16296e76882a7fd4aeef"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ba5a65e2809d16079167739acf814dbe6b012663","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027unshelve_instance\u0027)"},{"line_number":961,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027start_instance\u0027)"},{"line_number":962,"context_line":"    def test_unshelve_instance_on_host(self, mock_start, mock_unshelve):"},{"line_number":963,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":964,"context_line":"        instance.vm_state \u003d vm_states.SHELVED"},{"line_number":965,"context_line":"        instance.task_state \u003d task_states.UNSHELVING"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1cbb740e","line":962,"range":{"start_line":962,"start_character":57,"end_line":962,"end_character":70},"in_reply_to":"5f7c97a3_36bc64db","updated":"2018-05-08 05:24:54.000000000","message":"Done","commit_id":"16bfacefa91945ae14bc16296e76882a7fd4aeef"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c91a6cdd78359556c4c27a12bf10de0927e3d910","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"    @mock.patch.object(objects.InstanceMapping, \u0027get_by_instance_uuid\u0027)"},{"line_number":1212,"context_line":"    @mock.patch.object(objects.RequestSpec, \u0027from_primitives\u0027)"},{"line_number":1213,"context_line":"    def test_unshelve_instance_schedule_and_rebuild_volume_backed("},{"line_number":1214,"context_line":"            self, fp, mock_im, mock_build, mock_schedule, mock_unshelve):"},{"line_number":1215,"context_line":"        fake_spec \u003d objects.RequestSpec()"},{"line_number":1216,"context_line":"        fp.return_value \u003d fake_spec"},{"line_number":1217,"context_line":"        mock_im.return_value \u003d objects.InstanceMapping("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ac15ee41","line":1214,"range":{"start_line":1214,"start_character":18,"end_line":1214,"end_character":20},"updated":"2018-05-14 18:15:45.000000000","message":"nit: better to put \"mock_\" before fp. It is fine to make this out of scope from this patch.","commit_id":"d55300d4905002efd4f0d1935eb65922a80352c7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"387a48aee27c78d35b033d6492486409be7b363f","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"            self.conductor_manager.unshelve_instance,"},{"line_number":1068,"context_line":"            self.context, instance)"},{"line_number":1069,"context_line":"        self.assertEqual(instance.vm_state, vm_states.ERROR)"},{"line_number":1070,"context_line":"        mock_get.asser_called_once_with(self.context, uuids.image,"},{"line_number":1071,"context_line":"                                        show_deleted\u003dFalse)"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    def test_unshelve_offloaded_instance_image_id_is_none(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_575a5e83","line":1070,"range":{"start_line":1070,"start_character":17,"end_line":1070,"end_character":39},"updated":"2018-05-17 14:31:41.000000000","message":"s/asser_/assert_","commit_id":"5a237462e61e41e2d1b5d3e0a1834bdb87ffd618"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4852928ec64afab73f057ee13b47cf6961a4ecfd","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"            self.conductor_manager.unshelve_instance,"},{"line_number":1068,"context_line":"            self.context, instance)"},{"line_number":1069,"context_line":"        self.assertEqual(instance.vm_state, vm_states.ERROR)"},{"line_number":1070,"context_line":"        mock_get.asser_called_once_with(self.context, uuids.image,"},{"line_number":1071,"context_line":"                                        show_deleted\u003dFalse)"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    def test_unshelve_offloaded_instance_image_id_is_none(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d1a431bc","line":1070,"range":{"start_line":1070,"start_character":17,"end_line":1070,"end_character":39},"in_reply_to":"5f7c97a3_2c69908a","updated":"2018-05-17 22:14:54.000000000","message":"Done. Thanks.","commit_id":"5a237462e61e41e2d1b5d3e0a1834bdb87ffd618"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6470a309bc84583628d4896ddef3b7de9bb59de4","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"            self.conductor_manager.unshelve_instance,"},{"line_number":1068,"context_line":"            self.context, instance)"},{"line_number":1069,"context_line":"        self.assertEqual(instance.vm_state, vm_states.ERROR)"},{"line_number":1070,"context_line":"        mock_get.asser_called_once_with(self.context, uuids.image,"},{"line_number":1071,"context_line":"                                        show_deleted\u003dFalse)"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    def test_unshelve_offloaded_instance_image_id_is_none(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_2c69908a","line":1070,"range":{"start_line":1070,"start_character":17,"end_line":1070,"end_character":39},"in_reply_to":"5f7c97a3_575a5e83","updated":"2018-05-17 17:03:03.000000000","message":"Oh, nice catch","commit_id":"5a237462e61e41e2d1b5d3e0a1834bdb87ffd618"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0ef055d2e7896ac4ba384237d405ef0b3e8db7af","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        timeouts \u003d []"},{"line_number":314,"context_line":"        calls \u003d dict(count\u003d0)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        def fake_ping(self, context, message, timeout):"},{"line_number":317,"context_line":"            timeouts.append(timeout)"},{"line_number":318,"context_line":"            calls[\u0027count\u0027] +\u003d 1"},{"line_number":319,"context_line":"            if calls[\u0027count\u0027] \u003c 15:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ce5f47e3","line":316,"range":{"start_line":316,"start_character":22,"end_line":316,"end_character":28},"updated":"2018-06-08 15:56:38.000000000","message":"Why was \u0027self\u0027 required here","commit_id":"fbf82b6bd01cad7f2e036e37cd891983afe5f1db"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0ef055d2e7896ac4ba384237d405ef0b3e8db7af","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        self.context \u003d FakeContext(self.user_id, self.project_id)"},{"line_number":336,"context_line":"        fake_server_actions.stub_out_action_events(self)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        def fake_deserialize_context(serializer, ctxt_dict):"},{"line_number":339,"context_line":"            self.assertEqual(self.context.user_id, ctxt_dict[\u0027user_id\u0027])"},{"line_number":340,"context_line":"            self.assertEqual(self.context.project_id, ctxt_dict[\u0027project_id\u0027])"},{"line_number":341,"context_line":"            return self.context"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ee6483bb","line":338,"updated":"2018-06-08 15:56:38.000000000","message":"But not here?","commit_id":"fbf82b6bd01cad7f2e036e37cd891983afe5f1db"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d4bcf0ff688706830a2ad67c0bd153527a9f748f","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        fake_server_actions.stub_out_action_events(self)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        def fake_deserialize_context(serializer, ctxt_dict):"},{"line_number":339,"context_line":"            self.assertEqual(self.context.user_id, ctxt_dict[\u0027user_id\u0027])"},{"line_number":340,"context_line":"            self.assertEqual(self.context.project_id, ctxt_dict[\u0027project_id\u0027])"},{"line_number":341,"context_line":"            return self.context"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_4b7a1724","line":339,"range":{"start_line":339,"start_character":12,"end_line":339,"end_character":28},"updated":"2018-06-12 00:38:20.000000000","message":"The signature of \u0027deserialize_context\u0027 is as follows:\n\n  def deserialize_context(self, context):\n\nhttps://github.com/openstack/nova/blob/80dacb2610c16d0f044c30a8ef342971ffa75aab/nova/rpc.py#L140-L141\n\nThe \u0027self\u0027 is changed to \u0027serializer\u0027 because \u0027self\u0027 is used in the \u0027fake_deserialize_context\u0027 method\n(self.assertEqual and self.context).","commit_id":"fbf82b6bd01cad7f2e036e37cd891983afe5f1db"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"701902aff2027e07b7ac4ae08cd485b3903ad61e","unresolved":false,"context_lines":[{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"    @mock.patch.object(compute_rpcapi.ComputeAPI, \u0027unshelve_instance\u0027)"},{"line_number":1204,"context_line":"    @mock.patch.object(conductor_manager.ComputeTaskManager,"},{"line_number":1205,"context_line":"                       \u0027_schedule_instances\u0027, return_value\u003d[["},{"line_number":1206,"context_line":"                           objects.Selection(service_host\u003d\u0027fake_host\u0027,"},{"line_number":1207,"context_line":"                                             nodename\u003d\u0027fake_node\u0027,"},{"line_number":1208,"context_line":"                                             limits\u003dNone)]])"},{"line_number":1209,"context_line":"    @mock.patch.object(scheduler_utils, \u0027build_request_spec\u0027,"},{"line_number":1210,"context_line":"                       return_value\u003d\u0027req_spec\u0027)"},{"line_number":1211,"context_line":"    @mock.patch.object(objects.InstanceMapping, \u0027get_by_instance_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_05037e11","line":1208,"range":{"start_line":1205,"start_character":46,"end_line":1208,"end_character":60},"updated":"2018-06-26 14:50:52.000000000","message":"probably would have been better keep this in the function body - it\u0027s a tad long for here","commit_id":"bcc112f789c27510cc22b47b796c880664704cfb"}]}