)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"04fb9d171d3dd5c684fd1751f5a9efdafd3fba30","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1324,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1325,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1326,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1327,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1328,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1329,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_214749bf","line":1327,"range":{"start_line":1326,"start_character":49,"end_line":1327,"end_character":47},"updated":"2018-04-28 15:29:07.000000000","message":"When do we stop supporting migrations to an ocata host?  It sounds like at that point we would actually change this to delete the allocations, yes?","commit_id":"ceeac0307450d9ea41f71ef1d616c6ffe832a67f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf45c7198798e1749b67c17500a4286ad99213e4","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1324,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1325,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1326,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1327,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1328,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1329,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b9e6fc43","line":1327,"range":{"start_line":1326,"start_character":49,"end_line":1327,"end_character":47},"in_reply_to":"9f6a8fd7_214749bf","updated":"2018-05-08 22:28:12.000000000","message":"If we get here, we probably missed deleting allocations in some failure scenario and it\u0027s a bug we should fix in that spot.","commit_id":"ceeac0307450d9ea41f71ef1d616c6ffe832a67f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"715dd3c7839747ef2020aedf76d16d8064fe62b2","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1327,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1328,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1329,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1331,"context_line":"                # situation here for debugging information but don\u0027t attempt to"},{"line_number":1332,"context_line":"                # delete or change the allocation."},{"line_number":1333,"context_line":"                LOG.warning(\"Instance %s has been moved to another host %s(%s). \""},{"line_number":1334,"context_line":"                            \"There are allocations remaining against the source \""},{"line_number":1335,"context_line":"                            \"host that might need to be removed: %s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_d0edf98b","line":1332,"range":{"start_line":1329,"start_character":68,"end_line":1332,"end_character":49},"updated":"2018-04-28 06:14:58.000000000","message":"the comments here need to be modified as well\n\nand seems here it mentioned no action needed , just a normal situation (I guess allocation will be deleted later from comments? )","commit_id":"ceeac0307450d9ea41f71ef1d616c6ffe832a67f"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"6abcd4946137f67a2ef0c5c8f0a56a3ac53622fb","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1327,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1328,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1329,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1331,"context_line":"                # situation here for debugging information but don\u0027t attempt to"},{"line_number":1332,"context_line":"                # delete or change the allocation."},{"line_number":1333,"context_line":"                LOG.warning(\"Instance %s has been moved to another host %s(%s). \""},{"line_number":1334,"context_line":"                            \"There are allocations remaining against the source \""},{"line_number":1335,"context_line":"                            \"host that might need to be removed: %s.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_a13fd985","line":1332,"range":{"start_line":1329,"start_character":68,"end_line":1332,"end_character":49},"in_reply_to":"9f6a8fd7_d0edf98b","updated":"2018-04-28 13:48:54.000000000","message":"As you will note from the the bug report (and hopefully the commit message), this is *not* always just a normal situation. This is a situation that can result in real problems, and the current lack of error reporting can make it very difficult for an operator to diagnose and correct the situation.","commit_id":"ceeac0307450d9ea41f71ef1d616c6ffe832a67f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"0f89fb0c62e5d7bd8cb2d89d93add8e8b25561f8","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1331,"context_line":"                # situation here for debugging information but don\u0027t attempt to"},{"line_number":1332,"context_line":"                # delete or change the allocation."},{"line_number":1333,"context_line":"                LOG.warning(\"Instance %s has been moved to another host %s(%s). \""},{"line_number":1334,"context_line":"                            \"There are allocations remaining against the source \""},{"line_number":1335,"context_line":"                            \"host that might need to be removed: %s.\","},{"line_number":1336,"context_line":"                            instance_uuid, instance.host, instance.node, alloc)"},{"line_number":1337,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_703f4db5","line":1334,"range":{"start_line":1333,"start_character":80,"end_line":1334,"end_character":81},"updated":"2018-04-28 02:55:10.000000000","message":"These seems too long","commit_id":"ceeac0307450d9ea41f71ef1d616c6ffe832a67f"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"6abcd4946137f67a2ef0c5c8f0a56a3ac53622fb","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1331,"context_line":"                # situation here for debugging information but don\u0027t attempt to"},{"line_number":1332,"context_line":"                # delete or change the allocation."},{"line_number":1333,"context_line":"                LOG.warning(\"Instance %s has been moved to another host %s(%s). \""},{"line_number":1334,"context_line":"                            \"There are allocations remaining against the source \""},{"line_number":1335,"context_line":"                            \"host that might need to be removed: %s.\","},{"line_number":1336,"context_line":"                            instance_uuid, instance.host, instance.node, alloc)"},{"line_number":1337,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_c1444d1e","line":1334,"range":{"start_line":1333,"start_character":80,"end_line":1334,"end_character":81},"in_reply_to":"9f6a8fd7_703f4db5","updated":"2018-04-28 13:48:54.000000000","message":"Thanks, I\u0027ll correct that.","commit_id":"ceeac0307450d9ea41f71ef1d616c6ffe832a67f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf45c7198798e1749b67c17500a4286ad99213e4","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1324,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1325,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1326,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1327,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1328,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1329,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1330,"context_line":"                # don\u0027t need to do anything in that case. Just log the"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_39f3cc0c","line":1327,"range":{"start_line":1326,"start_character":49,"end_line":1327,"end_character":48},"updated":"2018-05-08 22:28:12.000000000","message":"At this point in Rocky, we don\u0027t expect to have ocata computes cleaning up stale allocations. Just a note to self.","commit_id":"a54e5ed00f98b8536080647e5caa90d556d6e809"}]}