)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"aed5021cd793e65b5dcfe32b7f95e8af3aea03f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     fpxie \u003cfpxie@fiberhome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-11 13:54:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the parameter explain when update a volume attachment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we update a volume attachment in nova api, we use volume_id instead"},{"line_number":10,"context_line":"of attachment_id in params in latest api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5f7c97a3_9a3dad8e","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":40},"updated":"2018-07-20 04:55:13.000000000","message":"Looks good with just a soft nit: s/update/updating as it seems little confusing.","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"f0cd45406800b86144c3ce7f08247ac936605447","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     fpxie \u003cfpxie@fiberhome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-11 13:54:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the parameter explain when update a volume attachment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we update a volume attachment in nova api, we use volume_id instead"},{"line_number":10,"context_line":"of attachment_id in params in latest api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5f7c97a3_5aaab519","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":40},"in_reply_to":"5f7c97a3_9a3dad8e","updated":"2018-08-09 01:04:29.000000000","message":"thanks","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"}],"api-ref/source/os-volume-attachments.inc":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fdd98475fef125e5b71092642bcda9d675cb446d","unresolved":false,"context_lines":[{"line_number":155,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  - server_id: server_id_path"},{"line_number":158,"context_line":"  - attachment_id: attachment_id"},{"line_number":159,"context_line":"  - src_volume_id: volume_id_path"},{"line_number":160,"context_line":"  - dest_volume_id: volumeId_swap"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9f6a8fd7_01abf288","line":158,"range":{"start_line":158,"start_character":4,"end_line":158,"end_character":17},"updated":"2018-05-02 04:32:01.000000000","message":"If you change \u0027attachment_id\u0027 in the URL path, change this parameter (replace it with \u0027src_volume_id\u0027)","commit_id":"ae5d0f3acca2d4b7db3dddf7997b5f9719a61c4e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fdd98475fef125e5b71092642bcda9d675cb446d","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  - server_id: server_id_path"},{"line_number":158,"context_line":"  - attachment_id: attachment_id"},{"line_number":159,"context_line":"  - src_volume_id: volume_id_path"},{"line_number":160,"context_line":"  - dest_volume_id: volumeId_swap"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"**Example Update a volume attachment: JSON request**"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9f6a8fd7_e1ca7e6c","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":17},"updated":"2018-05-02 04:32:01.000000000","message":"It should not be changed.\nIt must match the parameter in the JSON request body.\n\nhttps://github.com/openstack/nova/blob/338a3df403aea4eae344905546e415ab4fe93555/doc/api_samples/os-volumes/update-volume-req.json","commit_id":"ae5d0f3acca2d4b7db3dddf7997b5f9719a61c4e"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  - server_id: server_id_path"},{"line_number":158,"context_line":"  - attachment_id: attachment_id"},{"line_number":159,"context_line":"  - src_volume_id: volume_id_path"},{"line_number":160,"context_line":"  - dest_volume_id: volumeId_swap"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"**Example Update a volume attachment: JSON request**"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9f6a8fd7_4131ea0a","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":17},"in_reply_to":"9f6a8fd7_e1ca7e6c","updated":"2018-07-10 09:22:41.000000000","message":"OK，thanks","commit_id":"ae5d0f3acca2d4b7db3dddf7997b5f9719a61c4e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fdd98475fef125e5b71092642bcda9d675cb446d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  - server_id: server_id_path"},{"line_number":158,"context_line":"  - attachment_id: attachment_id"},{"line_number":159,"context_line":"  - src_volume_id: volume_id_path"},{"line_number":160,"context_line":"  - dest_volume_id: volumeId_swap"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"**Example Update a volume attachment: JSON request**"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9f6a8fd7_a1c48660","line":160,"range":{"start_line":160,"start_character":4,"end_line":160,"end_character":18},"updated":"2018-05-02 04:32:01.000000000","message":"ditto","commit_id":"ae5d0f3acca2d4b7db3dddf7997b5f9719a61c4e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a0dcaac3f1075cfca17c2bfdaf13d9b9cababcc6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Show a detail of a volume attachment"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. rest_method:: GET /servers/{server_id}/os-volume_attachments/{volume_id}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Show a detail of a volume attachment."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9f6a8fd7_ef39053f","line":106,"range":{"start_line":106,"start_character":65,"end_line":106,"end_character":74},"updated":"2018-05-02 08:08:07.000000000","message":"here","commit_id":"68243fea331a1421acc4a9fbb4cba9eb26595dfc"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a0dcaac3f1075cfca17c2bfdaf13d9b9cababcc6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{src_volume_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9f6a8fd7_2f113dad","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"updated":"2018-05-02 08:08:07.000000000","message":"can we follow pattern from above and below (marked as here)","commit_id":"68243fea331a1421acc4a9fbb4cba9eb26595dfc"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{src_volume_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9f6a8fd7_cf5f613f","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"in_reply_to":"9f6a8fd7_2f113dad","updated":"2018-07-10 09:22:41.000000000","message":"ok,thanks","commit_id":"68243fea331a1421acc4a9fbb4cba9eb26595dfc"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a0dcaac3f1075cfca17c2bfdaf13d9b9cababcc6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"Detach a volume from an instance"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. rest_method:: DELETE /servers/{server_id}/os-volume_attachments/{volume_id}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Detach a volume from an instance."},{"line_number":178,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9f6a8fd7_4f14b1a0","line":175,"range":{"start_line":175,"start_character":69,"end_line":175,"end_character":76},"updated":"2018-05-02 08:08:07.000000000","message":"here","commit_id":"68243fea331a1421acc4a9fbb4cba9eb26595dfc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad0edb86c655c7ed247167b172ec55d39b8acc0f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f7c97a3_e85ee010","side":"PARENT","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"updated":"2018-05-08 20:01:41.000000000","message":"I think the idea here was that listing and showing volume attachments on a server returns volumeAttachments and that has an attachment \"id\" field in the response, which is the id of the volume attachment, which is the resource we\u0027re updating. In reality, yes it\u0027s the same as the volume ID:\n\nhttps://github.com/openstack/nova/blob/bbe58eced8d225db3ec1af81f6a3945c74b5e53d/nova/api/openstack/compute/volumes.py#L228","commit_id":"c3c34a301aa644e9b2ea1555483d77ae4049db70"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f7c97a3_e1ad9a31","side":"PARENT","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"in_reply_to":"5f7c97a3_e85ee010","updated":"2018-07-10 09:22:41.000000000","message":"\u0027attachment_id\u0027 would misguide user, I think it is better to use \u0027volume_id\u0027.","commit_id":"c3c34a301aa644e9b2ea1555483d77ae4049db70"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad0edb86c655c7ed247167b172ec55d39b8acc0f","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. note:: This action only valid when the server is in ACTIVE, PAUSED and RESIZED state,"},{"line_number":146,"context_line":"          or a conflict(409) error will be returned."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Normal response codes: 202"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403), itemNotFound(404), conflict(409)"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f7c97a3_a86308b1","line":147,"updated":"2018-05-08 20:01:41.000000000","message":"While you\u0027re updating this, please add this wording since swap volume isn\u0027t something normal users should be using, it\u0027s really only meant as a callback for cinder volume live migration or retype operations and is only supported by the libvirt driver.\n\n\"Policy defaults enable only users with the administrative role to\nperform this operation. Cloud providers can change these permissions\nthrough the ``policy.json`` file.\"","commit_id":"bd377734b56096261c24c217650b0320572685c7"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. note:: This action only valid when the server is in ACTIVE, PAUSED and RESIZED state,"},{"line_number":146,"context_line":"          or a conflict(409) error will be returned."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Normal response codes: 202"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403), itemNotFound(404), conflict(409)"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f7c97a3_41648e22","line":147,"in_reply_to":"5f7c97a3_a86308b1","updated":"2018-07-10 09:22:41.000000000","message":"OK,thank you","commit_id":"bd377734b56096261c24c217650b0320572685c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad0edb86c655c7ed247167b172ec55d39b8acc0f","unresolved":false,"context_lines":[{"line_number":155,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  - server_id: server_id_path"},{"line_number":158,"context_line":"  - volume_id: volume_id_path"},{"line_number":159,"context_line":"  - volumeAttachment: volumeAttachment_put"},{"line_number":160,"context_line":"  - volumeId: volumeId_swap"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f7c97a3_c8bf64f9","line":158,"range":{"start_line":158,"start_character":15,"end_line":158,"end_character":29},"updated":"2018-05-08 20:01:41.000000000","message":"This still doesn\u0027t tell the user much, it just says, \"The unique ID for a volume.\"\n\nSo this is still confusing and we\u0027d be better off with a new parameter and description, something like volume_id_path_swap with a description like, \"The ID of the attached volume from which to swap to the volume identified by the volumeId parameter.\" - something like that anyway.","commit_id":"bd377734b56096261c24c217650b0320572685c7"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":155,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  - server_id: server_id_path"},{"line_number":158,"context_line":"  - volume_id: volume_id_path"},{"line_number":159,"context_line":"  - volumeAttachment: volumeAttachment_put"},{"line_number":160,"context_line":"  - volumeId: volumeId_swap"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5f7c97a3_016e9600","line":158,"range":{"start_line":158,"start_character":15,"end_line":158,"end_character":29},"in_reply_to":"5f7c97a3_c8bf64f9","updated":"2018-07-10 09:22:41.000000000","message":"you are right","commit_id":"bd377734b56096261c24c217650b0320572685c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"db8743c524f9b979dc053f41f81e79ab49afa448","unresolved":false,"context_lines":[{"line_number":159,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  - server_id: server_id_path"},{"line_number":162,"context_line":"  - volume_id: volume_id_swap_src"},{"line_number":163,"context_line":"  - volumeAttachment: volumeAttachment_put"},{"line_number":164,"context_line":"  - volumeId: volumeId_swap"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5f7c97a3_f509d430","line":162,"range":{"start_line":162,"start_character":4,"end_line":162,"end_character":13},"updated":"2018-05-09 07:04:42.000000000","message":"i prefer to mention this as \u0027id\u0027 which is what API code and router mapping expect\n- https://github.com/openstack/nova/blob/2434d597e7de01bacda4936abb8990b92f967328/nova/api/openstack/compute/routes.py#L845\n\nIt does not matter with either name but it is good to be consistent with source code which is always easy to understand.","commit_id":"280dde9d0438d76eeea1a49b53f9e2b7acc8bd84"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":159,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  - server_id: server_id_path"},{"line_number":162,"context_line":"  - volume_id: volume_id_swap_src"},{"line_number":163,"context_line":"  - volumeAttachment: volumeAttachment_put"},{"line_number":164,"context_line":"  - volumeId: volumeId_swap"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5f7c97a3_7064f2b9","line":162,"range":{"start_line":162,"start_character":4,"end_line":162,"end_character":13},"in_reply_to":"5f7c97a3_f509d430","updated":"2018-07-10 09:22:41.000000000","message":"ok","commit_id":"280dde9d0438d76eeea1a49b53f9e2b7acc8bd84"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"677040b733efa135fd622a03ce09d38112ddb78c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Show a detail of a volume attachment"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. rest_method:: GET /servers/{server_id}/os-volume_attachments/{volume_id}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Show a detail of a volume attachment."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_ff0c1ced","line":106,"range":{"start_line":106,"start_character":65,"end_line":106,"end_character":74},"updated":"2018-05-11 05:32:53.000000000","message":"Here","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"677040b733efa135fd622a03ce09d38112ddb78c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_3f07f4cc","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":67},"updated":"2018-05-11 05:32:53.000000000","message":"It should be \u0027volume_id\u0027 because of consistency with line 106 and 179.","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bd9fd332bcf274ee496b326ad726c815ebb0353f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_df54c055","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":67},"in_reply_to":"5f7c97a3_3f07f4cc","updated":"2018-05-11 06:10:22.000000000","message":"actually i asked to change this to \u0027id\u0027 to map it close to what we have in code.\n\nI suggest to change the other API url also to mention \u0027id\u0027 like you mentioned show and delete. \n\n- https://github.com/openstack/nova/blob/c52b645b64acb555202fc4f3c889802f9b495211/nova/api/openstack/compute/routes.py#L845\n\n- https://github.com/openstack/nova/blob/c52b645b64acb555202fc4f3c889802f9b495211/nova/api/openstack/compute/volumes.py#L367","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_0a11c6ac","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":67},"in_reply_to":"5f7c97a3_3f07f4cc","updated":"2018-07-10 09:22:41.000000000","message":"fixed","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_ca22ee01","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":67},"in_reply_to":"5f7c97a3_3f97f4ee","updated":"2018-07-10 09:22:41.000000000","message":"right","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fc1521758861ec86e20ba08029ad3006884c8335","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_3f97f4ee","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":67},"in_reply_to":"5f7c97a3_df54c055","updated":"2018-05-11 06:21:05.000000000","message":"But the API reference is used by users.\nIMO, the \u0027volume_id\u0027 is easier to understand for users than \u0027id\u0027.","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"677040b733efa135fd622a03ce09d38112ddb78c","unresolved":false,"context_lines":[{"line_number":159,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  - server_id: server_id_path"},{"line_number":162,"context_line":"  - id: volume_id_swap_src"},{"line_number":163,"context_line":"  - volumeAttachment: volumeAttachment_put"},{"line_number":164,"context_line":"  - volumeId: volumeId_swap"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_5f0c30ec","line":162,"range":{"start_line":162,"start_character":4,"end_line":162,"end_character":6},"updated":"2018-05-11 05:32:53.000000000","message":"ditto","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"677040b733efa135fd622a03ce09d38112ddb78c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Detach a volume from an instance"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. rest_method:: DELETE /servers/{server_id}/os-volume_attachments/{volume_id}"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Detach a volume from an instance."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"5f7c97a3_bffa24ba","line":179,"range":{"start_line":179,"start_character":68,"end_line":179,"end_character":77},"updated":"2018-05-11 05:32:53.000000000","message":"Here","commit_id":"506df47dc94a0cf0c6c91dadd6c370e4ab6dbfcf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e66fda583b43e9fe527afd099e4ab0a8dad80c7b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Show a detail of a volume attachment"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. rest_method:: GET /servers/{server_id}/os-volume_attachments/{volume_id}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Show a detail of a volume attachment."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f79a3b5_0ef495ce","line":106,"range":{"start_line":106,"start_character":17,"end_line":106,"end_character":75},"updated":"2018-08-08 13:45:26.000000000","message":"Matches this so looks good.","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e66fda583b43e9fe527afd099e4ab0a8dad80c7b","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/volume-attachment-detail-resp.json"},{"line_number":136,"context_line":"   :language: javascript"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{volume_id}"}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f79a3b5_ce99bd79","line":138,"updated":"2018-08-08 13:45:26.000000000","message":"This is also only implemented by the libvirt driver so we could have linked to https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_swap_volume but that could be done later if we care.","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e66fda583b43e9fe527afd099e4ab0a8dad80c7b","unresolved":false,"context_lines":[{"line_number":145,"context_line":".. note:: This action only valid when the server is in ACTIVE, PAUSED and RESIZED state,"},{"line_number":146,"context_line":"          or a conflict(409) error will be returned."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Policy defaults enable only users with the administrative role or"},{"line_number":149,"context_line":"the owner of the server to perform this operation. Cloud providers"},{"line_number":150,"context_line":"can change these permissions through the ``policy.json`` file."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":12,"id":"3f79a3b5_2e287132","line":148,"updated":"2018-08-08 13:45:26.000000000","message":"Nice add, thanks.","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fb3fc85244dcec02fedd30d83ebce6324bdf7336","unresolved":false,"context_lines":[{"line_number":6487,"context_line":"  in: body"},{"line_number":6488,"context_line":"  required: true"},{"line_number":6489,"context_line":"  type: string"},{"line_number":6490,"context_line":"volumeId_dest:"},{"line_number":6491,"context_line":"  description: |"},{"line_number":6492,"context_line":"    ID of the destination volume."},{"line_number":6493,"context_line":"  in: body"},{"line_number":6494,"context_line":"  required: true"},{"line_number":6495,"context_line":"  type: string"},{"line_number":6496,"context_line":"volumeId_src:"},{"line_number":6497,"context_line":"  description: |"},{"line_number":6498,"context_line":"    ID of the source (original) volume."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_78a88276","line":6495,"range":{"start_line":6490,"start_character":0,"end_line":6495,"end_character":14},"updated":"2018-04-30 13:35:01.000000000","message":"The build wants these in alpha order.  This one has to go above volumeId_resp.","commit_id":"3972ba2a91676094e59580baaa4a7794b97b8b37"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a4c0fabc6573e0b19d421c718663ae9155da0f2e","unresolved":false,"context_lines":[{"line_number":339,"context_line":"  type: string"},{"line_number":340,"context_line":"volume_id_swap_src:"},{"line_number":341,"context_line":"  description: |"},{"line_number":342,"context_line":"    The UUID of the source volume when swap."},{"line_number":343,"context_line":"  in: path"},{"line_number":344,"context_line":"  required: true"},{"line_number":345,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f7c97a3_d4d611c4","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":44},"updated":"2018-05-09 14:01:25.000000000","message":"\"when swapping\" would be grammatically correct.\n\nBut I\u0027m not sure we should be using the term \"swap\" at all here.  The doc for the new volume says:\n\n\"The UUID of the volume to attach instead of the attached volume.\"\n\n...which also isn\u0027t the greatest.  But perhaps this one should be reworded to avoid the term \"swap\", which is loaded with connotations we don\u0027t necessarily want to bring in.  Perhaps:\n\n\"The UUID of the volume being replaced.\"\n\n?  Matt, what do you think?","commit_id":"03dd64f81bdd5f781b87e98f5a3ed7d929efb033"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"05a1bd16fb9eed8eacc5e41f3a3d0c57049ed0b1","unresolved":false,"context_lines":[{"line_number":339,"context_line":"  type: string"},{"line_number":340,"context_line":"volume_id_swap_src:"},{"line_number":341,"context_line":"  description: |"},{"line_number":342,"context_line":"    The UUID of the source volume when swap."},{"line_number":343,"context_line":"  in: path"},{"line_number":344,"context_line":"  required: true"},{"line_number":345,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f7c97a3_4731e3eb","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":44},"in_reply_to":"5f7c97a3_d4d611c4","updated":"2018-07-10 09:22:41.000000000","message":"\"The UUID of the source volume that would be replaced when swapping.\"\nhow about this?\n\nThe purpose of this explanation is to let the user know which parameter to use here. If this achieved, the explanation is ok.","commit_id":"03dd64f81bdd5f781b87e98f5a3ed7d929efb033"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e66fda583b43e9fe527afd099e4ab0a8dad80c7b","unresolved":false,"context_lines":[{"line_number":339,"context_line":"  type: string"},{"line_number":340,"context_line":"volume_id_swap_src:"},{"line_number":341,"context_line":"  description: |"},{"line_number":342,"context_line":"    TThe UUID of the volume being replaced."},{"line_number":343,"context_line":"  in: path"},{"line_number":344,"context_line":"  required: true"},{"line_number":345,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_eee6f916","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":8},"updated":"2018-08-08 13:45:26.000000000","message":"The","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e66fda583b43e9fe527afd099e4ab0a8dad80c7b","unresolved":false,"context_lines":[{"line_number":6472,"context_line":"# This is the volumeAttachment in a PUT (swap volume) request body."},{"line_number":6473,"context_line":"volumeAttachment_put:"},{"line_number":6474,"context_line":"  description: |"},{"line_number":6475,"context_line":"    A dictionary representation of a volume attachment containing the field"},{"line_number":6476,"context_line":"    ``volumeId``."},{"line_number":6477,"context_line":"  in: body"},{"line_number":6478,"context_line":"  required: true"},{"line_number":6479,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_6ea189a9","line":6476,"range":{"start_line":6475,"start_character":4,"end_line":6476,"end_character":17},"updated":"2018-08-08 13:45:26.000000000","message":"I would update this to mention, this is the volume being swapped to.","commit_id":"ceac2f696065cb16d829a9faf110bd92e9cc6cd9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"824ceafde71782f2c7e01277d57312c9255ffb9c","unresolved":false,"context_lines":[{"line_number":343,"context_line":"  in: path"},{"line_number":344,"context_line":"  required: true"},{"line_number":345,"context_line":"  type: string"},{"line_number":346,"context_line":"volume_id_to_detach_path:"},{"line_number":347,"context_line":"  description: |"},{"line_number":348,"context_line":"    The UUID of the volume to detach."},{"line_number":349,"context_line":"  in: path"},{"line_number":350,"context_line":"  required: true"},{"line_number":351,"context_line":"  type: string"},{"line_number":352,"context_line":"volume_id_swap_src:"},{"line_number":353,"context_line":"  description: |"},{"line_number":354,"context_line":"    The UUID of the volume being replaced."},{"line_number":355,"context_line":"  in: path"},{"line_number":356,"context_line":"  required: true"},{"line_number":357,"context_line":"  type: string"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# variables in query"},{"line_number":360,"context_line":"access_ip_v4_query_server:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_3f3baeeb","line":357,"range":{"start_line":346,"start_character":0,"end_line":357,"end_character":14},"updated":"2018-08-09 02:44:28.000000000","message":"order of these causing api-ref fail.\n\n- http://logs.openstack.org/81/565181/14/check/build-openstack-api-ref/266a402/job-output.txt.gz#_2018-08-08_14_31_31_594398","commit_id":"cdcad81e0f0709f2917a09b163e768d2a1ee641a"}]}