)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"incompatibility between Linux\u0027s `perf` infrastructure and Intel CMT"},{"line_number":13,"context_line":"hardware support.  It was removed in upstream kernel version v4.14; but"},{"line_number":14,"context_line":"bear in mind that downstream Linux distributions with lower kernel"},{"line_number":15,"context_line":"versions than 4.14 have backported the said change[*]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Nova supports monitoring of the above mentioned Intel CMT events"},{"line_number":18,"context_line":"(namely: \u0027cmt\u0027, \u0027mbm_local\u0027, and \u0027mbm_total\u0027) via the configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_d334304d","line":15,"range":{"start_line":15,"start_character":50,"end_line":15,"end_character":53},"updated":"2018-05-04 19:53:30.000000000","message":"Is this supposed to link to something else? Like fedora/ubuntu/suse/centos/other?","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"351a311ba02fa51b08611dd6b8a57b08f3f3b1dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"incompatibility between Linux\u0027s `perf` infrastructure and Intel CMT"},{"line_number":13,"context_line":"hardware support.  It was removed in upstream kernel version v4.14; but"},{"line_number":14,"context_line":"bear in mind that downstream Linux distributions with lower kernel"},{"line_number":15,"context_line":"versions than 4.14 have backported the said change[*]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Nova supports monitoring of the above mentioned Intel CMT events"},{"line_number":18,"context_line":"(namely: \u0027cmt\u0027, \u0027mbm_local\u0027, and \u0027mbm_total\u0027) via the configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_9f40e437","line":15,"range":{"start_line":15,"start_character":50,"end_line":15,"end_character":53},"in_reply_to":"5f7c97a3_d334304d","updated":"2018-05-07 15:16:35.000000000","message":"Not really; I just tried to be again precise what the \"said change\" is, so I linked to the Linux kernel commit.  Pointing to distributions will quickly make it unwieldy, as you have to link to many URLs.","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"(namely: \u0027cmt\u0027, \u0027mbm_local\u0027, and \u0027mbm_total\u0027) via the configuration"},{"line_number":19,"context_line":"attribute `[libvirt]/enabled_perf_events`.  Given that the underlying"},{"line_number":20,"context_line":"Linux kernel infrastructure for Intel CMT is removed, we should remove"},{"line_number":21,"context_line":"for it in Nova too.  Otherwise enabling them in Nova, and updating to a"},{"line_number":22,"context_line":"Linux kernel 4.14 (or above) will result in instances failing to boot."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So remove support for the three Intel CMT events.  Note that we cannot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_933eb827","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":3},"updated":"2018-05-04 19:53:30.000000000","message":"s/for//","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c60a05121f53ccdb8f832aa4225a58e8d74cf996","unresolved":false,"context_lines":[{"line_number":18,"context_line":"(namely: \u0027cmt\u0027, \u0027mbm_local\u0027, and \u0027mbm_total\u0027) via the configuration"},{"line_number":19,"context_line":"attribute `[libvirt]/enabled_perf_events`. Given that the underlying"},{"line_number":20,"context_line":"Linux kernel infrastructure for Intel CMT is removed, we should remove"},{"line_number":21,"context_line":"for it in Nova too.  Otherwise enabling them in Nova, and updating to a"},{"line_number":22,"context_line":"Linux kernel 4.14 (or above) will result in instances failing to boot."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"To that end, deprecate support for the three Intel CMT events in \"Rocky\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_31b212e8","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":3},"updated":"2018-05-08 13:23:11.000000000","message":"s/for//\n\nor\n\nwe should remove support for it in Nova too.","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"}],"nova/conf/libvirt.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":680,"context_line":"               default\u003d[],"},{"line_number":681,"context_line":"               help\u003d \"\"\""},{"line_number":682,"context_line":"This will allow you to specify a list events to monitor low-level"},{"line_number":683,"context_line":"performance of guests, and collect related statsitics via the libvirt,"},{"line_number":684,"context_line":"which inturn uses the Linux kernel\u0027s `perf` infrstructure.  With this"},{"line_number":685,"context_line":"config attribute set, Nova will generate libvirt guest XML to monitor"},{"line_number":686,"context_line":"the specified events.  For more information, refer the \"Performance"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b324140f","line":683,"range":{"start_line":683,"start_character":58,"end_line":683,"end_character":69},"updated":"2018-05-04 19:53:30.000000000","message":"the libvirt...what? driver? hypervisor?","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"351a311ba02fa51b08611dd6b8a57b08f3f3b1dc","unresolved":false,"context_lines":[{"line_number":680,"context_line":"               default\u003d[],"},{"line_number":681,"context_line":"               help\u003d \"\"\""},{"line_number":682,"context_line":"This will allow you to specify a list events to monitor low-level"},{"line_number":683,"context_line":"performance of guests, and collect related statsitics via the libvirt,"},{"line_number":684,"context_line":"which inturn uses the Linux kernel\u0027s `perf` infrstructure.  With this"},{"line_number":685,"context_line":"config attribute set, Nova will generate libvirt guest XML to monitor"},{"line_number":686,"context_line":"the specified events.  For more information, refer the \"Performance"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1f7614a6","line":683,"range":{"start_line":683,"start_character":58,"end_line":683,"end_character":69},"in_reply_to":"5f7c97a3_b324140f","updated":"2018-05-07 15:16:35.000000000","message":"Oops, broken sentence; I indeed meant: \"the libvirt driver\".","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":681,"context_line":"               help\u003d \"\"\""},{"line_number":682,"context_line":"This will allow you to specify a list events to monitor low-level"},{"line_number":683,"context_line":"performance of guests, and collect related statsitics via the libvirt,"},{"line_number":684,"context_line":"which inturn uses the Linux kernel\u0027s `perf` infrstructure.  With this"},{"line_number":685,"context_line":"config attribute set, Nova will generate libvirt guest XML to monitor"},{"line_number":686,"context_line":"the specified events.  For more information, refer the \"Performance"},{"line_number":687,"context_line":"monitoring events\" section here:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_137948fb","line":684,"range":{"start_line":684,"start_character":6,"end_line":684,"end_character":12},"updated":"2018-05-04 19:53:30.000000000","message":"in turn","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":681,"context_line":"               help\u003d \"\"\""},{"line_number":682,"context_line":"This will allow you to specify a list events to monitor low-level"},{"line_number":683,"context_line":"performance of guests, and collect related statsitics via the libvirt,"},{"line_number":684,"context_line":"which inturn uses the Linux kernel\u0027s `perf` infrstructure.  With this"},{"line_number":685,"context_line":"config attribute set, Nova will generate libvirt guest XML to monitor"},{"line_number":686,"context_line":"the specified events.  For more information, refer the \"Performance"},{"line_number":687,"context_line":"monitoring events\" section here:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d382f0c8","line":684,"range":{"start_line":684,"start_character":44,"end_line":684,"end_character":57},"updated":"2018-05-04 19:53:30.000000000","message":"infrastructure","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":700,"context_line":""},{"line_number":701,"context_line":"Note that upstream Linux kernel (from 4.14 onwards) has deleted support"},{"line_number":702,"context_line":"for the three Intel CMT events (`cmt`, `mbmbt`, `mbml`), because it\u0027s"},{"line_number":703,"context_line":"broken by design, therefore its support is *removed* from Nova."},{"line_number":704,"context_line":"\"\"\"),"},{"line_number":705,"context_line":"    cfg.IntOpt(\u0027num_pcie_ports\u0027,"},{"line_number":706,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_3367a450","line":703,"range":{"start_line":703,"start_character":28,"end_line":703,"end_character":39},"updated":"2018-05-04 19:53:30.000000000","message":"\"Nova does not support those three specific events.\"\n\nWe don\u0027t need to say \"is removed\" in a config option - that wouldn\u0027t make sense 2 years from now. It\u0027s release note information.","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c60a05121f53ccdb8f832aa4225a58e8d74cf996","unresolved":false,"context_lines":[{"line_number":685,"context_line":"libvirt version is 2.0.0. For more information about `Performance monitoring"},{"line_number":686,"context_line":"events`, refer https://libvirt.org/formatdomain.html#elementsPerf ."},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"Possible values:"},{"line_number":689,"context_line":"* A string list. For example: ``enabled_perf_events \u003d cmt, mbml, mbmt``"},{"line_number":690,"context_line":"  The supported events list can be found in"},{"line_number":691,"context_line":"  https://libvirt.org/html/libvirt-libvirt-domain.html ,"},{"line_number":692,"context_line":"  which you may need to search key words ``VIR_PERF_PARAM_*``"},{"line_number":693,"context_line":"\"\"\"),"},{"line_number":694,"context_line":"    cfg.IntOpt(\u0027num_pcie_ports\u0027,"},{"line_number":695,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_51030e74","line":692,"range":{"start_line":688,"start_character":0,"end_line":692,"end_character":61},"updated":"2018-05-08 13:23:11.000000000","message":"This should be updated - we shouldn\u0027t give the example using the things we are deprecating, and you should also probably include the note from PS4 about those 3 specifically being deprecated and unsafe.","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"7ccccc3a94a17ec8519b64bc213c42501e8234f1","unresolved":false,"context_lines":[{"line_number":685,"context_line":"libvirt version is 2.0.0. For more information about `Performance monitoring"},{"line_number":686,"context_line":"events`, refer https://libvirt.org/formatdomain.html#elementsPerf ."},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"Possible values:"},{"line_number":689,"context_line":"* A string list. For example: ``enabled_perf_events \u003d cmt, mbml, mbmt``"},{"line_number":690,"context_line":"  The supported events list can be found in"},{"line_number":691,"context_line":"  https://libvirt.org/html/libvirt-libvirt-domain.html ,"},{"line_number":692,"context_line":"  which you may need to search key words ``VIR_PERF_PARAM_*``"},{"line_number":693,"context_line":"\"\"\"),"},{"line_number":694,"context_line":"    cfg.IntOpt(\u0027num_pcie_ports\u0027,"},{"line_number":695,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_5449bc88","line":692,"range":{"start_line":688,"start_character":0,"end_line":692,"end_character":61},"in_reply_to":"5f7c97a3_51030e74","updated":"2018-05-08 14:10:09.000000000","message":"Ah, damn.  I forgot to update that.","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    cfg.ListOpt(\u0027enabled_perf_events\u0027,"},{"line_number":697,"context_line":"               default\u003d[],"},{"line_number":698,"context_line":"               help\u003d \"\"\""},{"line_number":699,"context_line":"This will allow you to specify a list events to monitor low-level"},{"line_number":700,"context_line":"performance of guests, and collect related statsitics via the libvirt"},{"line_number":701,"context_line":"driver, which in turn uses the Linux kernel\u0027s `perf` infrstructure."},{"line_number":702,"context_line":"With this config attribute set, Nova will generate libvirt guest XML to"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_98dbe7eb","line":699,"range":{"start_line":699,"start_character":38,"end_line":699,"end_character":44},"updated":"2018-05-09 16:51:33.000000000","message":"of events","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":698,"context_line":"               help\u003d \"\"\""},{"line_number":699,"context_line":"This will allow you to specify a list events to monitor low-level"},{"line_number":700,"context_line":"performance of guests, and collect related statsitics via the libvirt"},{"line_number":701,"context_line":"driver, which in turn uses the Linux kernel\u0027s `perf` infrstructure."},{"line_number":702,"context_line":"With this config attribute set, Nova will generate libvirt guest XML to"},{"line_number":703,"context_line":"monitor the specified events.  For more information, refer the"},{"line_number":704,"context_line":"\"Performance monitoring events\" section here:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_78e04b97","line":701,"range":{"start_line":701,"start_character":53,"end_line":701,"end_character":66},"updated":"2018-05-09 16:51:33.000000000","message":"infrastructure","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":700,"context_line":"performance of guests, and collect related statsitics via the libvirt"},{"line_number":701,"context_line":"driver, which in turn uses the Linux kernel\u0027s `perf` infrstructure."},{"line_number":702,"context_line":"With this config attribute set, Nova will generate libvirt guest XML to"},{"line_number":703,"context_line":"monitor the specified events.  For more information, refer the"},{"line_number":704,"context_line":"\"Performance monitoring events\" section here:"},{"line_number":705,"context_line":"https://libvirt.org/formatdomain.html#elementsPerf.  And here:"},{"line_number":706,"context_line":"https://libvirt.org/html/libvirt-libvirt-domain.html -- look for"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_18f1176c","line":703,"range":{"start_line":703,"start_character":59,"end_line":703,"end_character":62},"updated":"2018-05-09 16:51:33.000000000","message":"to the","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":709,"context_line":"For example, to monitor the count of CPU cycles (total/elapsed) and the"},{"line_number":710,"context_line":"count of cache misses, enable them as follows::"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"Possible values:"},{"line_number":713,"context_line":"* A string list. For example: ``enabled_perf_events \u003d cmt, mbml, mbmt``"},{"line_number":714,"context_line":"  The supported events list can be found in"},{"line_number":715,"context_line":"  https://libvirt.org/html/libvirt-libvirt-domain.html ,"},{"line_number":716,"context_line":"  which you may need to search key words ``VIR_PERF_PARAM_*``"},{"line_number":717,"context_line":"    [libvirt]"},{"line_number":718,"context_line":"    enabled_perf_events \u003d cpu_clock, cache_misses"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_f8ed3b8b","line":716,"range":{"start_line":712,"start_character":0,"end_line":716,"end_character":61},"updated":"2018-05-09 16:51:33.000000000","message":"I think you forgot to remove this.","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"cb4764a7e7ce121ce51fd0b7e98abae2171e9de2","unresolved":false,"context_lines":[{"line_number":709,"context_line":"For example, to monitor the count of CPU cycles (total/elapsed) and the"},{"line_number":710,"context_line":"count of cache misses, enable them as follows::"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"Possible values:"},{"line_number":713,"context_line":"* A string list. For example: ``enabled_perf_events \u003d cmt, mbml, mbmt``"},{"line_number":714,"context_line":"  The supported events list can be found in"},{"line_number":715,"context_line":"  https://libvirt.org/html/libvirt-libvirt-domain.html ,"},{"line_number":716,"context_line":"  which you may need to search key words ``VIR_PERF_PARAM_*``"},{"line_number":717,"context_line":"    [libvirt]"},{"line_number":718,"context_line":"    enabled_perf_events \u003d cpu_clock, cache_misses"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_6cf964c6","line":716,"range":{"start_line":712,"start_character":0,"end_line":716,"end_character":61},"in_reply_to":"5f7c97a3_f8ed3b8b","updated":"2018-05-09 23:24:16.000000000","message":"Darn, yes bad copy / paste.  Will fix it.","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":721,"context_line":"found here: https://libvirt.org/formatdomain.html#elementsPerf."},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"Note that support for Intel CMT events (`cmt`, `mbmbt`, `mbml`) is"},{"line_number":724,"context_line":"deprecated, and will be removed in \"Stein\" release.  That\u0027s because that"},{"line_number":725,"context_line":"upstream Linux kernel (from 4.14 onwards) has deleted support for Intel"},{"line_number":726,"context_line":"CMT, because it is broken by design."},{"line_number":727,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_9804474c","line":724,"range":{"start_line":724,"start_character":32,"end_line":724,"end_character":34},"updated":"2018-05-09 16:51:33.000000000","message":"in the","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":721,"context_line":"found here: https://libvirt.org/formatdomain.html#elementsPerf."},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"Note that support for Intel CMT events (`cmt`, `mbmbt`, `mbml`) is"},{"line_number":724,"context_line":"deprecated, and will be removed in \"Stein\" release.  That\u0027s because that"},{"line_number":725,"context_line":"upstream Linux kernel (from 4.14 onwards) has deleted support for Intel"},{"line_number":726,"context_line":"CMT, because it is broken by design."},{"line_number":727,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_78f92b4b","line":724,"range":{"start_line":724,"start_character":68,"end_line":724,"end_character":72},"updated":"2018-05-09 16:51:33.000000000","message":"the","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"500db1552007e836447223e50061ce164c031270","unresolved":false,"context_lines":[{"line_number":716,"context_line":"found here: https://libvirt.org/formatdomain.html#elementsPerf."},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"Note that support for Intel CMT events (`cmt`, `mbmbt`, `mbml`) is"},{"line_number":719,"context_line":"deprecated, and will be removed in \"Stein\" release.  That\u0027s because that"},{"line_number":720,"context_line":"upstream Linux kernel (from 4.14 onwards) has deleted support for Intel"},{"line_number":721,"context_line":"CMT, because it is broken by design."},{"line_number":722,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ab0f5d86","line":719,"range":{"start_line":719,"start_character":32,"end_line":719,"end_character":34},"updated":"2018-05-24 23:19:10.000000000","message":"in the","commit_id":"30f0d46a46c32c4171ac444db0114c24dcaf464e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"500db1552007e836447223e50061ce164c031270","unresolved":false,"context_lines":[{"line_number":716,"context_line":"found here: https://libvirt.org/formatdomain.html#elementsPerf."},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"Note that support for Intel CMT events (`cmt`, `mbmbt`, `mbml`) is"},{"line_number":719,"context_line":"deprecated, and will be removed in \"Stein\" release.  That\u0027s because that"},{"line_number":720,"context_line":"upstream Linux kernel (from 4.14 onwards) has deleted support for Intel"},{"line_number":721,"context_line":"CMT, because it is broken by design."},{"line_number":722,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_8b7f01de","line":719,"range":{"start_line":719,"start_character":68,"end_line":719,"end_character":72},"updated":"2018-05-24 23:19:10.000000000","message":"the","commit_id":"30f0d46a46c32c4171ac444db0114c24dcaf464e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"58b88ce87a65e30ed50d886b671c9bc4a51b3c40","unresolved":false,"context_lines":[{"line_number":6620,"context_line":""},{"line_number":6621,"context_line":"        self._test_get_guest_with_perf(caps, [\u0027cmt\u0027, \u0027mbml\u0027, \u0027mbmt\u0027])"},{"line_number":6622,"context_line":""},{"line_number":6623,"context_line":"        mock_warn.assert_called_once_with("},{"line_number":6624,"context_line":"                \u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":6625,"context_line":"                \u0027deprecated and will be removed in the \"Stein\" \u0027"},{"line_number":6626,"context_line":"                \u0027release.  It was broken by design in the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_db7727d4","line":6623,"range":{"start_line":6623,"start_character":18,"end_line":6623,"end_character":41},"updated":"2018-05-09 09:11:24.000000000","message":"This is called multiple times. You just want to make sure it was called at least once with this, so maybe use \u0027assert_any_call\u0027 [1]. Alternatively, you\u0027re enabling multiple deprecated events here, so perhaps check for each of them using \u0027assert_has_calls\u0027 [2]?\n\nNote that you don\u0027t need to check the _whole_ warning message here, if you wanted to avoid that [3].\n\n[1] https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_any_call\n[2] https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_has_calls\n[3] https://github.com/openstack/nova/blob/bcb405e871a447df57ea420402919a256f5d0be9/nova/tests/unit/compute/test_compute_mgr.py#L2640-L2642","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"4ec2e8abadb12d24d7ff062bd1aa67d2a63403c2","unresolved":false,"context_lines":[{"line_number":6620,"context_line":""},{"line_number":6621,"context_line":"        self._test_get_guest_with_perf(caps, [\u0027cmt\u0027, \u0027mbml\u0027, \u0027mbmt\u0027])"},{"line_number":6622,"context_line":""},{"line_number":6623,"context_line":"        mock_warn.assert_called_once_with("},{"line_number":6624,"context_line":"                \u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":6625,"context_line":"                \u0027deprecated and will be removed in the \"Stein\" \u0027"},{"line_number":6626,"context_line":"                \u0027release.  It was broken by design in the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0a18e67e","line":6623,"range":{"start_line":6623,"start_character":18,"end_line":6623,"end_character":41},"in_reply_to":"5f7c97a3_db7727d4","updated":"2018-05-09 10:12:08.000000000","message":"Hmm, never tried has_calls before.  For now, I\u0027m tinkering with:\n\n    self.assertEqual(N,mock_warn.call_count)\n\nAlthough the test \"passes\".  Wonder if that is sufficient.","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"58b88ce87a65e30ed50d886b671c9bc4a51b3c40","unresolved":false,"context_lines":[{"line_number":6626,"context_line":"                \u0027release.  It was broken by design in the \u0027"},{"line_number":6627,"context_line":"                \u0027Linux kernel, so support for Intel CMT was \u0027"},{"line_number":6628,"context_line":"                \u0027removed from Linux 4.14 onwards. Therefore \u0027"},{"line_number":6629,"context_line":"                \u0027it is recommended to not enable them.\u0027, caps)"},{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"    def test_xml_and_uri_no_ramdisk_no_kernel(self):"},{"line_number":6632,"context_line":"        instance_data \u003d dict(self.test_instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_5b323712","line":6629,"range":{"start_line":6629,"start_character":57,"end_line":6629,"end_character":62},"updated":"2018-05-09 09:11:24.000000000","message":"This isn\u0027t called with caps. It\u0027s called with an event string from the list in CONF.libvirt.enabled_perf_events, so:\n\n  s/caps/\u0027cmt\u0027","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ce1522056fecd3c9848fe34608088159c3d0265","unresolved":false,"context_lines":[{"line_number":6645,"context_line":""},{"line_number":6646,"context_line":"        caps.host.cpu.features \u003d set(features)"},{"line_number":6647,"context_line":"        self._test_get_guest_with_perf(caps, [\u0027cmt\u0027, \u0027mbml\u0027, \u0027mbmt\u0027])"},{"line_number":6648,"context_line":"        self.assertEqual(3, mock_warn.call_count)"},{"line_number":6649,"context_line":""},{"line_number":6650,"context_line":"    def test_xml_and_uri_no_ramdisk_no_kernel(self):"},{"line_number":6651,"context_line":"        instance_data \u003d dict(self.test_instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_3835f3f7","line":6648,"range":{"start_line":6648,"start_character":8,"end_line":6648,"end_character":49},"updated":"2018-05-09 16:51:33.000000000","message":"I\u0027m not crazy about this. If any other new warning shows up in this flow, it\u0027s going to break this (brittle) test.\n\nAs Stephen pointed out in PS5, there are other ways to skin this cat. If you want to make sure warning was called on those 3 events, then you could do something like:\n\nwarning_count \u003d 0\ncall_args_list \u003d mock_warn.call_args_list()\nfor call in call_args_list:\n    # call can be unpackaged as a tuple of args and kwargs\n    # so we want to check the first arg in the args list\n    if \u0027Monitoring Intel CMT `perf` event(s)\u0027 in call[0][0]:\n        warning_count +\u003d 1\nself.assertEqual(3, warning_count)","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"cb4764a7e7ce121ce51fd0b7e98abae2171e9de2","unresolved":false,"context_lines":[{"line_number":6645,"context_line":""},{"line_number":6646,"context_line":"        caps.host.cpu.features \u003d set(features)"},{"line_number":6647,"context_line":"        self._test_get_guest_with_perf(caps, [\u0027cmt\u0027, \u0027mbml\u0027, \u0027mbmt\u0027])"},{"line_number":6648,"context_line":"        self.assertEqual(3, mock_warn.call_count)"},{"line_number":6649,"context_line":""},{"line_number":6650,"context_line":"    def test_xml_and_uri_no_ramdisk_no_kernel(self):"},{"line_number":6651,"context_line":"        instance_data \u003d dict(self.test_instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_4c17c8ee","line":6648,"range":{"start_line":6648,"start_character":8,"end_line":6648,"end_character":49},"in_reply_to":"5f7c97a3_3835f3f7","updated":"2018-05-09 23:24:16.000000000","message":"Yeah, I realized that new warnings will break the test (that\u0027s why I noted on IRC that the test is not \"robust\").  I felt the likelihood for adding new warnings in this flow is less than zero.  And we will remove this in \"Stein\".\n\nThat said, thanks for the practical example.  I\u0027ll workout a way to remove the \"brittleness\" of the test.","commit_id":"aa586fd44f23debc1dffd6c00096deef494cb990"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3be6733d2b542d10bb92c676391ce868012482b","unresolved":false,"context_lines":[{"line_number":4799,"context_line":"            LOG.warning(\u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":4800,"context_line":"                        \u0027deprecated and will be removed in a future \u0027"},{"line_number":4801,"context_line":"                        \u0027release.  It was broken by design in the \u0027"},{"line_number":4802,"context_line":"                        \u0027Linux kernel, so support for Intel CMT was \u0027"},{"line_number":4803,"context_line":"                        \u0027starting from Linux 4.14 onwards. \u0027"},{"line_number":4804,"context_line":"                        \u0027Therefore it is recommended to not \u0027"},{"line_number":4805,"context_line":"                        \u0027enable them.\u0027, event)"},{"line_number":4806,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_1d2eea42","line":4803,"range":{"start_line":4802,"start_character":39,"end_line":4803,"end_character":57},"updated":"2018-05-02 13:31:45.000000000","message":"This reads a bit confusing. Maybe: \"Support for Intel CMT was removed from the 4.14+ Linux kernel.\"","commit_id":"e996e36a44af0307f7f96753061e9a64933cedf1"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e7e6810dc077e33caec3e29f7cc9131e1a912fcc","unresolved":false,"context_lines":[{"line_number":4799,"context_line":"            LOG.warning(\u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":4800,"context_line":"                        \u0027deprecated and will be removed in a future \u0027"},{"line_number":4801,"context_line":"                        \u0027release.  It was broken by design in the \u0027"},{"line_number":4802,"context_line":"                        \u0027Linux kernel, so support for Intel CMT was \u0027"},{"line_number":4803,"context_line":"                        \u0027starting from Linux 4.14 onwards. \u0027"},{"line_number":4804,"context_line":"                        \u0027Therefore it is recommended to not \u0027"},{"line_number":4805,"context_line":"                        \u0027enable them.\u0027, event)"},{"line_number":4806,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6327a066","line":4803,"range":{"start_line":4802,"start_character":39,"end_line":4803,"end_character":57},"in_reply_to":"5f7c97a3_43ab84d5","updated":"2018-05-03 15:50:46.000000000","message":"\u003e Oops, broken sentence indeed.  I meant to write: \"so support for\n \u003e Intel CMT was removed from Linux 4.14 onwards\"\n \u003e \n \u003e If you write \"4.14+\", that can be misread as it only valid from\n\ns/as it/as it is/\n\n \u003e 4.14 (because of the \"+\").\n\nSigh, s/4.14/4.15/","commit_id":"e996e36a44af0307f7f96753061e9a64933cedf1"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"b8dd0f5962e54cbe8877d8b1f843625aad5cc206","unresolved":false,"context_lines":[{"line_number":4799,"context_line":"            LOG.warning(\u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":4800,"context_line":"                        \u0027deprecated and will be removed in a future \u0027"},{"line_number":4801,"context_line":"                        \u0027release.  It was broken by design in the \u0027"},{"line_number":4802,"context_line":"                        \u0027Linux kernel, so support for Intel CMT was \u0027"},{"line_number":4803,"context_line":"                        \u0027starting from Linux 4.14 onwards. \u0027"},{"line_number":4804,"context_line":"                        \u0027Therefore it is recommended to not \u0027"},{"line_number":4805,"context_line":"                        \u0027enable them.\u0027, event)"},{"line_number":4806,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_43ab84d5","line":4803,"range":{"start_line":4802,"start_character":39,"end_line":4803,"end_character":57},"in_reply_to":"9f6a8fd7_1d2eea42","updated":"2018-05-03 15:44:33.000000000","message":"Oops, broken sentence indeed.  I meant to write: \"so support for Intel CMT was removed from Linux 4.14 onwards\"\n\nIf you write \"4.14+\", that can be misread as it only valid from 4.14 (because of the \"+\").","commit_id":"e996e36a44af0307f7f96753061e9a64933cedf1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":4795,"context_line":"            LOG.warning(\"Libvirt doesn\u0027t support event type %s.\", event)"},{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if (event in PERF_EVENTS_CPU_FLAG_MAPPING"},{"line_number":4799,"context_line":"            and PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features):"},{"line_number":4800,"context_line":"            LOG.warning(\"Host does not support event type %s.\", event)"},{"line_number":4801,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f3bccc6a","side":"PARENT","line":4798,"range":{"start_line":4798,"start_character":21,"end_line":4798,"end_character":49},"updated":"2018-05-04 19:53:30.000000000","message":"Why wouldn\u0027t we make this a blacklist and hard failure which stops nova-compute from starting? Because if we got here, libvirt says it supports those events but the kernel might not (we don\u0027t know) but we know the operator shouldn\u0027t be setting those values.","commit_id":"19dd4eb883b557b9482b4467c074210591c6413c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce08e93af467e48eebcd40352250f08f433634be","unresolved":false,"context_lines":[{"line_number":4795,"context_line":"            LOG.warning(\"Libvirt doesn\u0027t support event type %s.\", event)"},{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if (event in PERF_EVENTS_CPU_FLAG_MAPPING"},{"line_number":4799,"context_line":"            and PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features):"},{"line_number":4800,"context_line":"            LOG.warning(\"Host does not support event type %s.\", event)"},{"line_number":4801,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_7ab5d630","side":"PARENT","line":4798,"range":{"start_line":4798,"start_character":21,"end_line":4798,"end_character":49},"in_reply_to":"5f7c97a3_013b20eb","updated":"2018-05-07 15:53:35.000000000","message":"These are things that previously had been valid in our config, but now aren\u0027t because the kernel doesn\u0027t support them anymore right? We\u0027re removing support for those things as a result.\n\nI dunno about a deprecation cycle (mriedem would be on top of that), but once we\u0027re out of those woods, hard fail on startup seems right to me.","commit_id":"19dd4eb883b557b9482b4467c074210591c6413c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a68356463bd0bd844affa324b27aa9736edc7530","unresolved":false,"context_lines":[{"line_number":4795,"context_line":"            LOG.warning(\"Libvirt doesn\u0027t support event type %s.\", event)"},{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if (event in PERF_EVENTS_CPU_FLAG_MAPPING"},{"line_number":4799,"context_line":"            and PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features):"},{"line_number":4800,"context_line":"            LOG.warning(\"Host does not support event type %s.\", event)"},{"line_number":4801,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_3a03d011","side":"PARENT","line":4798,"range":{"start_line":4798,"start_character":21,"end_line":4798,"end_character":49},"in_reply_to":"5f7c97a3_1ae94219","updated":"2018-05-08 08:04:36.000000000","message":"I\u0027ve caught up with the IRC scrollback on #openstack-nova.  So let\u0027s go with the agreed upon: \"deprecate in Rocky and hard-fail in Stein\".\n\nI\u0027ll rework the patch accordingly.  Thanks for the review, everyone.","commit_id":"19dd4eb883b557b9482b4467c074210591c6413c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ac82013aec19e90e4cba9a2e5282d66ebe4ed13c","unresolved":false,"context_lines":[{"line_number":4795,"context_line":"            LOG.warning(\"Libvirt doesn\u0027t support event type %s.\", event)"},{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if (event in PERF_EVENTS_CPU_FLAG_MAPPING"},{"line_number":4799,"context_line":"            and PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features):"},{"line_number":4800,"context_line":"            LOG.warning(\"Host does not support event type %s.\", event)"},{"line_number":4801,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_013b20eb","side":"PARENT","line":4798,"range":{"start_line":4798,"start_character":21,"end_line":4798,"end_character":49},"in_reply_to":"5f7c97a3_6130d457","updated":"2018-05-07 10:07:20.000000000","message":"On second thoughts, I somehow feel it is not such an important thing to merit a hard-failure at `nova-compute` start up time.  So I\u0027m in two minds.","commit_id":"19dd4eb883b557b9482b4467c074210591c6413c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"04ad8d4e125160854a756d4cd88091613dc641e1","unresolved":false,"context_lines":[{"line_number":4795,"context_line":"            LOG.warning(\"Libvirt doesn\u0027t support event type %s.\", event)"},{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if (event in PERF_EVENTS_CPU_FLAG_MAPPING"},{"line_number":4799,"context_line":"            and PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features):"},{"line_number":4800,"context_line":"            LOG.warning(\"Host does not support event type %s.\", event)"},{"line_number":4801,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1ae94219","side":"PARENT","line":4798,"range":{"start_line":4798,"start_character":21,"end_line":4798,"end_character":49},"in_reply_to":"5f7c97a3_7ab5d630","updated":"2018-05-07 15:55:59.000000000","message":"There is no deprecation cycle proposed for using these, so if we\u0027re not going to have a deprecation / warning on startup cycle, we shouldn\u0027t hard fail since that would probably surprise (and piss off) people rolling through Rocky.","commit_id":"19dd4eb883b557b9482b4467c074210591c6413c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ed626d11a2b5bb55f14b3bee4f646a884d2ea3ed","unresolved":false,"context_lines":[{"line_number":4795,"context_line":"            LOG.warning(\"Libvirt doesn\u0027t support event type %s.\", event)"},{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if (event in PERF_EVENTS_CPU_FLAG_MAPPING"},{"line_number":4799,"context_line":"            and PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features):"},{"line_number":4800,"context_line":"            LOG.warning(\"Host does not support event type %s.\", event)"},{"line_number":4801,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_6130d457","side":"PARENT","line":4798,"range":{"start_line":4798,"start_character":21,"end_line":4798,"end_character":49},"in_reply_to":"5f7c97a3_f3bccc6a","updated":"2018-05-07 09:51:18.000000000","message":"Hmm, I briefly thought about it and felt hard failure is a bit heavy-handed.  But given our intention -- we *don\u0027t* want Operators setting those values at all, hard-failing at `nova-compute` start up time sounds like a better approach.  Let me tinker a bit more.","commit_id":"19dd4eb883b557b9482b4467c074210591c6413c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"58b88ce87a65e30ed50d886b671c9bc4a51b3c40","unresolved":false,"context_lines":[{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if event in PERF_EVENTS_CPU_FLAG_MAPPING:"},{"line_number":4799,"context_line":"            LOG.warning(\u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":4800,"context_line":"                        \u0027deprecated and will be removed in the \"Stein\" \u0027"},{"line_number":4801,"context_line":"                        \u0027release.  It was broken by design in the \u0027"},{"line_number":4802,"context_line":"                        \u0027Linux kernel, so support for Intel CMT was \u0027"},{"line_number":4803,"context_line":"                        \u0027removed from Linux 4.14 onwards. Therefore \u0027"},{"line_number":4804,"context_line":"                        \u0027it is recommended to not enable them.\u0027,"},{"line_number":4805,"context_line":"                        event)"},{"line_number":4806,"context_line":""},{"line_number":4807,"context_line":"        return True"},{"line_number":4808,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_169a5662","line":4805,"range":{"start_line":4799,"start_character":0,"end_line":4805,"end_character":30},"updated":"2018-05-09 09:11:24.000000000","message":"You\u0027re no longer checking if the event is actually supported by the processor or not, which is why the \u0027test_get_guest_with_perf_host_unsupported\u0027 test is failing. I assume you want something like this:\n\n  if event in PERF_EVENTS_CPU_FLAG_MAPPING:\n      LOG.warning(\u0027Monitoring Intel ...\u0027)\n\n      if PERF_EVENTS_CPU_FLAG_MAPPING[event] not in cpu_features:\n          LOG.warning(\u0027Host does not support ...\u0027)\n          return False","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"12b9186a5b0ce641d1382195a0db307b2b7a4d3c","unresolved":false,"context_lines":[{"line_number":4796,"context_line":"            return False"},{"line_number":4797,"context_line":""},{"line_number":4798,"context_line":"        if event in PERF_EVENTS_CPU_FLAG_MAPPING:"},{"line_number":4799,"context_line":"            LOG.warning(\u0027Monitoring Intel CMT `perf` event(s) %s is \u0027"},{"line_number":4800,"context_line":"                        \u0027deprecated and will be removed in the \"Stein\" \u0027"},{"line_number":4801,"context_line":"                        \u0027release.  It was broken by design in the \u0027"},{"line_number":4802,"context_line":"                        \u0027Linux kernel, so support for Intel CMT was \u0027"},{"line_number":4803,"context_line":"                        \u0027removed from Linux 4.14 onwards. Therefore \u0027"},{"line_number":4804,"context_line":"                        \u0027it is recommended to not enable them.\u0027,"},{"line_number":4805,"context_line":"                        event)"},{"line_number":4806,"context_line":""},{"line_number":4807,"context_line":"        return True"},{"line_number":4808,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1636d653","line":4805,"range":{"start_line":4799,"start_character":0,"end_line":4805,"end_character":30},"in_reply_to":"5f7c97a3_169a5662","updated":"2018-05-09 09:17:30.000000000","message":"Yeah, I actually have it locally as per above.\n\nFirst I removed it consciously as I was intending the delete entire support for it.  But later we decided to *deprecate* in Rocky and delete support in Stein, to not break people upgrading to Rocky.","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"}],"releasenotes/notes/Remove-support-for-Intel-CMT-events-017fbb890b631d70.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01c065b90e3760cb48c55c12f271f059e7a530cd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Monitoring Technology, or \"CQM\" in Linux kernel parlance) -- namely"},{"line_number":6,"context_line":"    ``cmt``, ``mbm_local`` and ``mbm_total`` -- via the config attribute"},{"line_number":7,"context_line":"    ``[libvirt]/enabled_perf_events`` is now *removed* from Nova."},{"line_number":8,"context_line":"    Otherwise, if you have enabled those events, upgraded to Linux"},{"line_number":9,"context_line":"    kernel 4.14 (or suitable downstream version), it will result in"},{"line_number":10,"context_line":"    instances failing to boot."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_53fd8038","line":8,"range":{"start_line":8,"start_character":49,"end_line":8,"end_character":57},"updated":"2018-05-04 19:53:30.000000000","message":"and upgraded","commit_id":"9221d38f766cc03124e51f86f18b3e78f9445f79"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c60a05121f53ccdb8f832aa4225a58e8d74cf996","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support to monitor performance events for Intel CMT (Cache"},{"line_number":5,"context_line":"    Monitoring Technology, or \"CQM\" in Linux kernel parlance) -- namely"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_31353247","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2018-05-08 13:23:11.000000000","message":"This should now be \"deprecations\".","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"7ccccc3a94a17ec8519b64bc213c42501e8234f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support to monitor performance events for Intel CMT (Cache"},{"line_number":5,"context_line":"    Monitoring Technology, or \"CQM\" in Linux kernel parlance) -- namely"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_d454ec23","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"5f7c97a3_31353247","updated":"2018-05-08 14:10:09.000000000","message":"Yep, will do.","commit_id":"ec37c46c104545bfcd70ec6197d5fa27c8e57e02"}]}