)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2007356e1b866a1ef5e76142692952aed9a40808","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Pipes \u003cjaypipes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-01 10:34:30 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"prep for consumer generation in API layer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reworks the utility functions for serialization in the allocation"},{"line_number":10,"context_line":"handler in two ways: first, decouples the calculation of the last"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_c0f74259","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2018-05-01 15:57:26.000000000","message":"This isn\u0027t the right title (though it\u0027d be useful to mention within the commit message).  If you respin, something more like: \"De-obfuscate _allocations_dict\" might be better.","commit_id":"8a1c10d6e9b187615a8ef5a3ee10b6ef86aafe55"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c4bf726b78f15ad79ed38ee8854fc04caee63239","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Pipes \u003cjaypipes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-01 10:34:30 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"prep for consumer generation in API layer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reworks the utility functions for serialization in the allocation"},{"line_number":10,"context_line":"handler in two ways: first, decouples the calculation of the last"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_50569b08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"in_reply_to":"9f6a8fd7_c0f74259","updated":"2018-05-01 18:32:24.000000000","message":"Done","commit_id":"8a1c10d6e9b187615a8ef5a3ee10b6ef86aafe55"}],"nova/api/openstack/placement/handlers/allocation.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b1ce070d1f0b9cf0612c516b0baea7a6f763d339","unresolved":false,"context_lines":[{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _last_modified_from_allocations(allocations, want_version):"},{"line_number":37,"context_line":"    \"\"\"Given a set of allocation objects, returns the last modified timestamp."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    # NOTE(cdent): The last_modified for an allocation will always be"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_847ccb1f","line":36,"updated":"2018-05-10 14:10:47.000000000","message":"good idea, just for reference this pattern was established when someone expressed concern that looping over the same collection twice was bad. but definitely more of a concern on resource providers than anything else.","commit_id":"4ae425efb8cbd4f9637bb84bdb4b3ea7e3467649"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88112649d2947122c1a237e3d53151ffa4416ece","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # Only calculate last-modified if we are using a microversion that"},{"line_number":43,"context_line":"    # supports it."},{"line_number":44,"context_line":"    get_last_modified \u003d want_version and want_version.matches((1, 15))"},{"line_number":45,"context_line":"    for allocation in allocations:"},{"line_number":46,"context_line":"        if get_last_modified:"},{"line_number":47,"context_line":"            last_modified \u003d util.pick_last_modified(last_modified, allocation)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_b48e59cf","line":45,"updated":"2018-06-15 02:15:37.000000000","message":"nit: we could avoid the loop if get_last_modified is False","commit_id":"2cc37f286fabd9277cb60dbb5d0520c1fcb1c693"}]}