)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9195c6fb63da1db73497f97458d6c39c2b2d07b","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        self.flags(live_migration_permit_auto_converge\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":1206,"context_line":"        self.flags(live_migration_permit_post_copy\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        def fake_has_min_version(lv_ver\u003dNone, hv_ver\u003dNone, hv_type\u003dNone):"},{"line_number":1209,"context_line":"            if (lv_ver \u003d\u003d libvirt_driver.MIN_LIBVIRT_POSTCOPY_VERSION and"},{"line_number":1210,"context_line":"                    hv_ver \u003d\u003d libvirt_driver.MIN_QEMU_POSTCOPY_VERSION):"},{"line_number":1211,"context_line":"                return False"},{"line_number":1212,"context_line":"            return True"},{"line_number":1213,"context_line":"        mock_host.side_effect \u003d fake_has_min_version"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"        self._do_test_parse_migration_flags("},{"line_number":1216,"context_line":"            lm_expected\u003d(libvirt_driver.libvirt.VIR_MIGRATE_UNDEFINE_SOURCE |"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_1a4cb09c","side":"PARENT","line":1213,"range":{"start_line":1208,"start_character":0,"end_line":1213,"end_character":52},"updated":"2018-05-02 13:17:11.000000000","message":"As an aside, this is very confusing and took me longer than it should have to grasp. What we\u0027re trying to do is nullify the check for a given minimum version such that checking if we\u0027ve a minimum version always returns False.\n\nIt\u0027s unrelated, but perhaps you could take the opportunity to clean this up and simply pass \u0027return_value\u003dFalse\u0027 to the decorator above? You could also check if this was called with \u0027lv_ver\u003dlibvirt_driver.MIN_LIBVIRT_POSTCOPY_VERSION\u0027 below, I guess.","commit_id":"f930df24f8406b360ada69e16109e4c59630bc51"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"dc676ddcd0bb9779dfdeab32b029806bab475bf0","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        self.flags(live_migration_permit_auto_converge\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":1206,"context_line":"        self.flags(live_migration_permit_post_copy\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        def fake_has_min_version(lv_ver\u003dNone, hv_ver\u003dNone, hv_type\u003dNone):"},{"line_number":1209,"context_line":"            if (lv_ver \u003d\u003d libvirt_driver.MIN_LIBVIRT_POSTCOPY_VERSION and"},{"line_number":1210,"context_line":"                    hv_ver \u003d\u003d libvirt_driver.MIN_QEMU_POSTCOPY_VERSION):"},{"line_number":1211,"context_line":"                return False"},{"line_number":1212,"context_line":"            return True"},{"line_number":1213,"context_line":"        mock_host.side_effect \u003d fake_has_min_version"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"        self._do_test_parse_migration_flags("},{"line_number":1216,"context_line":"            lm_expected\u003d(libvirt_driver.libvirt.VIR_MIGRATE_UNDEFINE_SOURCE |"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_fd43f611","side":"PARENT","line":1213,"range":{"start_line":1208,"start_character":0,"end_line":1213,"end_character":52},"in_reply_to":"9f6a8fd7_1a4cb09c","updated":"2018-05-02 13:28:58.000000000","message":"Your observation is right; probably I should just address in this change.","commit_id":"f930df24f8406b360ada69e16109e4c59630bc51"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1dbf2ee596ff0b4f9341e59c14e28ac35da78d89","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"                         libvirt_driver.libvirt.VIR_MIGRATE_NON_SHARED_INC |"},{"line_number":1219,"context_line":"                         libvirt_driver.libvirt.VIR_MIGRATE_AUTO_CONVERGE))"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"        min_ver.assert_called_with("},{"line_number":1222,"context_line":"            lv_ver\u003dlibvirt_driver.MIN_LIBVIRT_POSTCOPY_VERSION)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"    @mock.patch.object(host.Host, \u0027has_min_version\u0027, return_value\u003dFalse)"},{"line_number":1225,"context_line":"    def test_live_migration_permit_postcopy_true_old_libvirt(self, host):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_53a453b9","line":1222,"range":{"start_line":1221,"start_character":0,"end_line":1222,"end_character":63},"updated":"2018-05-02 14:45:21.000000000","message":"++","commit_id":"114311b348d24cc43e0bf2b641c8358ac98d286f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e9195c6fb63da1db73497f97458d6c39c2b2d07b","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        return migration_flags"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def _is_post_copy_available(self):"},{"line_number":613,"context_line":"        if self._host.has_min_version(lv_ver\u003dMIN_LIBVIRT_POSTCOPY_VERSION):"},{"line_number":614,"context_line":"            return True"},{"line_number":615,"context_line":"        return False"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def _is_virtlogd_available(self):"},{"line_number":618,"context_line":"        return self._host.has_min_version(MIN_LIBVIRT_VIRTLOGD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_7a54cc21","line":615,"range":{"start_line":613,"start_character":0,"end_line":615,"end_character":20},"updated":"2018-05-02 13:17:11.000000000","message":"Another nit: since we\u0027re cleaning this up, this could now just be modified to be like the below.","commit_id":"54197c4991470da17fb5c7592f6d931141c3d118"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"dc676ddcd0bb9779dfdeab32b029806bab475bf0","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        return migration_flags"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def _is_post_copy_available(self):"},{"line_number":613,"context_line":"        if self._host.has_min_version(lv_ver\u003dMIN_LIBVIRT_POSTCOPY_VERSION):"},{"line_number":614,"context_line":"            return True"},{"line_number":615,"context_line":"        return False"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def _is_virtlogd_available(self):"},{"line_number":618,"context_line":"        return self._host.has_min_version(MIN_LIBVIRT_VIRTLOGD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_dd40720a","line":615,"range":{"start_line":613,"start_character":0,"end_line":615,"end_character":20},"in_reply_to":"9f6a8fd7_7a54cc21","updated":"2018-05-02 13:28:58.000000000","message":"Yes, the nit is worth addressing.  Good catch.","commit_id":"54197c4991470da17fb5c7592f6d931141c3d118"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c963ea04969c63283e7b2e53e6b53ff2feb95b8f","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        return migration_flags"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def _is_post_copy_available(self):"},{"line_number":616,"context_line":"        return self._host.has_min_version(lv_ver\u003dMIN_LIBVIRT_POSTCOPY_VERSION)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def _is_virtlogd_available(self):"},{"line_number":619,"context_line":"        return self._host.has_min_version(MIN_LIBVIRT_VIRTLOGD,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_f6b470d3","line":616,"updated":"2018-05-02 18:38:22.000000000","message":"No need the lv_ver\u003d param","commit_id":"be135bda3890ccdf81a7993347f81a963a458efd"}]}