)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd0be0e6b1c0842c84585cda6c4c737707cc2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pci: don\u0027t consider case when match tags specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes matching tags using the case."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ica532fa7dcd5fe11bd60db4cfe005a2bef0a1b7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_9c1de0bf","line":9,"updated":"2018-05-29 17:36:20.000000000","message":"nit: this commit message could be a bit more fleshed out to explain why we should make this change. I think the idea is we want to be able to handle trusted\u003dTrue and trusted\u003dtrue the same so it\u0027s better UX for the operator.","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af1710d9a7165d429779d76fa52aab10cf1dec19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pci: don\u0027t consider case when match tags specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes matching tags using the case."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ica532fa7dcd5fe11bd60db4cfe005a2bef0a1b7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_a0a66a0e","line":9,"in_reply_to":"5f7c97a3_9c1de0bf","updated":"2018-05-29 21:46:14.000000000","message":"Done","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"}],"nova/pci/utils.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"52a5b3e003660956d5b225ea761728d94cf73161","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                if not all(x in pci_dev.get(k) for x in v):"},{"line_number":56,"context_line":"                    return False"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                if isinstance(v, six.string_types):"},{"line_number":59,"context_line":"                    v \u003d v.lower()"},{"line_number":60,"context_line":"                if isinstance(pci_dev_v, six.string_types):"},{"line_number":61,"context_line":"                    pci_dev_v \u003d pci_dev_v.lower()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0bc4ed3e","line":58,"updated":"2018-05-15 17:24:33.000000000","message":"Could you put NOTE for explain why we should not take care of upper/lower case here?","commit_id":"871768cccd16b06b63aaba804bac85859483d61d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd0be0e6b1c0842c84585cda6c4c737707cc2e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                if not all(x in pci_dev.get(k) for x in v):"},{"line_number":56,"context_line":"                    return False"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_bcdd3cde","line":58,"range":{"start_line":58,"start_character":46,"end_line":58,"end_character":50},"updated":"2018-05-29 17:36:20.000000000","message":"We don\u0027t need to check case for tags in order to avoid any mismatch....","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af1710d9a7165d429779d76fa52aab10cf1dec19","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                if not all(x in pci_dev.get(k) for x in v):"},{"line_number":56,"context_line":"                    return False"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_40af56e2","line":58,"range":{"start_line":58,"start_character":46,"end_line":58,"end_character":50},"in_reply_to":"5f7c97a3_bcdd3cde","updated":"2018-05-29 21:46:14.000000000","message":"Done","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd0be0e6b1c0842c84585cda6c4c737707cc2e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    return False"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1ce6b0b1","line":59,"range":{"start_line":59,"start_character":64,"end_line":59,"end_character":68},"updated":"2018-05-29 17:36:20.000000000","message":"Are there other instances of tags that aren\u0027t related to the port binding profile? I\u0027m just wondering if there is any case that requires a case-specific check.","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd0be0e6b1c0842c84585cda6c4c737707cc2e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    return False"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1ccd502f","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":27},"updated":"2018-05-29 17:36:20.000000000","message":"mismatch","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af1710d9a7165d429779d76fa52aab10cf1dec19","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    return False"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_60acd2ec","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":27},"in_reply_to":"5f7c97a3_1ccd502f","updated":"2018-05-29 21:46:14.000000000","message":"Done","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd0be0e6b1c0842c84585cda6c4c737707cc2e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"},{"line_number":63,"context_line":"                    v \u003d v.lower()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_9ce08099","line":60,"range":{"start_line":60,"start_character":26,"end_line":60,"end_character":33},"updated":"2018-05-29 17:36:20.000000000","message":"profiles","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af1710d9a7165d429779d76fa52aab10cf1dec19","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"},{"line_number":63,"context_line":"                    v \u003d v.lower()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_00b5de31","line":60,"range":{"start_line":60,"start_character":26,"end_line":60,"end_character":33},"in_reply_to":"5f7c97a3_9ce08099","updated":"2018-05-29 21:46:14.000000000","message":"Done","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd0be0e6b1c0842c84585cda6c4c737707cc2e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"},{"line_number":63,"context_line":"                    v \u003d v.lower()"},{"line_number":64,"context_line":"                if isinstance(pci_dev_v, six.string_types):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_fcd734be","line":61,"range":{"start_line":61,"start_character":27,"end_line":61,"end_character":35},"updated":"2018-05-29 17:36:20.000000000","message":"whitelist","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af1710d9a7165d429779d76fa52aab10cf1dec19","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                # We don\u0027t need to check case tags. That to avoid any"},{"line_number":59,"context_line":"                # missmatch with the tags provided by users for port"},{"line_number":60,"context_line":"                # binding profils and the ones configured by operators"},{"line_number":61,"context_line":"                # with pci whitlist option."},{"line_number":62,"context_line":"                if isinstance(v, six.string_types):"},{"line_number":63,"context_line":"                    v \u003d v.lower()"},{"line_number":64,"context_line":"                if isinstance(pci_dev_v, six.string_types):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_20b25a4a","line":61,"range":{"start_line":61,"start_character":27,"end_line":61,"end_character":35},"in_reply_to":"5f7c97a3_fcd734be","updated":"2018-05-29 21:46:14.000000000","message":"Done","commit_id":"b567a82b49f2faecfbcd467a4518b80e38c9b256"}]}