)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"913fd464bf74a1fec8b9f61c1f9fcf742808a3a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"they cannot be scheduled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Since we now require resource classes, raise an exception in"},{"line_number":14,"context_line":"get_inventory for any nodes that don\u0027t have a resource class set on the"},{"line_number":15,"context_line":"node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.openstack.org/565806/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_5e4ddb3b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"updated":"2018-08-14 18:35:54.000000000","message":"update_provider_tree now","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"42284bec9f7e96323ffbbe093e695f30d2706e3e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"they cannot be scheduled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Since we now require resource classes, raise an exception in"},{"line_number":14,"context_line":"get_inventory for any nodes that don\u0027t have a resource class set on the"},{"line_number":15,"context_line":"node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.openstack.org/565806/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_5ea5dba0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"in_reply_to":"3f79a3b5_5e4ddb3b","updated":"2018-08-14 18:43:39.000000000","message":"Done","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"913fd464bf74a1fec8b9f61c1f9fcf742808a3a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"get_inventory for any nodes that don\u0027t have a resource class set on the"},{"line_number":15,"context_line":"node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.openstack.org/565806/"},{"line_number":18,"context_line":"Change-Id: If2b8c1a76d7dbabbac7bb359c9e572cfed510800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_de624bae","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":48},"updated":"2018-08-14 18:35:54.000000000","message":"This has merged and can be removed.","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"42284bec9f7e96323ffbbe093e695f30d2706e3e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"get_inventory for any nodes that don\u0027t have a resource class set on the"},{"line_number":15,"context_line":"node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.openstack.org/565806/"},{"line_number":18,"context_line":"Change-Id: If2b8c1a76d7dbabbac7bb359c9e572cfed510800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_be9aef5e","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":48},"in_reply_to":"3f79a3b5_de624bae","updated":"2018-08-14 18:43:39.000000000","message":"Done","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"}],"nova/exception.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e82379cc304b334178db33fa18684ded79b4a4de","unresolved":false,"context_lines":[{"line_number":2364,"context_line":"        self.rc \u003d results.get(\u0027rc\u0027)"},{"line_number":2365,"context_line":"        self.rs \u003d results.get(\u0027rs\u0027)"},{"line_number":2366,"context_line":"        self.errmsg \u003d results.get(\u0027errmsg\u0027)"},{"line_number":2367,"context_line":""},{"line_number":2368,"context_line":"class NoResourceClass(NovaException):"},{"line_number":2369,"context_line":"    msg_fmt \u003d _(\"Resource class not found for Ironic node %(node)s.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d8e4a20f","line":2367,"updated":"2018-08-14 18:00:12.000000000","message":"pep8 will complain about not having two blank lines here. :)","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"42284bec9f7e96323ffbbe093e695f30d2706e3e","unresolved":false,"context_lines":[{"line_number":2364,"context_line":"        self.rc \u003d results.get(\u0027rc\u0027)"},{"line_number":2365,"context_line":"        self.rs \u003d results.get(\u0027rs\u0027)"},{"line_number":2366,"context_line":"        self.errmsg \u003d results.get(\u0027errmsg\u0027)"},{"line_number":2367,"context_line":""},{"line_number":2368,"context_line":"class NoResourceClass(NovaException):"},{"line_number":2369,"context_line":"    msg_fmt \u003d _(\"Resource class not found for Ironic node %(node)s.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_7ea0d790","line":2367,"in_reply_to":"3f79a3b5_d8e4a20f","updated":"2018-08-14 18:43:39.000000000","message":"Done","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"454d0b459056e60a955fc81ed86e0c834f2e6e83","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        \"\"\""},{"line_number":724,"context_line":"        # nodename is the ironic node\u0027s UUID."},{"line_number":725,"context_line":"        node \u003d self._node_from_cache(nodename)"},{"line_number":726,"context_line":"        # TODO(jaypipes): Completely remove the reporting of VCPU, MEMORY_MB,"},{"line_number":727,"context_line":"        # and DISK_GB resource classes in early Queens when Ironic nodes will"},{"line_number":728,"context_line":"        # *always* return the custom resource class that represents the"},{"line_number":729,"context_line":"        # baremetal node class in an atomic, singular unit."},{"line_number":730,"context_line":"        if (not self._node_resources_used(node) and"},{"line_number":731,"context_line":"            self._node_resources_unavailable(node)):"},{"line_number":732,"context_line":"            # TODO(dtantsur): report resources as reserved instead of reporting"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_10bc8cda","line":729,"range":{"start_line":726,"start_character":8,"end_line":729,"end_character":59},"updated":"2018-05-02 16:51:16.000000000","message":"How about this?","commit_id":"9a21aa8715052697a7837d4371c480b8c1318c6d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"353ac7b4b2211e7d7d8d43b7b5a2d07e4092c7b0","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        \"\"\""},{"line_number":724,"context_line":"        # nodename is the ironic node\u0027s UUID."},{"line_number":725,"context_line":"        node \u003d self._node_from_cache(nodename)"},{"line_number":726,"context_line":"        # TODO(jaypipes): Completely remove the reporting of VCPU, MEMORY_MB,"},{"line_number":727,"context_line":"        # and DISK_GB resource classes in early Queens when Ironic nodes will"},{"line_number":728,"context_line":"        # *always* return the custom resource class that represents the"},{"line_number":729,"context_line":"        # baremetal node class in an atomic, singular unit."},{"line_number":730,"context_line":"        if (not self._node_resources_used(node) and"},{"line_number":731,"context_line":"            self._node_resources_unavailable(node)):"},{"line_number":732,"context_line":"            # TODO(dtantsur): report resources as reserved instead of reporting"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_37e6cbea","line":729,"range":{"start_line":726,"start_character":8,"end_line":729,"end_character":59},"in_reply_to":"9f6a8fd7_10bc8cda","updated":"2018-05-03 12:13:55.000000000","message":"Good catch, thanks.","commit_id":"9a21aa8715052697a7837d4371c480b8c1318c6d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"948b1703ea6398f43eae1ff718c5033f0b4467ae","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                       \u0027power\u0027: node.power_state, \u0027maint\u0027: node.maintenance})"},{"line_number":740,"context_line":"            return {}"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        info \u003d self._node_resource(node)"},{"line_number":743,"context_line":"        result \u003d {}"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        rc_name \u003d info.get(\u0027resource_class\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_70eb88db","line":742,"range":{"start_line":742,"start_character":0,"end_line":742,"end_character":40},"updated":"2018-05-02 16:51:25.000000000","message":"looks like info is now unused. remove this call?","commit_id":"9a21aa8715052697a7837d4371c480b8c1318c6d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"353ac7b4b2211e7d7d8d43b7b5a2d07e4092c7b0","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                       \u0027power\u0027: node.power_state, \u0027maint\u0027: node.maintenance})"},{"line_number":740,"context_line":"            return {}"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        info \u003d self._node_resource(node)"},{"line_number":743,"context_line":"        result \u003d {}"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        rc_name \u003d info.get(\u0027resource_class\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_17cdcf5c","line":742,"range":{"start_line":742,"start_character":0,"end_line":742,"end_character":40},"in_reply_to":"9f6a8fd7_70eb88db","updated":"2018-05-03 12:13:55.000000000","message":"It\u0027s used three lines down :)","commit_id":"9a21aa8715052697a7837d4371c480b8c1318c6d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3435cf60a199f7c3c0b8afdf1c9ac18b9dd676df","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        info \u003d self._node_resource(node)"},{"line_number":738,"context_line":"        result \u003d {}"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        rc_name \u003d info.get(\u0027resource_class\u0027)"},{"line_number":741,"context_line":"        if rc_name is None:"},{"line_number":742,"context_line":"            raise exception.NoResourceClass(node\u003dnodename)"},{"line_number":743,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5221159f","line":740,"range":{"start_line":740,"start_character":18,"end_line":740,"end_character":44},"updated":"2018-05-03 12:33:47.000000000","message":"node.resource_class? then you can stop populating info, I guess","commit_id":"25a23419746e43a6e11a6793fbe061264dd49c86"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5b90373d06fc8ad84f6610194c812484d7af876","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        extra_specs, the periodic call to update_available_resources() will add"},{"line_number":541,"context_line":"        an allocation against the custom resource class, and prevent placement"},{"line_number":542,"context_line":"        from thinking that that node is available. This code can be removed in"},{"line_number":543,"context_line":"        Queens, and will need to be updated to also alter extra_specs to"},{"line_number":544,"context_line":"        zero-out the old-style standard resource classes of VCPU, MEMORY_MB,"},{"line_number":545,"context_line":"        and DISK_GB."},{"line_number":546,"context_line":"        \"\"\""},{"line_number":547,"context_line":"        ctx \u003d nova_context.get_admin_context()"},{"line_number":548,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_61484bb2","line":545,"range":{"start_line":543,"start_character":16,"end_line":545,"end_character":20},"updated":"2019-02-15 15:27:41.000000000","message":"Oops, bug 1816034.","commit_id":"a985e34cdeef777fe7ff943e363a5f1be6d991b7"}],"releasenotes/notes/ironic-remove-properties-scheduling-7555eb8e5e25f18d.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"913fd464bf74a1fec8b9f61c1f9fcf742808a3a9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic nodes are now only scheduled using resource classes. CPUs, RAM, and"},{"line_number":5,"context_line":"    disks are not reported to the resource tracker. Ironic nodes must have the"},{"line_number":6,"context_line":"    ``resource_class`` field set before upgrading.  Flavors must also be"},{"line_number":7,"context_line":"    configured to use resource classes instead of node properties. See the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_9e0db3e9","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":62},"updated":"2018-08-14 18:35:54.000000000","message":"Is there a descriptor that can make this more specific? (The things you removed are also resource classes :)","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"42284bec9f7e96323ffbbe093e695f30d2706e3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic nodes are now only scheduled using resource classes. CPUs, RAM, and"},{"line_number":5,"context_line":"    disks are not reported to the resource tracker. Ironic nodes must have the"},{"line_number":6,"context_line":"    ``resource_class`` field set before upgrading.  Flavors must also be"},{"line_number":7,"context_line":"    configured to use resource classes instead of node properties. See the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_3ea6dfac","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":62},"in_reply_to":"3f79a3b5_9e0db3e9","updated":"2018-08-14 18:43:39.000000000","message":"Done","commit_id":"492e9045490e7f17f3e1906d915c61408ded3703"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b71df2f8d9378ee09c1a21e683dce91b088b2c7c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic nodes are now only scheduled using the resource_class field set on"},{"line_number":5,"context_line":"    the node. CPUs, RAM, and disks are not reported to the resource tracker."},{"line_number":6,"context_line":"    Ironic nodes must have the ``resource_class`` field set before upgrading."},{"line_number":7,"context_line":"    Flavors must also be configured to use resource classes instead of node"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_9ee8537c","line":4,"range":{"start_line":4,"start_character":50,"end_line":4,"end_character":64},"updated":"2018-08-14 18:51:01.000000000","message":"yah, nice.\n\nNit: this could be double-backticked as it is below.","commit_id":"12f6d5faaccc997c86cfd3ec39c96b8f3176062b"}]}