)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c0c182994ed6fbf04a80d6978e6de10d738d27f8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"it will fail with UnexpectedTaskStateError."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This makes the expected_task_states passed to Instance.save"},{"line_number":15,"context_line":"use the same list of allowed task states that we use in the"},{"line_number":16,"context_line":"check_instance_state decorator, and re-writes the unit test"},{"line_number":17,"context_line":"to use an actual database to verify the Instance.save()"},{"line_number":18,"context_line":"behavior and task state check in the DB API."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_6db35d36","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":31},"updated":"2018-07-31 08:50:33.000000000","message":"thanks for the explanation where we can find the allowed task states.","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"}],"api-ref/source/servers-actions.inc":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f9c45affd1e42c885cd3dc12a399c1586e51a905","unresolved":false,"context_lines":[{"line_number":436,"context_line":"* ``HARD_REBOOT``"},{"line_number":437,"context_line":"* ``PAUSED``"},{"line_number":438,"context_line":"* ``REBOOT``"},{"line_number":439,"context_line":"* ``SHUTOFF``"},{"line_number":440,"context_line":"* ``SUSPENDED``"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"If the server is locked, you must have administrator privileges"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_ac88401f","line":439,"range":{"start_line":439,"start_character":0,"end_line":439,"end_character":13},"updated":"2018-05-04 02:27:23.000000000","message":"don\u0027t know a SHUTOFF instance hard reboot make sense?\nor it\u0027s meaning actually nova think it\u0027s active but in fact user shutdown by them self in operating system?","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"45b135fdbc2117ecfda5840ca54cd4dcdfa7d149","unresolved":false,"context_lines":[{"line_number":436,"context_line":"* ``HARD_REBOOT``"},{"line_number":437,"context_line":"* ``PAUSED``"},{"line_number":438,"context_line":"* ``REBOOT``"},{"line_number":439,"context_line":"* ``SHUTOFF``"},{"line_number":440,"context_line":"* ``SUSPENDED``"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"If the server is locked, you must have administrator privileges"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_6047891f","line":439,"range":{"start_line":439,"start_character":0,"end_line":439,"end_character":13},"in_reply_to":"5f7c97a3_ac88401f","updated":"2018-05-04 09:17:14.000000000","message":"I think the SHUTOFF status reflects vm_state \u003d STOPPED, and it is in the list:\nhttps://github.com/openstack/nova/blob/644ac5ec37903b0a08891cc403c8b3b63fc2a91c/nova/compute/vm_states.py#L72","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f9c45affd1e42c885cd3dc12a399c1586e51a905","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"**Asynchronous Postconditions**"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"After you successfully reboot a server, its status changes to ``ACTIVE``."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"Normal response codes: 202"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_6c7a2825","line":447,"range":{"start_line":447,"start_character":40,"end_line":447,"end_character":73},"updated":"2018-05-04 02:27:23.000000000","message":"A edge condition here\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3197","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"45b135fdbc2117ecfda5840ca54cd4dcdfa7d149","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"**Asynchronous Postconditions**"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"After you successfully reboot a server, its status changes to ``ACTIVE``."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"Normal response codes: 202"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_c0fe9d04","line":447,"range":{"start_line":447,"start_character":40,"end_line":447,"end_character":73},"in_reply_to":"5f7c97a3_6c7a2825","updated":"2018-05-04 09:17:14.000000000","message":"strange, RESCUED is not in the ALLOW_HARD_REBOOT list:\nhttps://github.com/openstack/nova/blob/644ac5ec37903b0a08891cc403c8b3b63fc2a91c/nova/compute/vm_states.py#L72\nconsider fix this? I mean should we remove the rescued branch? we should not allow reboot a instance in rescure states right?","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c0c182994ed6fbf04a80d6978e6de10d738d27f8","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"**Asynchronous Postconditions**"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"After you successfully reboot a server, its status changes to ``ACTIVE``."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"Normal response codes: 202"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_cd3951a2","line":447,"range":{"start_line":447,"start_character":40,"end_line":447,"end_character":73},"in_reply_to":"5f7c97a3_99f57fce","updated":"2018-07-31 08:50:33.000000000","message":"Agreed that this concern is unrelated to the modification you provided.","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8424ef03bea0d63e0b308682b2aaa97b1ab725ef","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"**Asynchronous Postconditions**"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"After you successfully reboot a server, its status changes to ``ACTIVE``."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"Normal response codes: 202"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f7c97a3_99f57fce","line":447,"range":{"start_line":447,"start_character":40,"end_line":447,"end_character":73},"in_reply_to":"5f7c97a3_c0fe9d04","updated":"2018-05-04 13:41:42.000000000","message":"This document reflects the current state of what the API allows. See:\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-05-03.log.html#t2018-05-03T18:49:58\n\nBasically that code was added to the compute manager and xen virt driver way back in 2013, presumably because Rackspace needed it, and had modified the API out of tree so that you could reboot a rescued instance and they never upstreamed that API change. I asked johnthetubaguy and mikal to follow up, but haven\u0027t heard back. I might send something to the mailing list about this because if we aren\u0027t going to support it in the API we need to remove that check from the compute manager to avoid confusion, but that\u0027s not something for which we should hold up this change.","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"}],"nova/compute/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c0c182994ed6fbf04a80d6978e6de10d738d27f8","unresolved":false,"context_lines":[{"line_number":2947,"context_line":"            self._hard_reboot(context, instance)"},{"line_number":2948,"context_line":""},{"line_number":2949,"context_line":"    @check_instance_state(vm_state\u003dset(vm_states.ALLOW_SOFT_REBOOT),"},{"line_number":2950,"context_line":"                          task_state\u003d[None])"},{"line_number":2951,"context_line":"    def _soft_reboot(self, context, instance):"},{"line_number":2952,"context_line":"        expected_task_state \u003d [None]"},{"line_number":2953,"context_line":"        instance.task_state \u003d task_states.REBOOTING"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8d703975","line":2950,"updated":"2018-07-31 08:50:33.000000000","message":"yup, all good and consistent with the doc.","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c0c182994ed6fbf04a80d6978e6de10d738d27f8","unresolved":false,"context_lines":[{"line_number":2963,"context_line":"                          task_state\u003dtask_states.ALLOW_REBOOT)"},{"line_number":2964,"context_line":"    def _hard_reboot(self, context, instance):"},{"line_number":2965,"context_line":"        instance.task_state \u003d task_states.REBOOTING_HARD"},{"line_number":2966,"context_line":"        instance.save(expected_task_state\u003dtask_states.ALLOW_REBOOT)"},{"line_number":2967,"context_line":""},{"line_number":2968,"context_line":"        self._record_action_start(context, instance, instance_actions.REBOOT)"},{"line_number":2969,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8d47d91e","line":2966,"range":{"start_line":2966,"start_character":21,"end_line":2966,"end_character":67},"updated":"2018-07-31 08:50:33.000000000","message":"yeah, all good to make it consistent with check_instance_state","commit_id":"3437baedf646c7cd3da43440368edc194a880db8"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be3b8507983ab8ab60855be37332145682f9512c","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        self._test_reboot_type(vm_states.ACTIVE,"},{"line_number":904,"context_line":"                               \u0027HARD\u0027, task_state\u003dtask_states.RESUMING)"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    def test_reboot_hard_pausing(self):"},{"line_number":907,"context_line":"        self._test_reboot_type(vm_states.ACTIVE,"},{"line_number":908,"context_line":"                               \u0027HARD\u0027, task_state\u003dtask_states.PAUSING)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    def test_reboot_hard_unpausing(self):"},{"line_number":911,"context_line":"        self._test_reboot_type(vm_states.ACTIVE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_03d97682","side":"PARENT","line":908,"range":{"start_line":906,"start_character":0,"end_line":908,"end_character":70},"updated":"2018-07-18 06:00:52.000000000","message":"or just keep this test also","commit_id":"21939c102921409ddb19a8cdf2cc4c1c2177fcea"}]}