)]}'
{"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"75740123069313acf17bd534fdb88cb4109fa61d","unresolved":false,"context_lines":[{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"@db_api.api_context_manager.reader"},{"line_number":1196,"context_line":"def _get_all_with_shared(ctx, match_spec, group_no):"},{"line_number":1197,"context_line":"    \"\"\"Uses some more advanced SQL to find providers that either have the"},{"line_number":1198,"context_line":"    requested resources \"locally\" or are associated with a provider that shares"},{"line_number":1199,"context_line":"    those requested resources."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5f734716","line":1196,"updated":"2018-05-04 16:09:28.000000000","message":"In this function we pass in the whole MatchSpec and the group index then we always uses that MatchSpec filtered by that group index. Can we simply move the group_resources, group_sharing_providers and group_member_of functions from the MatchSpec to the RequestGroup object to avoid the extra indirection?","commit_id":"d4531e43eefe18e47abf7193247debccacb601a6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"75740123069313acf17bd534fdb88cb4109fa61d","unresolved":false,"context_lines":[{"line_number":2939,"context_line":""},{"line_number":2940,"context_line":""},{"line_number":2941,"context_line":"@db_api.api_context_manager.reader"},{"line_number":2942,"context_line":"def _get_provider_ids_matching(ctx, match_spec, group_no):"},{"line_number":2943,"context_line":"    \"\"\"Returns a list of tuples of (internal provider ID, root provider ID)"},{"line_number":2944,"context_line":"    that have available inventory to satisfy all the supplied requests for"},{"line_number":2945,"context_line":"    resources."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ffc6d316","line":2942,"updated":"2018-05-04 16:09:28.000000000","message":"this functional also seems to only case about a single group so passing the whole MatchSpec and then filtering for that group seems overcomplicated. Can we move the accessor functions from the MatchSpec to the RequestGroup and only pass in the single RequestGroup this function needs to care about?\n\nI tried to explain my proposal here:\nhttps://review.openstack.org/#/c/566166/1/nova/api/openstack/placement/objects/resource_provider.py@3801","commit_id":"d4531e43eefe18e47abf7193247debccacb601a6"}]}