)]}'
{"plugins/xenserver/xenapi/etc/xapi.d/plugins/glance":[{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"fd16c2c81490847415639ef3fb2915c93d590d63","unresolved":false,"context_lines":[{"line_number":34,"context_line":"logging \u003d pluginlib_nova.logging"},{"line_number":35,"context_line":"PluginError \u003d pluginlib_nova.PluginError"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DEFAULT_SOCKET_TIMEOUT_SECONDS \u003d 60"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class RetryableError(Exception):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAATn%2F%2BmUI%3D","line":37,"updated":"2013-11-22 16:40:13.000000000","message":"Have considered setting this in the nova.conf instead and passing it into the plugin call? \n\nMaybe we don\u0027t care about tweaking this too often. I\u0027m just curious.","commit_id":"1ee1d1a85753d7e6749388bebcb5514d8dce9204"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f7109e1ef61dce3e7e3af093eef8c06640cf8fad","unresolved":false,"context_lines":[{"line_number":34,"context_line":"logging \u003d pluginlib_nova.logging"},{"line_number":35,"context_line":"PluginError \u003d pluginlib_nova.PluginError"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DEFAULT_SOCKET_TIMEOUT_SECONDS \u003d 60"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class RetryableError(Exception):"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAATn%2F9%2FhA%3D","line":37,"in_reply_to":"AAAATn%2F%2BmUI%3D","updated":"2013-12-03 17:30:57.000000000","message":"I think we are trying to not add any more of those \"just in case\" settings. But you are right, I have no idea if this is the correct value, but it seems safe-ish at least. Its only a belt and braces style thing really.","commit_id":"1ee1d1a85753d7e6749388bebcb5514d8dce9204"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"07cf59533e207a0caf8644bcff5f8a4d21fbe2e7","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _download_tarball_and_verify(request, staging_path):"},{"line_number":45,"context_line":"    # NOTE(johngarbutt) to ensure the script does not hang"},{"line_number":46,"context_line":"    # if we loose connection to glance we add a default socket"},{"line_number":47,"context_line":"    # The default is to never timeout."},{"line_number":48,"context_line":"    socket.setdefaulttimeout(DEFAULT_SOCKET_TIMEOUT_SECONDS)"},{"line_number":49,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAATn%2F9%2FhE%3D","line":46,"updated":"2013-12-03 17:35:08.000000000","message":"s/loose/lose/","commit_id":"1ee1d1a85753d7e6749388bebcb5514d8dce9204"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab0f7808838d731c96c1964591dc4118c08a8627","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _download_tarball_and_verify(request, staging_path):"},{"line_number":45,"context_line":"    # NOTE(johngarbutt) to ensure the script does not hang"},{"line_number":46,"context_line":"    # if we loose connection to glance we add a default socket"},{"line_number":47,"context_line":"    # The default is to never timeout."},{"line_number":48,"context_line":"    socket.setdefaulttimeout(DEFAULT_SOCKET_TIMEOUT_SECONDS)"},{"line_number":49,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAATn%2F9%2FQc%3D","line":46,"in_reply_to":"AAAATn%2F9%2FhE%3D","updated":"2013-12-03 18:42:33.000000000","message":"Arse.","commit_id":"1ee1d1a85753d7e6749388bebcb5514d8dce9204"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"07cf59533e207a0caf8644bcff5f8a4d21fbe2e7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # NOTE(johngarbutt) to ensure the script does not hang"},{"line_number":46,"context_line":"    # if we loose connection to glance we add a default socket"},{"line_number":47,"context_line":"    # The default is to never timeout."},{"line_number":48,"context_line":"    socket.setdefaulttimeout(DEFAULT_SOCKET_TIMEOUT_SECONDS)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        response \u003d urllib2.urlopen(request)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAATn%2F9%2Ff8%3D","line":48,"updated":"2013-12-03 17:35:08.000000000","message":"What\u0027s the error behavior on timeout?  SocketError?\n\nDo we want to raise a RetryableError for consistency?  Perhaps on a re-attempt a different instance of glance-api would get accessed and the request would work.","commit_id":"1ee1d1a85753d7e6749388bebcb5514d8dce9204"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab0f7808838d731c96c1964591dc4118c08a8627","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # NOTE(johngarbutt) to ensure the script does not hang"},{"line_number":46,"context_line":"    # if we loose connection to glance we add a default socket"},{"line_number":47,"context_line":"    # The default is to never timeout."},{"line_number":48,"context_line":"    socket.setdefaulttimeout(DEFAULT_SOCKET_TIMEOUT_SECONDS)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        response \u003d urllib2.urlopen(request)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAATn%2F9%2FPU%3D","line":48,"in_reply_to":"AAAATn%2F9%2Ff8%3D","updated":"2013-12-03 18:42:33.000000000","message":"I forgot about that, but I think it is actually a URLError:\nhttp://stackoverflow.com/questions/7167107/catch-socket-timeout-exception","commit_id":"1ee1d1a85753d7e6749388bebcb5514d8dce9204"}]}