)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db16c533d2bb1b57cb613b93c0c5b63e529c035a","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"        vifs \u003d [vif, vif1, vif2, vif3]"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"        network_info \u003d _fake_network_info(self, 4)"},{"line_number":1696,"context_line":"        network_info[0][\u0027vnic_type\u0027] \u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL"},{"line_number":1697,"context_line":"        network_info[0][\u0027address\u0027] \u003d \"51:5a:2c:a4:5e:1b\""},{"line_number":1698,"context_line":"        network_info[0][\u0027details\u0027] \u003d dict(vlan\u003d\u00272145\u0027)"},{"line_number":1699,"context_line":"        network_info[0][\u0027profile\u0027] \u003d dict(trusted\u003d\u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_966fe526","line":1696,"range":{"start_line":1696,"start_character":53,"end_line":1696,"end_character":78},"updated":"2018-05-30 19:35:27.000000000","message":"nit: we should probably make this VNIC_TYPE_DIRECT since you can\u0027t have a direct-physical port that is trusted\u003dtrue; I mean, you could specify that when creating the port, but we\u0027ll ignore it here:\n\nhttps://review.openstack.org/#/c/458514/22/nova/virt/libvirt/vif.py@627","commit_id":"397e883d6715d2f2e4c40070ce73be68ebfb9b8d"}],"nova/virt/netutils.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3942cedf2b9d31bce3c14b24c0b41f2ed8cfd8d3","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def get_cached_vifs_with_trusted(network_info):"},{"line_number":355,"context_line":"    \"\"\"Generates a dict from a list of VIFs that trusted, MAC as key\"\"\""},{"line_number":356,"context_line":"    if network_info is None:"},{"line_number":357,"context_line":"        return {}"},{"line_number":358,"context_line":"    return {vif[\u0027address\u0027]: strutils.bool_from_string("},{"line_number":359,"context_line":"        vif[\u0027profile\u0027].get(\u0027trusted\u0027, \u0027False\u0027)) for vif in network_info"},{"line_number":360,"context_line":"            if vif.get(\u0027profile\u0027)}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1078c28d","line":360,"range":{"start_line":356,"start_character":4,"end_line":360,"end_character":34},"updated":"2018-05-30 13:09:13.000000000","message":"seems no ut for this.. add it would be a plus","commit_id":"472f0789804fefc67d5d0aa5069d15a6bc456852"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db16c533d2bb1b57cb613b93c0c5b63e529c035a","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def get_cached_vifs_with_trusted(network_info):"},{"line_number":355,"context_line":"    \"\"\"Generates a dict from a list of VIFs that trusted, MAC as key\"\"\""},{"line_number":356,"context_line":"    if network_info is None:"},{"line_number":357,"context_line":"        return {}"},{"line_number":358,"context_line":"    return {vif[\u0027address\u0027]: strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_569aad13","line":355,"range":{"start_line":355,"start_character":44,"end_line":355,"end_character":56},"updated":"2018-05-30 19:35:27.000000000","message":"based on the \u0027trusted\u0027 binding profile, with MAC\u003dtrusted key\u003dvalue.","commit_id":"397e883d6715d2f2e4c40070ce73be68ebfb9b8d"}]}