)]}'
{"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c0dece46bd47e198f61248596527a1881bb9d5c1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             /flavors APIs."},{"line_number":149,"context_line":"    * 2.62 - Add ``host`` and ``hostId`` fields to instance action detail API"},{"line_number":150,"context_line":"             responses."},{"line_number":151,"context_line":"    * 2.63 - Add PENDING in InstanceState."},{"line_number":152,"context_line":"\"\"\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5f02670d","line":151,"range":{"start_line":151,"start_character":13,"end_line":151,"end_character":42},"updated":"2018-06-05 09:26:17.000000000","message":"It is not clear which compute REST APIs are changed.","commit_id":"e95bc0e6963cafb38fb3338eac291347d253d717"}],"nova/conf/conductor.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2c770be12d102ebf32e064e661a2d3af236dccde","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        help\u003d\"\"\""},{"line_number":39,"context_line":"The conductor manager will set the instances that failed while shceduling due"},{"line_number":40,"context_line":"NoValidHost to the PENDING state if this option is set to True."},{"line_number":41,"context_line":"\"\"\"),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"migrate_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_92f63663","line":41,"updated":"2018-05-11 15:33:07.000000000","message":"I would be tempted to put this under the \"default\" category, as the operator does not immediately thing or need to know this is used by the conductor.","commit_id":"e95bc0e6963cafb38fb3338eac291347d253d717"}],"nova/objects/fields.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"49c1b72c4b3c8a33a980e4da8737574d83e00b1c","unresolved":false,"context_lines":[{"line_number":866,"context_line":"    RESIZED \u003d \u0027resized\u0027"},{"line_number":867,"context_line":"    SOFT_DELETED \u003d \u0027soft-delete\u0027"},{"line_number":868,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":869,"context_line":"    PENDING \u003d \u0027pending\u0027"},{"line_number":870,"context_line":"    ERROR \u003d \u0027error\u0027"},{"line_number":871,"context_line":"    SHELVED \u003d \u0027shelved\u0027"},{"line_number":872,"context_line":"    SHELVED_OFFLOADED \u003d \u0027shelved_offloaded\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_5625c607","line":869,"range":{"start_line":869,"start_character":4,"end_line":869,"end_character":23},"updated":"2019-02-01 03:40:45.000000000","message":"should you add this at the end of the enum?","commit_id":"44812470253aaf192ffa027b9221a959fd7fdf71"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2c770be12d102ebf32e064e661a2d3af236dccde","unresolved":false,"context_lines":[{"line_number":1976,"context_line":"        self.flags(use_pending_state\u003dFalse, group\u003d\u0027conductor\u0027)"},{"line_number":1977,"context_line":"        exception \u003d exc.NoValidHost(\u0027Foo\u0027)"},{"line_number":1978,"context_line":"        self.assertTrue(conductor_manager._get_failed_vm_state(exception),"},{"line_number":1979,"context_line":"                        vm_states.ERROR)"},{"line_number":1980,"context_line":""},{"line_number":1981,"context_line":"    def test_bury_in_cell0(self):"},{"line_number":1982,"context_line":"        bare_br \u003d self.params[\u0027build_requests\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d2282e98","line":1979,"updated":"2018-05-11 15:33:07.000000000","message":"Micro nit: Due to single responsibility I like these being separate test methods, but this is OK. I know some folks prefer it this way.","commit_id":"e95bc0e6963cafb38fb3338eac291347d253d717"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2c770be12d102ebf32e064e661a2d3af236dccde","unresolved":false,"context_lines":[{"line_number":2005,"context_line":"                                                      fast_deleted_br],"},{"line_number":2006,"context_line":"                                      instances\u003d[inst, deleted_inst])"},{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":"        self.flags(use_pending_state\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"        inst_pending_br \u003d fake_build_request.fake_req_obj(self.ctxt)"},{"line_number":2011,"context_line":"        del inst_pending_br.instance.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72327a12","line":2008,"updated":"2018-05-11 15:33:07.000000000","message":"Should this not be a separate test? Its really hard to follow now. I know the cut and paste of nasty help method feels bad when you create it, but I worry about maintaining this one longer term.","commit_id":"e95bc0e6963cafb38fb3338eac291347d253d717"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"49c1b72c4b3c8a33a980e4da8737574d83e00b1c","unresolved":false,"context_lines":[{"line_number":2146,"context_line":"        self.assertEqual(5, len(instances))"},{"line_number":2147,"context_line":"        inst_states \u003d {inst.uuid: (inst.deleted, inst.vm_state)"},{"line_number":2148,"context_line":"                       for inst in instances}"},{"line_number":2149,"context_line":""},{"line_number":2150,"context_line":"        expected \u003d {"},{"line_number":2151,"context_line":"            bare_br.instance_uuid: (False, vm_states.ERROR),"},{"line_number":2152,"context_line":"            inst_br.instance_uuid: (False, vm_states.ERROR),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_161bbec9","line":2149,"updated":"2019-02-01 03:40:45.000000000","message":"unrelated","commit_id":"44812470253aaf192ffa027b9221a959fd7fdf71"}]}