)]}'
{"nova/tests/unit/api/openstack/compute/admin_only_action_common.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85f948697833a274f24f9173a09ed3d80a76b120","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":33,"context_line":"        self.context \u003d self.req.environ[\u0027nova.context\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.mock_get \u003d self.useFixture("},{"line_number":36,"context_line":"            fixtures.MockPatch(\u0027nova.compute.api.API.get\u0027)).mock"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _stub_instance_get(self, uuid\u003dNone, exc\u003dFalse):"},{"line_number":39,"context_line":"        if uuid is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3cd2035e","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":64},"updated":"2018-05-07 10:37:40.000000000","message":"Rather than doing this, isn\u0027t it possible to decorate the setUp or use the \u0027start\u0027/\u0027stop\u0027 pattern to ensure this is reset each time?\n\n  https://github.com/openstack/nova/blob/dd2232c4/nova/tests/unit/compute/test_compute_utils.py#L289-L293","commit_id":"d93e20be46e1a5bae35bc3ff01bda10f6c6e57b0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7880939fa0d3f8a75da20208b93afefe3428061f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":33,"context_line":"        self.context \u003d self.req.environ[\u0027nova.context\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.mock_get \u003d self.useFixture("},{"line_number":36,"context_line":"            fixtures.MockPatch(\u0027nova.compute.api.API.get\u0027)).mock"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _stub_instance_get(self, uuid\u003dNone, exc\u003dFalse):"},{"line_number":39,"context_line":"        if uuid is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9c11c4af","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":64},"in_reply_to":"5f7c97a3_3cd2035e","updated":"2018-05-08 06:09:10.000000000","message":"This is the \u0027start\u0027/\u0027stop\u0027 pattern.\n\nhttps://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/mockpatch.py#L28-L31\n\nThe reason why reset_mock() is used is one test method calls private method (_test_xxxxx) multiple times.","commit_id":"d93e20be46e1a5bae35bc3ff01bda10f6c6e57b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85f948697833a274f24f9173a09ed3d80a76b120","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            fixtures.MockPatch(\u0027nova.compute.api.API.get\u0027)).mock"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _stub_instance_get(self, uuid\u003dNone, exc\u003dFalse):"},{"line_number":39,"context_line":"        if uuid is None:"},{"line_number":40,"context_line":"            uuid \u003d uuidutils.generate_uuid()"},{"line_number":41,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context,"},{"line_number":42,"context_line":"                id\u003d1, uuid\u003duuid, vm_state\u003dvm_states.ACTIVE,"},{"line_number":43,"context_line":"                task_state\u003dNone, launched_at\u003dtimeutils.utcnow())"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dcd98f83","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":44},"updated":"2018-05-07 10:37:40.000000000","message":"This is always unset. Can you remove the parameter?","commit_id":"d93e20be46e1a5bae35bc3ff01bda10f6c6e57b0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7880939fa0d3f8a75da20208b93afefe3428061f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            fixtures.MockPatch(\u0027nova.compute.api.API.get\u0027)).mock"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _stub_instance_get(self, uuid\u003dNone, exc\u003dFalse):"},{"line_number":39,"context_line":"        if uuid is None:"},{"line_number":40,"context_line":"            uuid \u003d uuidutils.generate_uuid()"},{"line_number":41,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context,"},{"line_number":42,"context_line":"                id\u003d1, uuid\u003duuid, vm_state\u003dvm_states.ACTIVE,"},{"line_number":43,"context_line":"                task_state\u003dNone, launched_at\u003dtimeutils.utcnow())"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fcc5583d","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":44},"in_reply_to":"5f7c97a3_dcd98f83","updated":"2018-05-08 06:09:10.000000000","message":"It is set in the following line.\n\nhttps://review.openstack.org/#/c/566528/1/nova/tests/unit/api/openstack/compute/test_migrate_server.py@214","commit_id":"d93e20be46e1a5bae35bc3ff01bda10f6c6e57b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85f948697833a274f24f9173a09ed3d80a76b120","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context,"},{"line_number":42,"context_line":"                id\u003d1, uuid\u003duuid, vm_state\u003dvm_states.ACTIVE,"},{"line_number":43,"context_line":"                task_state\u003dNone, launched_at\u003dtimeutils.utcnow())"},{"line_number":44,"context_line":"        if exc:"},{"line_number":45,"context_line":"            self.mock_get.side_effect \u003d exception.InstanceNotFound("},{"line_number":46,"context_line":"                instance_id\u003duuid)"},{"line_number":47,"context_line":"            return uuid"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.mock_get.return_value \u003d instance"},{"line_number":50,"context_line":"            return instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3ce9a319","line":47,"range":{"start_line":44,"start_character":0,"end_line":47,"end_character":23},"updated":"2018-05-07 10:37:40.000000000","message":"nit: I\u0027d have folded this whole thing into the calling function, given that it\u0027s only called once below. Also, \u0027instance\u0027 above is unused in this code path","commit_id":"d93e20be46e1a5bae35bc3ff01bda10f6c6e57b0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7880939fa0d3f8a75da20208b93afefe3428061f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context,"},{"line_number":42,"context_line":"                id\u003d1, uuid\u003duuid, vm_state\u003dvm_states.ACTIVE,"},{"line_number":43,"context_line":"                task_state\u003dNone, launched_at\u003dtimeutils.utcnow())"},{"line_number":44,"context_line":"        if exc:"},{"line_number":45,"context_line":"            self.mock_get.side_effect \u003d exception.InstanceNotFound("},{"line_number":46,"context_line":"                instance_id\u003duuid)"},{"line_number":47,"context_line":"            return uuid"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.mock_get.return_value \u003d instance"},{"line_number":50,"context_line":"            return instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1ca85475","line":47,"range":{"start_line":44,"start_character":0,"end_line":47,"end_character":23},"in_reply_to":"5f7c97a3_3ce9a319","updated":"2018-05-08 06:09:10.000000000","message":"Done","commit_id":"d93e20be46e1a5bae35bc3ff01bda10f6c6e57b0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2e04a82b45243887d7d4a12a38d4ee28c18309f2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return instance"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _test_non_existing_instance(self, action, body_map\u003dNone):"},{"line_number":48,"context_line":"        # Reset the mock."},{"line_number":49,"context_line":"        self.mock_get.reset_mock()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2b98fbbd","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":25},"updated":"2018-05-29 22:50:05.000000000","message":"Unless you\u0027re going to explain why this is necessary (which wouldn\u0027t be a terrible idea) this is not a useful comment.\n\nDitto throughout.","commit_id":"399554a518f730738d1bbd7dc5334cd271912baa"}]}