)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa59481f28528884792256e74988c461c48769df","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will be set to True if an instance is either deleted or soft_deleted."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Will be adding a data migration tool for filling this field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related to blueprint handling-down-cell"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_776f5ac4","line":15,"updated":"2018-07-11 14:19:26.000000000","message":"I\u0027d like to see this patch up for review before we get too far along in this series.","commit_id":"4d8711df45bdaaccec8c5f550e248574c34d43bd"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"a354a433256a60ac8fbaf6d8ecb4f16ade904037","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will be set to True if an instance is either deleted or soft_deleted."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Will be adding a data migration tool for filling this field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related to blueprint handling-down-cell"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_df188e84","line":15,"in_reply_to":"5f7c97a3_776f5ac4","updated":"2018-07-13 13:18:02.000000000","message":"Done: https://review.openstack.org/#/c/582536/","commit_id":"4d8711df45bdaaccec8c5f550e248574c34d43bd"}],"nova/objects/instance_mapping.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e46bc4d857c2a6e20c29a07ded7bc4a53699ccc9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027cell_mapping\u0027: fields.ObjectField(\u0027CellMapping\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027project_id\u0027: fields.StringField(),"},{"line_number":36,"context_line":"        \u0027queued_for_delete\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_5b37e0dc","line":36,"updated":"2018-07-23 19:01:12.000000000","message":"did you want to add nullable\u003dTrue here since the next patch that adds an online data migration for this checks to see values that are specifically NULL in the DB?","commit_id":"1c4a3827dab86d816a8596f9159ef8b183b9c390"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"549cc96964a4c244916b21a386f1dece20bab24c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027cell_mapping\u0027: fields.ObjectField(\u0027CellMapping\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027project_id\u0027: fields.StringField(),"},{"line_number":36,"context_line":"        \u0027queued_for_delete\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_d9b457f4","line":36,"in_reply_to":"5f7c97a3_59f927c3","updated":"2018-07-23 21:37:39.000000000","message":"Right, we don\u0027t want it nullable on the object, and this code works because SA is hiding the nullability of the model from us.","commit_id":"1c4a3827dab86d816a8596f9159ef8b183b9c390"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d8964a31f98f9f68a5670120c316470f32823b2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027cell_mapping\u0027: fields.ObjectField(\u0027CellMapping\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027project_id\u0027: fields.StringField(),"},{"line_number":36,"context_line":"        \u0027queued_for_delete\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_59f927c3","line":36,"in_reply_to":"5f7c97a3_5b37e0dc","updated":"2018-07-23 21:34:09.000000000","message":"I don\u0027t think so, but it makes me wonder how _from_db_object isn\u0027t exploding - oh I guess because of the default\u003dFalse? Then yeah that\u0027s what we want for existing instance mappings since we don\u0027t know but we\u0027ll only consult this if a cell is down anyway.","commit_id":"1c4a3827dab86d816a8596f9159ef8b183b9c390"}]}