)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2458589103aade175e29dfc6db70ebdf572d789b","unresolved":false,"context_lines":[{"line_number":7568,"context_line":"                    shutil.rmtree(instance_dir)"},{"line_number":7569,"context_line":""},{"line_number":7570,"context_line":"    def _pre_live_migration_plug_vifs(self, instance, network_info):"},{"line_number":7571,"context_line":"        # We call plug_vifs before the compute manager calls"},{"line_number":7572,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":7573,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7574,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7575,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":7576,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":7577,"context_line":"        for cnt in range(max_retry):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d2c5973e","line":7574,"range":{"start_line":7571,"start_character":0,"end_line":7574,"end_character":67},"updated":"2018-07-17 18:14:14.000000000","message":"copy/paste ack, but this could use a reword.","commit_id":"52b8d542549e51511b039c5c325f9ace18b005b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"97f54dde5f151820fde73e064202b0b877f4fb86","unresolved":false,"context_lines":[{"line_number":7568,"context_line":"                    shutil.rmtree(instance_dir)"},{"line_number":7569,"context_line":""},{"line_number":7570,"context_line":"    def _pre_live_migration_plug_vifs(self, instance, network_info):"},{"line_number":7571,"context_line":"        # We call plug_vifs before the compute manager calls"},{"line_number":7572,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":7573,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7574,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7575,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":7576,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":7577,"context_line":"        for cnt in range(max_retry):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_5e715b76","line":7574,"range":{"start_line":7571,"start_character":0,"end_line":7574,"end_character":67},"in_reply_to":"5f7c97a3_bb1f6207","updated":"2018-07-19 15:08:26.000000000","message":"Done in a follow up at the end of the series.","commit_id":"52b8d542549e51511b039c5c325f9ace18b005b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b4cdf3d82a2318b3d14da2749c447c421616af4","unresolved":false,"context_lines":[{"line_number":7568,"context_line":"                    shutil.rmtree(instance_dir)"},{"line_number":7569,"context_line":""},{"line_number":7570,"context_line":"    def _pre_live_migration_plug_vifs(self, instance, network_info):"},{"line_number":7571,"context_line":"        # We call plug_vifs before the compute manager calls"},{"line_number":7572,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":7573,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7574,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7575,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":7576,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":7577,"context_line":"        for cnt in range(max_retry):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_bb1f6207","line":7574,"range":{"start_line":7571,"start_character":0,"end_line":7574,"end_character":67},"in_reply_to":"5f7c97a3_d2c5973e","updated":"2018-07-19 15:03:14.000000000","message":"Maybe you mean move this to compute manager:\n\n\u003e # We call plug_vifs before the compute manager calls\n        # ensure_filtering_rules_for_instance, to ensure bridge is set up\n\nhttps://github.com/openstack/nova/blob/50f40854b04351fb622fd8b68b374a8fe8ca2070/nova/compute/manager.py#L6080\n\nSince that has the context on the ensure_filtering_rules_for_instance call.\n\nAs for the other part of the comment:\n\n\u003e # Retry operation is necessary because continuously request comes,\n        # concurrent request occurs to iptables, then it complains.\n\nThat comment is super duper old:\n\nhttps://github.com/openstack/nova/commit/2b7e2e8c1479fd2931ad6d99a9c1865976e44c21\n\nI guess it just means if multiple live migrations are getting sent to the same host at the same time they can fail iptables, but I\u0027m not sure if that\u0027s only a nova-network thing at this point or also something that could impact neutron.","commit_id":"52b8d542549e51511b039c5c325f9ace18b005b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"676eb3e73e94afab783fdfe1841208b4228c1238","unresolved":false,"context_lines":[{"line_number":7566,"context_line":"        # We call plug_vifs before the compute manager calls"},{"line_number":7567,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":7568,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7569,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7570,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":7571,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":7572,"context_line":"        for cnt in range(max_retry):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_3d49fcb6","line":7569,"range":{"start_line":7569,"start_character":39,"end_line":7569,"end_character":47},"updated":"2018-07-19 21:58:45.000000000","message":"im not sure why we care about iptables here.\niptables configuration should be handled by neutron.\ni think this is old code for nova-net that likely can be cleaned up when we remove nova-net.\n\nif you respin feel free to add a todo(sean-k-mooney) ... for me to clean it up when nova-net is gone.","commit_id":"5b554ed90dec0a662b8caa74e5f3073cf0e0631b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7acffd6b6973974864f44951afe3793fe8f7ee34","unresolved":false,"context_lines":[{"line_number":7566,"context_line":"        # We call plug_vifs before the compute manager calls"},{"line_number":7567,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":7568,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7569,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7570,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":7571,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":7572,"context_line":"        for cnt in range(max_retry):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_33492db7","line":7569,"range":{"start_line":7569,"start_character":39,"end_line":7569,"end_character":47},"in_reply_to":"5f7c97a3_3d49fcb6","updated":"2018-07-19 23:26:07.000000000","message":"This is just copying the existing comment, which from my sleuthing came from about 7 years ago, so yeah, it\u0027s old...","commit_id":"5b554ed90dec0a662b8caa74e5f3073cf0e0631b"}]}