)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"14346379c178c443946ef17e4a082a5dc203a0e4","unresolved":false,"context_lines":[{"line_number":7576,"context_line":"        if \u0027vifs\u0027 in migrate_data and migrate_data.vifs:"},{"line_number":7577,"context_line":"            LOG.debug(\u0027Plugging VIFs using destination host port bindings \u0027"},{"line_number":7578,"context_line":"                      \u0027before live migration.\u0027, instance\u003dinstance)"},{"line_number":7579,"context_line":"            # Plug VIFs using destination host port binding information."},{"line_number":7580,"context_line":"            vif_plug_nw_info \u003d network_model.NetworkInfo([])"},{"line_number":7581,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7582,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_120c6f91","line":7579,"range":{"start_line":7579,"start_character":12,"end_line":7579,"end_character":72},"updated":"2018-07-17 18:23:30.000000000","message":"This comment is unnecessary after that wonderful debug log.","commit_id":"a937a63dff71d0c22bc47bf792c28353649245ed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc247fcd57c967a2f6bd8a11a92e5373e6870e29","unresolved":false,"context_lines":[{"line_number":7576,"context_line":"        if \u0027vifs\u0027 in migrate_data and migrate_data.vifs:"},{"line_number":7577,"context_line":"            LOG.debug(\u0027Plugging VIFs using destination host port bindings \u0027"},{"line_number":7578,"context_line":"                      \u0027before live migration.\u0027, instance\u003dinstance)"},{"line_number":7579,"context_line":"            # Plug VIFs using destination host port binding information."},{"line_number":7580,"context_line":"            vif_plug_nw_info \u003d network_model.NetworkInfo([])"},{"line_number":7581,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7582,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_be0bcfd1","line":7579,"range":{"start_line":7579,"start_character":12,"end_line":7579,"end_character":72},"in_reply_to":"5f7c97a3_120c6f91","updated":"2018-07-19 15:09:00.000000000","message":"Done in a follow up.","commit_id":"a937a63dff71d0c22bc47bf792c28353649245ed"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eeb38d7bc127f88b7f09db1e20b40db4c48aff5","unresolved":false,"context_lines":[{"line_number":7569,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7570,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7571,"context_line":"        if \u0027vifs\u0027 in migrate_data and migrate_data.vifs:"},{"line_number":7572,"context_line":"            LOG.debug(\u0027Plugging VIFs using destination host port bindings \u0027"},{"line_number":7573,"context_line":"                      \u0027before live migration.\u0027, instance\u003dinstance)"},{"line_number":7574,"context_line":"            # Plug VIFs using destination host port binding information."},{"line_number":7575,"context_line":"            vif_plug_nw_info \u003d network_model.NetworkInfo([])"},{"line_number":7576,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7577,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_b8e0bacc","line":7574,"range":{"start_line":7572,"start_character":11,"end_line":7574,"end_character":72},"updated":"2018-07-19 22:42:24.000000000","message":"this is a little missleading\ntechnically at this point we are not plugging  yet\njust building the list of vif network info objects.","commit_id":"a81811e1118e61ef3f8bcb96200f9cbbebe8a6bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9eae451221670cd26bc0606cf561589995d3974b","unresolved":false,"context_lines":[{"line_number":7569,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7570,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7571,"context_line":"        if \u0027vifs\u0027 in migrate_data and migrate_data.vifs:"},{"line_number":7572,"context_line":"            LOG.debug(\u0027Plugging VIFs using destination host port bindings \u0027"},{"line_number":7573,"context_line":"                      \u0027before live migration.\u0027, instance\u003dinstance)"},{"line_number":7574,"context_line":"            # Plug VIFs using destination host port binding information."},{"line_number":7575,"context_line":"            vif_plug_nw_info \u003d network_model.NetworkInfo([])"},{"line_number":7576,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7577,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_89d56e49","line":7574,"range":{"start_line":7572,"start_character":11,"end_line":7574,"end_character":72},"in_reply_to":"5f7c97a3_33de0ddb","updated":"2018-07-20 00:48:49.000000000","message":"yep i know.\ni checked over the following lines to make sure notting could throw and excpetion or cause plug to not be called\n\nnothing jumps out at me so this should be  safe.\nmy original concern was could we print the log message and fail or exit before actully calling plug but we cant so its fine as is.","commit_id":"a81811e1118e61ef3f8bcb96200f9cbbebe8a6bd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be49f5c51f3ec5754ed5e8c5f63e3165ed6d043f","unresolved":false,"context_lines":[{"line_number":7569,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":7570,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":7571,"context_line":"        if \u0027vifs\u0027 in migrate_data and migrate_data.vifs:"},{"line_number":7572,"context_line":"            LOG.debug(\u0027Plugging VIFs using destination host port bindings \u0027"},{"line_number":7573,"context_line":"                      \u0027before live migration.\u0027, instance\u003dinstance)"},{"line_number":7574,"context_line":"            # Plug VIFs using destination host port binding information."},{"line_number":7575,"context_line":"            vif_plug_nw_info \u003d network_model.NetworkInfo([])"},{"line_number":7576,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7577,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_33de0ddb","line":7574,"range":{"start_line":7572,"start_character":11,"end_line":7574,"end_character":72},"in_reply_to":"5f7c97a3_b8e0bacc","updated":"2018-07-19 23:26:56.000000000","message":"I\u0027m gonna do some pluggin\u0027 real shortly and this has the context, that\u0027s why it\u0027s here.","commit_id":"a81811e1118e61ef3f8bcb96200f9cbbebe8a6bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eeb38d7bc127f88b7f09db1e20b40db4c48aff5","unresolved":false,"context_lines":[{"line_number":7576,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7577,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"},{"line_number":7578,"context_line":"        else:"},{"line_number":7579,"context_line":"            LOG.debug(\u0027Plugging VIFs before live migration.\u0027,"},{"line_number":7580,"context_line":"                      instance\u003dinstance)"},{"line_number":7581,"context_line":"            vif_plug_nw_info \u003d network_info"},{"line_number":7582,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_783c622f","line":7579,"range":{"start_line":7579,"start_character":23,"end_line":7579,"end_character":61},"updated":"2018-07-19 22:42:24.000000000","message":"for parity this should indicate that it is using the source vif bindings instead of the destination vifs. i.e. legacy workflow.","commit_id":"a81811e1118e61ef3f8bcb96200f9cbbebe8a6bd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"708e300e5f788ea7ec1fd2f9b09d13456ebd5130","unresolved":false,"context_lines":[{"line_number":7576,"context_line":"            for migrate_vif in migrate_data.vifs:"},{"line_number":7577,"context_line":"                vif_plug_nw_info.append(migrate_vif.get_dest_vif())"},{"line_number":7578,"context_line":"        else:"},{"line_number":7579,"context_line":"            LOG.debug(\u0027Plugging VIFs before live migration.\u0027,"},{"line_number":7580,"context_line":"                      instance\u003dinstance)"},{"line_number":7581,"context_line":"            vif_plug_nw_info \u003d network_info"},{"line_number":7582,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_cd7904c7","line":7579,"range":{"start_line":7579,"start_character":23,"end_line":7579,"end_character":61},"in_reply_to":"5f7c97a3_783c622f","updated":"2018-07-23 09:36:56.000000000","message":"Yeah, let\u0027s do it in a follow up.","commit_id":"a81811e1118e61ef3f8bcb96200f9cbbebe8a6bd"}]}