)]}'
{"nova/api/openstack/placement/handlers/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3181ce96a756f619815026b9a7d9365371abb71c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    data \u003d util.extract_json(req.body, schema)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        uuid \u003d data.setdefault(\u0027uuid\u0027, uuidutils.generate_uuid())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Normalize UUID with no proper dashes into dashed one"},{"line_number":94,"context_line":"        # with format {8}-{4}-{4}-{4}-{12}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b9581331","line":91,"updated":"2018-08-22 16:04:16.000000000","message":"anybody remember why this is setdefault  instead of get? setdefault is not really idiomatic and threw me off for a moment. It doesn\u0027t matter specifically to this change, except in the sense that if the default (the second arg) is used, we don\u0027t need to do any transformation, so there might be a different ordering we can do here, if that seemed appropriate","commit_id":"ce859a336cc1ece8bdcdfe9245cec933498aebfa"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4b27759f9bcd27e9c043b1b44b3d5b0b767095af","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        uuid \u003d data.setdefault(\u0027uuid\u0027, uuidutils.generate_uuid())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Normalize UUID with no proper dashes into dashed one"},{"line_number":94,"context_line":"        # with format {8}-{4}-{4}-{4}-{12}"},{"line_number":95,"context_line":"        uuid_nd \u003d \u0027\u0027.join(uuid.split(\u0027-\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3e5dc914","line":92,"updated":"2018-08-22 15:32:36.000000000","message":"This is a lot of manual work that the uuid.UUID class can do natively. Suggest:\n\n import uuid as uuidlib # So we don\u0027t have to rename all the \u0027uuid\u0027 variables in the file :)\n ...\n data[\u0027uuid\u0027] \u003d str(uuidlib.UUID(uuid))","commit_id":"ce859a336cc1ece8bdcdfe9245cec933498aebfa"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3181ce96a756f619815026b9a7d9365371abb71c","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        uuid \u003d data.setdefault(\u0027uuid\u0027, uuidutils.generate_uuid())"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # Normalize UUID with no proper dashes into dashed one"},{"line_number":94,"context_line":"        # with format {8}-{4}-{4}-{4}-{12}"},{"line_number":95,"context_line":"        uuid_nd \u003d \u0027\u0027.join(uuid.split(\u0027-\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3e1b89ca","line":92,"in_reply_to":"3f79a3b5_3e5dc914","updated":"2018-08-22 16:04:16.000000000","message":"yes, +1 to that","commit_id":"ce859a336cc1ece8bdcdfe9245cec933498aebfa"}],"nova/tests/functional/api/openstack/placement/gabbits/resource-provider.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3181ce96a756f619815026b9a7d9365371abb71c","unresolved":false,"context_lines":[{"line_number":757,"context_line":"  data:"},{"line_number":758,"context_line":"      name: rp with dashed uuid"},{"line_number":759,"context_line":"      uuid: 2290d4af-9e6e-400b-9d65-1ee01376f71a"},{"line_number":760,"context_line":"  status: 201"},{"line_number":761,"context_line":"  response_headers:"},{"line_number":762,"context_line":"      location: //resource_providers/[a-f0-9-]+/"},{"line_number":763,"context_line":"  response_forbidden_headers:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d984ef60","line":760,"updated":"2018-08-22 16:04:16.000000000","message":"it\u0027s 200 now, on recent microversions, and this file is using \u0027latest\u0027\n\nthis is the cause of the functional test failures","commit_id":"ce859a336cc1ece8bdcdfe9245cec933498aebfa"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4b27759f9bcd27e9c043b1b44b3d5b0b767095af","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    content-type: application/json"},{"line_number":770,"context_line":"  data:"},{"line_number":771,"context_line":"      name: rp with dashless uuid"},{"line_number":772,"context_line":"      uuid: 2290d4af-9e6e-400b-9d65-1ee01376f71a"},{"line_number":773,"context_line":"  status: 409"},{"line_number":774,"context_line":"  response_strings:"},{"line_number":775,"context_line":"      - \"Conflicting resource provider uuid: 2290d4af-9e6e-400b-9d65-1ee01376f71a already exists\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_de9b75c6","line":772,"range":{"start_line":772,"start_character":12,"end_line":772,"end_character":48},"updated":"2018-08-22 15:32:36.000000000","message":"did you mean to take the dashes out of this?","commit_id":"ce859a336cc1ece8bdcdfe9245cec933498aebfa"}]}