)]}'
{"api-ref/source/os-volume-attachments.inc":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"71a83c9b383f20576f285b04cf6baf713526cf9f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_03bac308","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"updated":"2018-05-14 06:01:52.000000000","message":"We are inconsistent at here. I prefer to call it as attachment_id at all the places.","commit_id":"a676d2e6b22b307287a6e18046e3384b7539de98"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"25a384e79d2faf5ff0522a908ea63fa44624b8e0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_49019605","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"in_reply_to":"5f7c97a3_031643f2","updated":"2018-05-15 13:23:33.000000000","message":"ok, so let us use volume_id instead of attacment_id. In the request body, there are also some of attachment_id should be replaced.","commit_id":"a676d2e6b22b307287a6e18046e3384b7539de98"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c2b8710204b6b696e594a21b89861f6b8b487353","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_031643f2","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"in_reply_to":"5f7c97a3_03bac308","updated":"2018-05-14 06:10:27.000000000","message":"The\u0027attachment_id\u0027 was replaced with \u0027volume_id\u0027 in https://review.openstack.org/#/c/480832/ .\nSo this \u0027attachment_id\u0027 should be replaced with \u0027volume_id\u0027.","commit_id":"a676d2e6b22b307287a6e18046e3384b7539de98"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7d612a3d2fdf9d7cb15b0ed143cde55995fe9349","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_ff91caf2","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"in_reply_to":"5f7c97a3_0a9367a5","updated":"2018-05-21 12:53:20.000000000","message":"ok, thanks, let us fix that in the other patch","commit_id":"a676d2e6b22b307287a6e18046e3384b7539de98"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c8ba33c5c3c82ee7fa24d0a0a4ab9c1110c0cd2b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Update a volume attachment"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_method:: PUT /servers/{server_id}/os-volume_attachments/{attachment_id}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update a volume attachment."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_0a9367a5","line":141,"range":{"start_line":141,"start_character":65,"end_line":141,"end_character":78},"in_reply_to":"5f7c97a3_49019605","updated":"2018-05-17 01:31:44.000000000","message":"The \u0027attachment_id\u0027 is not in the request body. There is just \u0027id\u0027.\nThen the \u0027attachment_id\u0027 in the path will be fixed in in https://review.openstack.org/#/c/565181/ .","commit_id":"a676d2e6b22b307287a6e18046e3384b7539de98"}]}