)]}'
{"nova/conf/xenserver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ad74a5b96138dc3845c19540b68248093685abb","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"Related options:"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"* ``vlan_interface``"},{"line_number":448,"context_line":"* ``ovs_integration_bridge``"},{"line_number":449,"context_line":"\"\"\"),"},{"line_number":450,"context_line":"    # TODO(dharinic): Make this, a stevedore plugin"},{"line_number":451,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_770f8c38","side":"PARENT","line":448,"range":{"start_line":447,"start_character":0,"end_line":448,"end_character":28},"updated":"2018-06-26 14:08:01.000000000","message":"note to self: These config opts have to be kept as they\u0027re related to neutron and the as-yet-not-entirely-removed nova-network feature","commit_id":"dcdcb273606f52093f812b8f0903da404b15732b"}],"nova/virt/xenapi/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ad74a5b96138dc3845c19540b68248093685abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f7c97a3_1aa3dd9c","updated":"2018-06-26 14:08:01.000000000","message":"We probably can/should fold the subclass into the parent class, now that we don\u0027t support extensions. That\u0027s a problem for another day though","commit_id":"c791cc4e04c4c8061ce0bf7c9a57e90de3001f56"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"edd5887c38391a5da8fde35763e3855c44f9a8e5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.firewall_driver \u003d firewall.load_driver("},{"line_number":149,"context_line":"            DEFAULT_FIREWALL_DRIVER,"},{"line_number":150,"context_line":"            xenapi_session\u003dself._session)"},{"line_number":151,"context_line":"        self.vif_driver \u003d xapi_vif.XenAPIOpenVswitchDriver("},{"line_number":152,"context_line":"            xenapi_session\u003dself._session)"},{"line_number":153,"context_line":"        self.default_root_dev \u003d \u0027/dev/sda\u0027"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b35206dd","line":151,"updated":"2018-05-16 09:09:57.000000000","message":"Hi, Matt, check https://review.openstack.org/#/c/567877/2/nova/tests/unit/virt/xenapi/stubs.py, it set `XenAPIBridgeDriver` as ut stub, which will use `XenVIFDriver.post_start_actions`. It is a blank function, so the UT would pass.\nAfter you removed it, function changed to `XenAPIOpenVswitchDriver.post_start_actions`, it is fully implemented, then it failed.","commit_id":"7989ece6fa8a112565962af80b96542b0c6e6f9b"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"e0b0b438cc4c9ed7bd3d47e01faf33086a0a61a1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.firewall_driver \u003d firewall.load_driver("},{"line_number":149,"context_line":"            DEFAULT_FIREWALL_DRIVER,"},{"line_number":150,"context_line":"            xenapi_session\u003dself._session)"},{"line_number":151,"context_line":"        self.vif_driver \u003d xapi_vif.XenAPIOpenVswitchDriver("},{"line_number":152,"context_line":"            xenapi_session\u003dself._session)"},{"line_number":153,"context_line":"        self.default_root_dev \u003d \u0027/dev/sda\u0027"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_330d96e7","line":151,"in_reply_to":"5f7c97a3_b35206dd","updated":"2018-05-16 09:11:43.000000000","message":"Will check if I could get a slot to fix this problem","commit_id":"7989ece6fa8a112565962af80b96542b0c6e6f9b"}],"releasenotes/notes/remove-xenserver-vif-driver-option-850f8dcfe54bca7c.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ad74a5b96138dc3845c19540b68248093685abb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[xenserver]/vif_driver`` configuration option was deprecated in"},{"line_number":5,"context_line":"    the 15.0.0 Ocata release and has now been removed. The only supported"},{"line_number":6,"context_line":"    vif driver is now ``XenAPIOpenVswitchDriver`` used with Neutron as the"},{"line_number":7,"context_line":"    backend networking service configured to run the"},{"line_number":8,"context_line":"    ``neutron-openvswitch-agent`` service. See the `XenServer configuration"},{"line_number":9,"context_line":"    guide`_ for more details on networking setup."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_1abc3db3","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"updated":"2018-06-26 14:08:01.000000000","message":"VIF","commit_id":"c791cc4e04c4c8061ce0bf7c9a57e90de3001f56"}]}