)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"518d53ee1f7637ef17aa43ffe74d4bed6da89f1c","unresolved":false,"context_lines":[{"line_number":7837,"context_line":"                            fp \u003d os.path.join(dirpath, f)"},{"line_number":7838,"context_line":"                            dk_size +\u003d os.path.getsize(fp)"},{"line_number":7839,"context_line":"                else:"},{"line_number":7840,"context_line":"                    dk_size \u003d disk_api.get_allocated_disk_size(path)"},{"line_number":7841,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":7842,"context_line":"                dk_size \u003d lvm.get_volume_size(path)"},{"line_number":7843,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_66f1536b","line":7840,"updated":"2018-05-12 01:40:07.000000000","message":"So for raw, we used to do this before:\n\nhttps://review.openstack.org/#/c/561704/1/nova/virt/libvirt/driver.py\n\ndk_size \u003d int(os.path.getsize(path))\n\nAnd now we\u0027re going to call below:\n\nvirt_size \u003d disk_api.get_disk_size(path)\n\nWhich is:\n\ndef get_disk_size(path):\n    \"\"\"Get the (virtual) size of a disk image\n\n    :param path: Path to the disk image\n    :returns: Size (in bytes) of the given disk image as it would be seen\n              by a virtual machine.\n    \"\"\"\n    return images.qemu_img_info(path).virtual_size\n\n\nSo it\u0027s still different from before but looks correct given get_disk_size is getting the virtual_size, so lgtm.","commit_id":"016986f4706e881fed16c85c8790af4d26a7c351"}]}