)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f22c5a8d5d3e0efd61ab7b276a85459e9ee3e80d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"3) compute.instance.shelve_offload.start"},{"line_number":22,"context_line":"4) compute.instance.shelve_offload.end"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"(Sniped from the gate to let other patches get ahead of it)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I6e075b3f29e1c3f641ab1e459e1fbe3b05869a9a"},{"line_number":27,"context_line":"Closes-Bug: #1248802"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BnLA%3D","line":24,"updated":"2013-11-22 14:08:19.000000000","message":"Can you take this back out of the commit message?","commit_id":"6c2fd32912d44cca7fb1f82df49f1fbab5134683"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"4ff2cb8ea72f1bcc4a409c175926ab38fb47f224","unresolved":false,"context_lines":[{"line_number":21,"context_line":"3) compute.instance.shelve_offload.start"},{"line_number":22,"context_line":"4) compute.instance.shelve_offload.end"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"(Sniped from the gate to let other patches get ahead of it)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I6e075b3f29e1c3f641ab1e459e1fbe3b05869a9a"},{"line_number":27,"context_line":"Closes-Bug: #1248802"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BnBM%3D","line":24,"in_reply_to":"AAAATn%2F%2BnLA%3D","updated":"2013-11-22 14:38:26.000000000","message":"Done","commit_id":"6c2fd32912d44cca7fb1f82df49f1fbab5134683"}],"nova/compute/manager.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"5936c882af3c4096152d7833e7814e8b6a3e7f03","unresolved":false,"context_lines":[{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"        self._notify_about_instance_usage(context, instance, \u0027shelve.end\u0027)"},{"line_number":3509,"context_line":""},{"line_number":3510,"context_line":"        if CONF.shelved_offload_time \u003d\u003d 0:"},{"line_number":3511,"context_line":"            self.shelve_offload_instance(context, instance)"},{"line_number":3512,"context_line":""},{"line_number":3513,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B5zA%3D","line":3510,"updated":"2013-11-18 19:12:32.000000000","message":"Since we\u0027re already down the path of changing order, does it make sense to move lines 3501-3502 to here?  And set state at same time?","commit_id":"f67dcaf015dd4fb9f8ca5904d38703e3325ae5f5"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c53520962098905c0c99d5ee38e8719ed867ca57","unresolved":false,"context_lines":[{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"        self._notify_about_instance_usage(context, instance, \u0027shelve.end\u0027)"},{"line_number":3509,"context_line":""},{"line_number":3510,"context_line":"        if CONF.shelved_offload_time \u003d\u003d 0:"},{"line_number":3511,"context_line":"            self.shelve_offload_instance(context, instance)"},{"line_number":3512,"context_line":""},{"line_number":3513,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B1Eo%3D","line":3510,"in_reply_to":"AAAATn%2F%2B5zA%3D","updated":"2013-11-19 16:24:40.000000000","message":"Thanks Chris, but the answer is no, as we need to save the instance object when CONF.shelved_offload_time is 0. If moving it here, we have no chance to update instance object.","commit_id":"f67dcaf015dd4fb9f8ca5904d38703e3325ae5f5"}],"nova/tests/compute/test_shelve.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d09d89e32cdf8d71ebafa9ef3c2b791b557948a5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.mox.StubOutWithMock(db, \u0027instance_update_and_get_original\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.compute._notify_about_instance_usage(self.context, instance,"},{"line_number":57,"context_line":"                                                  \u0027shelve.start\u0027)"},{"line_number":58,"context_line":"        self.compute.driver.power_off(instance)"},{"line_number":59,"context_line":"        self.compute._get_power_state(self.context, instance).AndReturn(123)"},{"line_number":60,"context_line":"        self.compute.driver.snapshot(self.context, instance, \u0027fake_image_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B61w%3D","line":57,"updated":"2013-11-18 15:39:14.000000000","message":"It\u0027s easier to review changes when there aren\u0027t unnecessary whitespace changes included.","commit_id":"f67dcaf015dd4fb9f8ca5904d38703e3325ae5f5"}]}
