)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"3feb2e3b94a0cf9c737515a11aa44a0032b26d56","unresolved":false,"context_lines":[{"line_number":3416,"context_line":"    @wrap_exception()"},{"line_number":3417,"context_line":"    def set_host_enabled(self, context, host, enabled):"},{"line_number":3418,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":3419,"context_line":"        # TODO(russellb) Remove the unused host parameter from the driver API"},{"line_number":3420,"context_line":"        return self.driver.set_host_enabled(host, enabled)"},{"line_number":3421,"context_line":""},{"line_number":3422,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2Fdsw%3D","line":3419,"updated":"2014-03-05 23:15:12.000000000","message":"The TODO comment should be removed if you\u0027re using the host parameter.","commit_id":"49e64ac4acfe419be000be8e26a4283b9c8618b4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6967278af0447ec73e03aecc23354d1a9f723e1a","unresolved":false,"context_lines":[{"line_number":3416,"context_line":"    @wrap_exception()"},{"line_number":3417,"context_line":"    def set_host_enabled(self, context, host, enabled):"},{"line_number":3418,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":3419,"context_line":"        # TODO(russellb) Remove the unused host parameter from the driver API"},{"line_number":3420,"context_line":"        return self.driver.set_host_enabled(host, enabled)"},{"line_number":3421,"context_line":""},{"line_number":3422,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FJuU%3D","line":3419,"in_reply_to":"AAAAVn%2F%2Fdsw%3D","updated":"2014-03-08 02:53:05.000000000","message":"Done","commit_id":"49e64ac4acfe419be000be8e26a4283b9c8618b4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"93e45796388cbe7f84feea7c8493340620e7e401","unresolved":false,"context_lines":[{"line_number":3564,"context_line":"    @wrap_exception()"},{"line_number":3565,"context_line":"    def set_host_enabled(self, context, enabled):"},{"line_number":3566,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":3567,"context_line":"        # TODO(russellb) Remove the unused host parameter from the driver API"},{"line_number":3568,"context_line":"        return self.driver.set_host_enabled(None, enabled)"},{"line_number":3569,"context_line":""},{"line_number":3570,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2F1gw%3D","side":"PARENT","line":3567,"updated":"2014-03-13 13:59:44.000000000","message":"I think we should do what russellb suggests here.\n\nWhen you look at XenAPI, all that needs to be fixed is this line:\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/host.py#L127\n\nIf should use CONF.host instead of the host that is passed in.\n\nBut I could be missing something.","commit_id":"e2d45e820070328d80783fcfb88beefa4f35ebe3"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"61ba8eedf58be7416722b466075b510e0a9e288f","unresolved":false,"context_lines":[{"line_number":3564,"context_line":"    @wrap_exception()"},{"line_number":3565,"context_line":"    def set_host_enabled(self, context, enabled):"},{"line_number":3566,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":3567,"context_line":"        # TODO(russellb) Remove the unused host parameter from the driver API"},{"line_number":3568,"context_line":"        return self.driver.set_host_enabled(None, enabled)"},{"line_number":3569,"context_line":""},{"line_number":3570,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAWH%2F%2F0VU%3D","side":"PARENT","line":3567,"in_reply_to":"AAAAWH%2F%2F1gw%3D","updated":"2014-03-13 16:08:55.000000000","message":"Thanks John, you are correct.","commit_id":"e2d45e820070328d80783fcfb88beefa4f35ebe3"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3c0785daa439fbaa5e362af7191f235deee3a705","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        return cctxt.call(ctxt, \u0027validate_console_port\u0027,"},{"line_number":423,"context_line":"                          instance\u003dinstance_p, port\u003dport,"},{"line_number":424,"context_line":"                          console_type\u003dconsole_type)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def host_maintenance_mode(self, ctxt, host_param, mode, host):"},{"line_number":427,"context_line":"        \u0027\u0027\u0027Set host maintenance mode"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B73o%3D","line":425,"updated":"2013-11-18 12:19:25.000000000","message":"Like this.","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"169feebcdf6412a10df4a8899db7458e5bbc4d69","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        return cctxt.call(ctxt, \u0027validate_console_port\u0027,"},{"line_number":423,"context_line":"                          instance\u003dinstance_p, port\u003dport,"},{"line_number":424,"context_line":"                          console_type\u003dconsole_type)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def host_maintenance_mode(self, ctxt, host_param, mode, host):"},{"line_number":427,"context_line":"        \u0027\u0027\u0027Set host maintenance mode"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B7Ms%3D","line":425,"in_reply_to":"AAAATn%2F%2B73o%3D","updated":"2013-11-18 15:14:22.000000000","message":"Done","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3c0785daa439fbaa5e362af7191f235deee3a705","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":686,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B71Y%3D","line":688,"updated":"2013-11-18 12:19:25.000000000","message":"Add another arg \"host_param\"","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"169feebcdf6412a10df4a8899db7458e5bbc4d69","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":686,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B7Mk%3D","line":688,"in_reply_to":"AAAATn%2F%2B71Y%3D","updated":"2013-11-18 15:14:22.000000000","message":"Done","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3c0785daa439fbaa5e362af7191f235deee3a705","unresolved":false,"context_lines":[{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def swap_volume(self, ctxt, instance, old_volume_id, new_volume_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B71o%3D","line":690,"updated":"2013-11-18 12:19:25.000000000","message":"Then, host\u003dhost_param instead.","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"169feebcdf6412a10df4a8899db7458e5bbc4d69","unresolved":false,"context_lines":[{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def swap_volume(self, ctxt, instance, old_volume_id, new_volume_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B7Mg%3D","line":690,"in_reply_to":"AAAATn%2F%2B71o%3D","updated":"2013-11-18 15:14:22.000000000","message":"Done","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"325efb94c74fe2c91d6b16dc7ec95a64c77a19fb","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":686,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, host_param, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost_param,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B6ZQ%3D","line":688,"updated":"2013-11-18 16:42:32.000000000","message":"You\u0027re changing the API, therefore the version needs to increment, see line 65.  You would also need to make sure the client can send the version, see line 674.","commit_id":"38685257c79f22f9864ceb069278362b123a994e"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"b52d6035b8f5315f09ed6ddcd449da6bcc8ec7da","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":686,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, host_param, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost_param,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B1IA%3D","line":688,"in_reply_to":"AAAATn%2F%2B1sE%3D","updated":"2013-11-19 16:15:15.000000000","message":"Done","commit_id":"38685257c79f22f9864ceb069278362b123a994e"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"b52d6035b8f5315f09ed6ddcd449da6bcc8ec7da","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":686,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, host_param, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost_param,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B1IE%3D","line":688,"in_reply_to":"AAAATn%2F%2B6ZQ%3D","updated":"2013-11-19 16:15:15.000000000","message":"Done","commit_id":"38685257c79f22f9864ceb069278362b123a994e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"30912a31e2c929b813cdd430a50240e25eb763bb","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":686,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def set_host_enabled(self, ctxt, host_param, enabled, host):"},{"line_number":689,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost)"},{"line_number":690,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, host\u003dhost_param,"},{"line_number":691,"context_line":"                          enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B1sE%3D","line":688,"in_reply_to":"AAAATn%2F%2B6ZQ%3D","updated":"2013-11-19 14:19:32.000000000","message":"See #2 here:\n\nhttps://wiki.openstack.org/wiki/ReviewChecklist#Nova_Review_Checklist","commit_id":"38685257c79f22f9864ceb069278362b123a994e"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"6d6efdfbf57abd26394acb284802aae3126b3600","unresolved":false,"context_lines":[{"line_number":692,"context_line":"            version \u003d \u00272.49\u0027"},{"line_number":693,"context_line":"            msg_kwargs[\u0027host\u0027] \u003d host_param"},{"line_number":694,"context_line":"        else:"},{"line_number":695,"context_line":"            version \u003d \u00272.47\u0027"},{"line_number":696,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":697,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, **msg_kwargs)"},{"line_number":698,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B0RA%3D","line":695,"updated":"2013-11-19 19:10:09.000000000","message":"Also I think you should mark this as 2.0 , otherwise all deployment between 2.47~2.0 is broken, I think.","commit_id":"01ba2b14dd522666b09c3af9932a72ff53a281f7"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"2ad4f2e87cb1bebd2533c975195c86860c3ff1f4","unresolved":false,"context_lines":[{"line_number":692,"context_line":"            version \u003d \u00272.49\u0027"},{"line_number":693,"context_line":"            msg_kwargs[\u0027host\u0027] \u003d host_param"},{"line_number":694,"context_line":"        else:"},{"line_number":695,"context_line":"            version \u003d \u00272.47\u0027"},{"line_number":696,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":697,"context_line":"        return cctxt.call(ctxt, \u0027set_host_enabled\u0027, **msg_kwargs)"},{"line_number":698,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Byw0%3D","line":695,"in_reply_to":"AAAATn%2F%2B0RA%3D","updated":"2013-11-20 04:53:01.000000000","message":"Done","commit_id":"01ba2b14dd522666b09c3af9932a72ff53a281f7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f2e1b648e5f180286655420f52bf6ba227f40d9d","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":710,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    def set_host_enabled(self, ctxt, enabled, host, host_param\u003dNone):"},{"line_number":713,"context_line":"        msg_kwargs \u003d {\u0027enabled\u0027: enabled}"},{"line_number":714,"context_line":"        if self.can_send_version(\u00273.5\u0027):"},{"line_number":715,"context_line":"            version \u003d \u00273.5\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2FGo%3D","line":712,"updated":"2014-01-04 22:21:30.000000000","message":"Why is host_param needed when you already have host?  Why can\u0027t you just set msg_kwargs[\u0027host\u0027] \u003d host?","commit_id":"c357aa8397face7135224d0fef7734203824c597"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"e5fe81f278b3f4b7a75c04bc0217ab3e0751d110","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        return cctxt.call(ctxt, \u0027set_admin_password\u0027,"},{"line_number":710,"context_line":"                          instance\u003dinstance_p, new_pass\u003dnew_pass)"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    def set_host_enabled(self, ctxt, enabled, host, host_param\u003dNone):"},{"line_number":713,"context_line":"        msg_kwargs \u003d {\u0027enabled\u0027: enabled}"},{"line_number":714,"context_line":"        if self.can_send_version(\u00273.5\u0027):"},{"line_number":715,"context_line":"            version \u003d \u00273.5\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2FDk%3D","line":712,"in_reply_to":"AAAAUH%2F%2F%2FGo%3D","updated":"2014-01-05 02:05:11.000000000","message":"Matt, you can refer to https://review.openstack.org/#/c/56812/1/nova/tests/compute/test_rpcapi.py for some discussion of this.\n\nAlso you may notice that all of the RPC APIs will need host_param if host need to put to msg_kwargs\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nArata Notsu\t\tNov 18\n\nPatch Set 1: (5 inline comments)\n\nIn rpcai.py, probably we should use \"host\" only to determine a destination of RPC messages. So it is better to use host_param instead. See inline comments for detail. If you do so, you have to change compute/api.py too.","commit_id":"c357aa8397face7135224d0fef7734203824c597"}],"nova/tests/compute/test_rpcapi.py":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3c0785daa439fbaa5e362af7191f235deee3a705","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        rpcapi \u003d rpcapi_class()"},{"line_number":54,"context_line":"        expected_retval \u003d \u0027foo\u0027 if method \u003d\u003d \u0027call\u0027 else None"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        need_host_param_cast_and_call \u003d [\u0027set_host_enabled\u0027]"},{"line_number":57,"context_line":"        expected_version \u003d kwargs.pop(\u0027version\u0027, rpcapi.BASE_RPC_API_VERSION)"},{"line_number":58,"context_line":"        expected_msg \u003d rpcapi.make_msg(method, **kwargs)"},{"line_number":59,"context_line":"        if \u0027host_param\u0027 in expected_msg[\u0027args\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B70g%3D","line":56,"updated":"2013-11-18 12:19:25.000000000","message":"This change will be not needed,","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"169feebcdf6412a10df4a8899db7458e5bbc4d69","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        rpcapi \u003d rpcapi_class()"},{"line_number":54,"context_line":"        expected_retval \u003d \u0027foo\u0027 if method \u003d\u003d \u0027call\u0027 else None"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        need_host_param_cast_and_call \u003d [\u0027set_host_enabled\u0027]"},{"line_number":57,"context_line":"        expected_version \u003d kwargs.pop(\u0027version\u0027, rpcapi.BASE_RPC_API_VERSION)"},{"line_number":58,"context_line":"        expected_msg \u003d rpcapi.make_msg(method, **kwargs)"},{"line_number":59,"context_line":"        if \u0027host_param\u0027 in expected_msg[\u0027args\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B7MM%3D","line":56,"in_reply_to":"AAAATn%2F%2B70g%3D","updated":"2013-11-18 15:14:22.000000000","message":"Done","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"3c0785daa439fbaa5e362af7191f235deee3a705","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            del expected_msg[\u0027args\u0027][\u0027host_param\u0027]"},{"line_number":62,"context_line":"            expected_msg[\u0027args\u0027][\u0027host\u0027] \u003d host_param"},{"line_number":63,"context_line":"        elif \u0027host\u0027 in expected_msg[\u0027args\u0027]:"},{"line_number":64,"context_line":"            if method not in need_host_param_cast_and_call:"},{"line_number":65,"context_line":"                del expected_msg[\u0027args\u0027][\u0027host\u0027]"},{"line_number":66,"context_line":"        if \u0027destination\u0027 in expected_msg[\u0027args\u0027]:"},{"line_number":67,"context_line":"            del expected_msg[\u0027args\u0027][\u0027destination\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B70M%3D","line":64,"updated":"2013-11-18 12:19:25.000000000","message":"same","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"169feebcdf6412a10df4a8899db7458e5bbc4d69","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            del expected_msg[\u0027args\u0027][\u0027host_param\u0027]"},{"line_number":62,"context_line":"            expected_msg[\u0027args\u0027][\u0027host\u0027] \u003d host_param"},{"line_number":63,"context_line":"        elif \u0027host\u0027 in expected_msg[\u0027args\u0027]:"},{"line_number":64,"context_line":"            if method not in need_host_param_cast_and_call:"},{"line_number":65,"context_line":"                del expected_msg[\u0027args\u0027][\u0027host\u0027]"},{"line_number":66,"context_line":"        if \u0027destination\u0027 in expected_msg[\u0027args\u0027]:"},{"line_number":67,"context_line":"            del expected_msg[\u0027args\u0027][\u0027destination\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B7MI%3D","line":64,"in_reply_to":"AAAATn%2F%2B70M%3D","updated":"2013-11-18 15:14:22.000000000","message":"Done","commit_id":"d7b36b216ca317efae35500925bb9712accb359c"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"21ca7b2cf87921f75ff15ba02c834c348ba00c2a","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        # NOTE(russellb) Havana compat"},{"line_number":649,"context_line":"        self.flags(compute\u003d\u0027havana\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":650,"context_line":"        self._test_compute_api(\u0027set_host_enabled\u0027, \u0027call\u0027,"},{"line_number":651,"context_line":"                host_param\u003d\u0027host\u0027, enabled\u003d\u0027enabled\u0027, host\u003d\u0027host\u0027,"},{"line_number":652,"context_line":"                version\u003d\u00272.0\u0027)"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def test_get_host_uptime(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9qN0%3D","line":651,"updated":"2013-12-09 06:40:56.000000000","message":"Is it possible to leave this line unchanged? If so, you can leave L56-67 also unchanged and it will make this patch simpler.","commit_id":"b8ee2ad6b3d74fb5542b0b3da5a242f18b1673c9"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c34d46c3ece86a6aaf5a3df09f84bb1a22d30f47","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        # NOTE(russellb) Havana compat"},{"line_number":649,"context_line":"        self.flags(compute\u003d\u0027havana\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":650,"context_line":"        self._test_compute_api(\u0027set_host_enabled\u0027, \u0027call\u0027,"},{"line_number":651,"context_line":"                host_param\u003d\u0027host\u0027, enabled\u003d\u0027enabled\u0027, host\u003d\u0027host\u0027,"},{"line_number":652,"context_line":"                version\u003d\u00272.0\u0027)"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def test_get_host_uptime(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9qHk%3D","line":651,"in_reply_to":"AAAATn%2F9qN0%3D","updated":"2013-12-09 07:18:32.000000000","message":"Done","commit_id":"b8ee2ad6b3d74fb5542b0b3da5a242f18b1673c9"}],"nova/virt/xenapi/host.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d3a37ac3dc2912210b9c3912ac9dcebbf4085918","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            raise exception.NoValidHost(reason\u003d\u0027Unable to find suitable \u0027"},{"line_number":117,"context_line":"                                                   \u0027host for VMs evacuation\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def set_host_enabled(self, host, enabled):"},{"line_number":120,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":121,"context_line":"        # Since capabilities are gone, use service table to disable a node"},{"line_number":122,"context_line":"        # in scheduler"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_a92cda4b","line":119,"updated":"2014-05-08 17:25:45.000000000","message":"please remove this host argument here, and follow that up into driver.py, to tidy up this code a little.\n\nIdeally, given the host is now blank, it should be noted as missing up here:\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/driver.py#L662","commit_id":"0acc084a22484ddc29fc679f9646a0f25247c424"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"7c9976172e67a9f0e39ecf24781c2a02401296d9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            raise exception.NoValidHost(reason\u003d\u0027Unable to find suitable \u0027"},{"line_number":117,"context_line":"                                                   \u0027host for VMs evacuation\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def set_host_enabled(self, host, enabled):"},{"line_number":120,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":121,"context_line":"        # Since capabilities are gone, use service table to disable a node"},{"line_number":122,"context_line":"        # in scheduler"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_f3394fd9","line":119,"in_reply_to":"7adec928_a92cda4b","updated":"2014-05-22 16:39:49.000000000","message":"Done","commit_id":"0acc084a22484ddc29fc679f9646a0f25247c424"}]}