)]}'
{"nova/compute/api.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"fbb58824d806a4c5649b92d713106be699fd4c98","unresolved":false,"context_lines":[{"line_number":4776,"context_line":"        # callers need the legacy behavior for now."},{"line_number":4777,"context_line":"        if all_cells:"},{"line_number":4778,"context_line":"            services \u003d []"},{"line_number":4779,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":4780,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"},{"line_number":4781,"context_line":"            for service in service_dict.values():"},{"line_number":4782,"context_line":"                if service not in (nova_context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0d87fcb8","line":4779,"range":{"start_line":4779,"start_character":40,"end_line":4779,"end_character":64},"updated":"2018-05-17 09:09:46.000000000","message":"should scatter_gather_skip_cell0 be better? as cell0 will not have any services","commit_id":"a016e8141bca62ba6ba7740b884e1c41df7fbad3"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2de3a6760f3538b7bf4a31d54350889aa178c2cb","unresolved":false,"context_lines":[{"line_number":4776,"context_line":"        # callers need the legacy behavior for now."},{"line_number":4777,"context_line":"        if all_cells:"},{"line_number":4778,"context_line":"            services \u003d []"},{"line_number":4779,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":4780,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"},{"line_number":4781,"context_line":"            for service in service_dict.values():"},{"line_number":4782,"context_line":"                if service not in (nova_context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ad34c8fc","line":4779,"range":{"start_line":4779,"start_character":40,"end_line":4779,"end_character":64},"in_reply_to":"5f7c97a3_0d87fcb8","updated":"2018-05-17 09:14:29.000000000","message":"Its inside the cell0 DB that we have the records of the global scheduler and super-conductor servieces, so we should not skip it.","commit_id":"a016e8141bca62ba6ba7740b884e1c41df7fbad3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"24d6da24059a655c6d3520808020a957f605ec4d","unresolved":false,"context_lines":[{"line_number":4776,"context_line":"        # callers need the legacy behavior for now."},{"line_number":4777,"context_line":"        if all_cells:"},{"line_number":4778,"context_line":"            services \u003d []"},{"line_number":4779,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":4780,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"},{"line_number":4781,"context_line":"            for service in service_dict.values():"},{"line_number":4782,"context_line":"                if service not in (nova_context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4807221a","line":4779,"range":{"start_line":4779,"start_character":40,"end_line":4779,"end_character":64},"in_reply_to":"5f7c97a3_ad34c8fc","updated":"2018-05-17 09:16:10.000000000","message":"Ah yes, I forgot that, thanks for the clearify","commit_id":"a016e8141bca62ba6ba7740b884e1c41df7fbad3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1b65cb73df9bfccef9192c8221daccf371a658ce","unresolved":false,"context_lines":[{"line_number":4776,"context_line":"        # callers need the legacy behavior for now."},{"line_number":4777,"context_line":"        if all_cells:"},{"line_number":4778,"context_line":"            services \u003d []"},{"line_number":4779,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":4780,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"},{"line_number":4781,"context_line":"            for service in service_dict.values():"},{"line_number":4782,"context_line":"                if service not in (nova_context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_36eb7113","line":4779,"updated":"2018-05-30 19:01:33.000000000","message":"Not related to this patch as this patch isn\u0027t changing previous CELLS, but not sure we need to be looking in cell0 for this.","commit_id":"64e76de43dc55e584c100005fa60da50dd06d352"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc0505c037209627326be4363ba98576e61e73ed","unresolved":false,"context_lines":[{"line_number":4776,"context_line":"        # callers need the legacy behavior for now."},{"line_number":4777,"context_line":"        if all_cells:"},{"line_number":4778,"context_line":"            services \u003d []"},{"line_number":4779,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":4780,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"},{"line_number":4781,"context_line":"            for service in service_dict.values():"},{"line_number":4782,"context_line":"                if service not in (nova_context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b6c78196","line":4779,"in_reply_to":"5f7c97a3_36eb7113","updated":"2018-05-30 19:02:24.000000000","message":"Nevermind -- just saw the comments explaining this on PS2.","commit_id":"64e76de43dc55e584c100005fa60da50dd06d352"}],"nova/tests/unit/compute/test_host_api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1b65cb73df9bfccef9192c8221daccf371a658ce","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                                  host\u003d\u0027host-%s\u0027 % uuids.cell1)"},{"line_number":193,"context_line":"        mock_sg.return_value \u003d {"},{"line_number":194,"context_line":"            uuids.cell1: [service],"},{"line_number":195,"context_line":"            uuids.cell2: context.raised_exception_sentinel"},{"line_number":196,"context_line":"        }"},{"line_number":197,"context_line":"        services \u003d self.host_api.service_get_all(self.ctxt, all_cells\u003dTrue)"},{"line_number":198,"context_line":"        # returns the results from cell1 and ignores cell2."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b6dea16a","line":195,"updated":"2018-05-30 19:01:33.000000000","message":"To be more complete, we\u0027d add cell3 context.did_not_respond_sentinel here.","commit_id":"64e76de43dc55e584c100005fa60da50dd06d352"}]}
